Install/Build Guestadditions on SLES12SP4 failed -> fixed after (not in) 6.0.0/5.2.22 and in test builds

[SUSI]

Install / build guest addition in SLES12SP4 guest will fail (see below): SLES12SP4 has the same Kernel as SLES15. Please adappt in file src/vboxguest-6.0.0/vboxvideo/vbox_mode.c line 355 => SLES15 and SLES12SP4

...

/tmp/vbox.0/.tmp_vbox_mode.o /tmp/vbox.0/vbox_mode.c

/tmp/vbox.0/vbox_mode.c: In function ‘vbox_best_single_encoder’: /tmp/vbox.0/vbox_mode.c:359:3: warning: passing argument 2 of ‘drm_encoder_find’ makes pointer from integer without a cast [enabled by default]

return drm_encoder_find(connector->dev, enc_id);

In file included from /tmp/vbox.0/vbox_drv.h:85:0,

from /tmp/vbox.0/vbox_mode.c:35:

/usr/src/linux-4.12.14-95.3/include/drm/drm_encoder.h:216:35: note: expected ‘struct drm_file *’ but argument is of type ‘int’

static inline struct drm_encoder *drm_encoder_find(struct drm_device *dev,

/tmp/vbox.0/vbox_mode.c:359:3: error: too few arguments to function ‘drm_encoder_find’

return drm_encoder_find(connector->dev, enc_id);

In file included from /tmp/vbox.0/vbox_drv.h:85:0,

from /tmp/vbox.0/vbox_mode.c:35:

/usr/src/linux-4.12.14-95.3/include/drm/drm_encoder.h:216:35: note: declared here

static inline struct drm_encoder *drm_encoder_find(struct drm_device *dev,

/usr/src/linux-4.12.14-95.3/scripts/Makefile.build:326: recipe for target '/tmp/vbox.0/vbox_mode.o' failed make[4]: * tmp/vbox.0/vbox_mode.o Error 1 /usr/src/linux-4.12.14-95.3/Makefile:1564: recipe for target '_module_/tmp/vbox.0' failed make[3]: * [_module_/tmp/vbox.0] Error 2 Makefile:152: recipe for target 'sub-make' failed make[2]: * [sub-make] Error 2 Makefile:24: recipe for target 'sub-make' failed make[1]: * [sub-make] Error 2 /tmp/vbox.0/Makefile.include.footer:106: recipe for target 'vboxvideo' failed make: * [vboxvideo] Error 2

[Michael Thayer]

Since I do not have easy access to SLES12, would you be able to provide a patch?

[Platypus]

I can confirm building guest additions is not working for SLES 12.4. I removed the condition for SLES in line 355 of file src/vboxguest-6.0.0/vboxvideo/vbox_mode.c as mentioned above and building works again. Attached you can find the patch.

[Michael Thayer]

I hope this will be fixed in the 6.0 test builds<1> as of revision 128006, hopefully visible in an hour or two. Please confirm so that I know if I can apply the fix to the 5.2 builds as well.

1. wiki:Testbuilds

[Michael Thayer]

I will assume this is fixed unless you give feedback that it is not. If you try out a test build there is no reason not to keep on using it as long as there is no new release, as it is expected to be as stable as a release build for most purposes and includes bug fixes since the last release.