VirtualBox

Opened 7 years ago

Closed 7 years ago

#17557 closed defect (fixed)

Silly bug in egl.c. => Fixed in SVN

Reported by: mi Owned by:
Component: other Version: VirtualBox 5.2.6
Keywords: Cc:
Guest type: other Host type: other

Description

The compiler warns about this, so I don't know, how this was allowed into a release... The fix is very simple:

--- src/VBox/Additions/common/crOpenGL/egl.c	2018-01-15 09:49:53
+++ src/VBox/Additions/common/crOpenGL/egl.c	2018-02-20 10:56:16
@@ -347,5 +347,5 @@
         for (pAttrib2 = pAttrib + 2; *pAttrib2 != EGL_NONE; pAttrib2 += 2)
             if (*pAttrib2 == *pAttrib)
-                fSkip == true;
+                fSkip = true;
         if (fSkip)
             continue;

Also, maybe, the inner loop should also break after assigning fSkip -- no obvious need for the loop to continue scanning through attributes, once it finds the first duplicate.

Change History (2)

comment:1 by Dmitrii Grigorev, 7 years ago

Summary: Silly bug in egl.cSilly bug in egl.c. => Fixed in SVN

comment:2 by Dmitrii Grigorev, 7 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette