Changeset 99775 in vbox for trunk/src/bldprogs/scmsubversion.cpp

Timestamp:

May 12, 2023 12:21:58 PM (18 months ago)

Author:

vboxsync

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

File:

• trunk/src/bldprogs/scmsubversion.cpp (modified) (2 diffs)

trunk/src/bldprogs/scmsubversion.cpp

@@ -327 +327 @@
  *                      Free with RTStrFree, regardless of return status.
  */
-int RTProcExecToString(const char *pszExec, const char * const *papszArgs, RTENV hEnv, uint32_t fFlags,
-                       PRTPROCSTATUS pStatus, char **ppszStdOut, char **ppszStdErr)
+static int RTProcExecToString(const char *pszExec, const char * const *papszArgs, RTENV hEnv, uint32_t fFlags,
+                              PRTPROCSTATUS pStatus, char **ppszStdOut, char **ppszStdErr)
 {
     int rc2;
@@ -509 +509 @@
  * @param   pStatus     Where to return the status on success.
  */
-int RTProcExec(const char *pszExec, const char * const *papszArgs, RTENV hEnv, uint32_t fFlags,
-               PRTPROCSTATUS pStatus)
+static int RTProcExec(const char *pszExec, const char * const *papszArgs, RTENV hEnv, uint32_t fFlags,
+                      PRTPROCSTATUS pStatus)
 {
     int rc;