VirtualBox

Changes between Initial Version and Version 1 of Ticket #16835


Ignore:
Timestamp:
Jun 21, 2017 12:12:33 PM (7 years ago)
Author:
Frank Mehnert
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16835 – Description

    initial v1  
    11Function rtlogFlush() in vboxguest/common/log/log.c performs a paronoid check:
    2 
     2{{{
    33    /*
    44     * If the ring buffer is active, the other destinations are only written
     
    1313    }
    1414    else ...
    15    
     15}}}   
    1616This implies that pLogger->pInt could be NULL (even if this is an unlikely paranoid case). In the else path we have the following code that dereferences pLogginer->pInt and hence we may have a NULL pointer deference:
    17 
     17{{{
    1818        if (pLogger->pInt->pfnFlush)
    1919            pLogger->pInt->pfnFlush(pLogger);
    20 
     20}}}
    2121I guess this is unlikely, but I think it would be good to correctly sanity check this for this corner case.
    22 

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette