Changes between Initial Version and Version 1 of Ticket #16835
- Timestamp:
- Jun 21, 2017 12:12:33 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #16835 – Description
initial v1 1 1 Function rtlogFlush() in vboxguest/common/log/log.c performs a paronoid check: 2 2 {{{ 3 3 /* 4 4 * If the ring buffer is active, the other destinations are only written … … 13 13 } 14 14 else ... 15 15 }}} 16 16 This implies that pLogger->pInt could be NULL (even if this is an unlikely paranoid case). In the else path we have the following code that dereferences pLogginer->pInt and hence we may have a NULL pointer deference: 17 17 {{{ 18 18 if (pLogger->pInt->pfnFlush) 19 19 pLogger->pInt->pfnFlush(pLogger); 20 20 }}} 21 21 I guess this is unlikely, but I think it would be good to correctly sanity check this for this corner case. 22