1 | /* $Id: SnapshotImpl.cpp 28835 2010-04-27 14:46:23Z vboxsync $ */
|
---|
2 |
|
---|
3 | /** @file
|
---|
4 | *
|
---|
5 | * COM class implementation for Snapshot and SnapshotMachine in VBoxSVC.
|
---|
6 | */
|
---|
7 |
|
---|
8 | /*
|
---|
9 | * Copyright (C) 2006-2010 Oracle Corporation
|
---|
10 | *
|
---|
11 | * This file is part of VirtualBox Open Source Edition (OSE), as
|
---|
12 | * available from http://www.virtualbox.org. This file is free software;
|
---|
13 | * you can redistribute it and/or modify it under the terms of the GNU
|
---|
14 | * General Public License (GPL) as published by the Free Software
|
---|
15 | * Foundation, in version 2 as it comes in the "COPYING" file of the
|
---|
16 | * VirtualBox OSE distribution. VirtualBox OSE is distributed in the
|
---|
17 | * hope that it will be useful, but WITHOUT ANY WARRANTY of any kind.
|
---|
18 | */
|
---|
19 |
|
---|
20 | #include "Logging.h"
|
---|
21 | #include "SnapshotImpl.h"
|
---|
22 |
|
---|
23 | #include "MachineImpl.h"
|
---|
24 | #include "MediumImpl.h"
|
---|
25 | #include "Global.h"
|
---|
26 | #include "ProgressImpl.h"
|
---|
27 |
|
---|
28 | // @todo these three includes are required for about one or two lines, try
|
---|
29 | // to remove them and put that code in shared code in MachineImplcpp
|
---|
30 | #include "SharedFolderImpl.h"
|
---|
31 | #include "USBControllerImpl.h"
|
---|
32 | #include "VirtualBoxImpl.h"
|
---|
33 |
|
---|
34 | #include "AutoCaller.h"
|
---|
35 |
|
---|
36 | #include <iprt/path.h>
|
---|
37 | #include <VBox/param.h>
|
---|
38 | #include <VBox/err.h>
|
---|
39 |
|
---|
40 | #include <VBox/settings.h>
|
---|
41 |
|
---|
42 | ////////////////////////////////////////////////////////////////////////////////
|
---|
43 | //
|
---|
44 | // Globals
|
---|
45 | //
|
---|
46 | ////////////////////////////////////////////////////////////////////////////////
|
---|
47 |
|
---|
48 | /**
|
---|
49 | * Progress callback handler for lengthy operations
|
---|
50 | * (corresponds to the FNRTPROGRESS typedef).
|
---|
51 | *
|
---|
52 | * @param uPercentage Completetion precentage (0-100).
|
---|
53 | * @param pvUser Pointer to the Progress instance.
|
---|
54 | */
|
---|
55 | static DECLCALLBACK(int) progressCallback(unsigned uPercentage, void *pvUser)
|
---|
56 | {
|
---|
57 | IProgress *progress = static_cast<IProgress*>(pvUser);
|
---|
58 |
|
---|
59 | /* update the progress object */
|
---|
60 | if (progress)
|
---|
61 | progress->SetCurrentOperationProgress(uPercentage);
|
---|
62 |
|
---|
63 | return VINF_SUCCESS;
|
---|
64 | }
|
---|
65 |
|
---|
66 | ////////////////////////////////////////////////////////////////////////////////
|
---|
67 | //
|
---|
68 | // Snapshot private data definition
|
---|
69 | //
|
---|
70 | ////////////////////////////////////////////////////////////////////////////////
|
---|
71 |
|
---|
72 | typedef std::list< ComObjPtr<Snapshot> > SnapshotsList;
|
---|
73 |
|
---|
74 | struct Snapshot::Data
|
---|
75 | {
|
---|
76 | Data()
|
---|
77 | : pVirtualBox(NULL)
|
---|
78 | {
|
---|
79 | RTTimeSpecSetMilli(&timeStamp, 0);
|
---|
80 | };
|
---|
81 |
|
---|
82 | ~Data()
|
---|
83 | {}
|
---|
84 |
|
---|
85 | const Guid uuid;
|
---|
86 | Utf8Str strName;
|
---|
87 | Utf8Str strDescription;
|
---|
88 | RTTIMESPEC timeStamp;
|
---|
89 | ComObjPtr<SnapshotMachine> pMachine;
|
---|
90 |
|
---|
91 | /** weak VirtualBox parent */
|
---|
92 | VirtualBox * const pVirtualBox;
|
---|
93 |
|
---|
94 | // pParent and llChildren are protected by the machine lock
|
---|
95 | ComObjPtr<Snapshot> pParent;
|
---|
96 | SnapshotsList llChildren;
|
---|
97 | };
|
---|
98 |
|
---|
99 | ////////////////////////////////////////////////////////////////////////////////
|
---|
100 | //
|
---|
101 | // Constructor / destructor
|
---|
102 | //
|
---|
103 | ////////////////////////////////////////////////////////////////////////////////
|
---|
104 |
|
---|
105 | HRESULT Snapshot::FinalConstruct()
|
---|
106 | {
|
---|
107 | LogFlowThisFunc(("\n"));
|
---|
108 | return S_OK;
|
---|
109 | }
|
---|
110 |
|
---|
111 | void Snapshot::FinalRelease()
|
---|
112 | {
|
---|
113 | LogFlowThisFunc(("\n"));
|
---|
114 | uninit();
|
---|
115 | }
|
---|
116 |
|
---|
117 | /**
|
---|
118 | * Initializes the instance
|
---|
119 | *
|
---|
120 | * @param aId id of the snapshot
|
---|
121 | * @param aName name of the snapshot
|
---|
122 | * @param aDescription name of the snapshot (NULL if no description)
|
---|
123 | * @param aTimeStamp timestamp of the snapshot, in ms since 1970-01-01 UTC
|
---|
124 | * @param aMachine machine associated with this snapshot
|
---|
125 | * @param aParent parent snapshot (NULL if no parent)
|
---|
126 | */
|
---|
127 | HRESULT Snapshot::init(VirtualBox *aVirtualBox,
|
---|
128 | const Guid &aId,
|
---|
129 | const Utf8Str &aName,
|
---|
130 | const Utf8Str &aDescription,
|
---|
131 | const RTTIMESPEC &aTimeStamp,
|
---|
132 | SnapshotMachine *aMachine,
|
---|
133 | Snapshot *aParent)
|
---|
134 | {
|
---|
135 | LogFlowThisFunc(("uuid=%s aParent->uuid=%s\n", aId.toString().c_str(), (aParent) ? aParent->m->uuid.toString().c_str() : ""));
|
---|
136 |
|
---|
137 | ComAssertRet(!aId.isEmpty() && !aName.isEmpty() && aMachine, E_INVALIDARG);
|
---|
138 |
|
---|
139 | /* Enclose the state transition NotReady->InInit->Ready */
|
---|
140 | AutoInitSpan autoInitSpan(this);
|
---|
141 | AssertReturn(autoInitSpan.isOk(), E_FAIL);
|
---|
142 |
|
---|
143 | m = new Data;
|
---|
144 |
|
---|
145 | /* share parent weakly */
|
---|
146 | unconst(m->pVirtualBox) = aVirtualBox;
|
---|
147 |
|
---|
148 | m->pParent = aParent;
|
---|
149 |
|
---|
150 | unconst(m->uuid) = aId;
|
---|
151 | m->strName = aName;
|
---|
152 | m->strDescription = aDescription;
|
---|
153 | m->timeStamp = aTimeStamp;
|
---|
154 | m->pMachine = aMachine;
|
---|
155 |
|
---|
156 | if (aParent)
|
---|
157 | aParent->m->llChildren.push_back(this);
|
---|
158 |
|
---|
159 | /* Confirm a successful initialization when it's the case */
|
---|
160 | autoInitSpan.setSucceeded();
|
---|
161 |
|
---|
162 | return S_OK;
|
---|
163 | }
|
---|
164 |
|
---|
165 | /**
|
---|
166 | * Uninitializes the instance and sets the ready flag to FALSE.
|
---|
167 | * Called either from FinalRelease(), by the parent when it gets destroyed,
|
---|
168 | * or by a third party when it decides this object is no more valid.
|
---|
169 | *
|
---|
170 | * Since this manipulates the snapshots tree, the caller must hold the
|
---|
171 | * machine lock in write mode (which protects the snapshots tree)!
|
---|
172 | */
|
---|
173 | void Snapshot::uninit()
|
---|
174 | {
|
---|
175 | LogFlowThisFunc(("\n"));
|
---|
176 |
|
---|
177 | /* Enclose the state transition Ready->InUninit->NotReady */
|
---|
178 | AutoUninitSpan autoUninitSpan(this);
|
---|
179 | if (autoUninitSpan.uninitDone())
|
---|
180 | return;
|
---|
181 |
|
---|
182 | Assert(m->pMachine->isWriteLockOnCurrentThread());
|
---|
183 |
|
---|
184 | // uninit all children
|
---|
185 | SnapshotsList::iterator it;
|
---|
186 | for (it = m->llChildren.begin();
|
---|
187 | it != m->llChildren.end();
|
---|
188 | ++it)
|
---|
189 | {
|
---|
190 | Snapshot *pChild = *it;
|
---|
191 | pChild->m->pParent.setNull();
|
---|
192 | pChild->uninit();
|
---|
193 | }
|
---|
194 | m->llChildren.clear(); // this unsets all the ComPtrs and probably calls delete
|
---|
195 |
|
---|
196 | if (m->pParent)
|
---|
197 | deparent();
|
---|
198 |
|
---|
199 | if (m->pMachine)
|
---|
200 | {
|
---|
201 | m->pMachine->uninit();
|
---|
202 | m->pMachine.setNull();
|
---|
203 | }
|
---|
204 |
|
---|
205 | delete m;
|
---|
206 | m = NULL;
|
---|
207 | }
|
---|
208 |
|
---|
209 | /**
|
---|
210 | * Delete the current snapshot by removing it from the tree of snapshots
|
---|
211 | * and reparenting its children.
|
---|
212 | *
|
---|
213 | * After this, the caller must call uninit() on the snapshot. We can't call
|
---|
214 | * that from here because if we do, the AutoUninitSpan waits forever for
|
---|
215 | * the number of callers to become 0 (it is 1 because of the AutoCaller in here).
|
---|
216 | *
|
---|
217 | * NOTE: this does NOT lock the snapshot, it is assumed that the machine state
|
---|
218 | * (and the snapshots tree) is protected by the caller having requested the machine
|
---|
219 | * lock in write mode AND the machine state must be DeletingSnapshot.
|
---|
220 | */
|
---|
221 | void Snapshot::beginSnapshotDelete()
|
---|
222 | {
|
---|
223 | AutoCaller autoCaller(this);
|
---|
224 | if (FAILED(autoCaller.rc()))
|
---|
225 | return;
|
---|
226 |
|
---|
227 | // caller must have acquired the machine's write lock
|
---|
228 | Assert( m->pMachine->mData->mMachineState == MachineState_DeletingSnapshot
|
---|
229 | || m->pMachine->mData->mMachineState == MachineState_DeletingSnapshotOnline
|
---|
230 | || m->pMachine->mData->mMachineState == MachineState_DeletingSnapshotPaused);
|
---|
231 | Assert(m->pMachine->isWriteLockOnCurrentThread());
|
---|
232 |
|
---|
233 | // the snapshot must have only one child when being deleted or no children at all
|
---|
234 | AssertReturnVoid(m->llChildren.size() <= 1);
|
---|
235 |
|
---|
236 | ComObjPtr<Snapshot> parentSnapshot = m->pParent;
|
---|
237 |
|
---|
238 | /// @todo (dmik):
|
---|
239 | // when we introduce clones later, deleting the snapshot will affect
|
---|
240 | // the current and first snapshots of clones, if they are direct children
|
---|
241 | // of this snapshot. So we will need to lock machines associated with
|
---|
242 | // child snapshots as well and update mCurrentSnapshot and/or
|
---|
243 | // mFirstSnapshot fields.
|
---|
244 |
|
---|
245 | if (this == m->pMachine->mData->mCurrentSnapshot)
|
---|
246 | {
|
---|
247 | m->pMachine->mData->mCurrentSnapshot = parentSnapshot;
|
---|
248 |
|
---|
249 | /* we've changed the base of the current state so mark it as
|
---|
250 | * modified as it no longer guaranteed to be its copy */
|
---|
251 | m->pMachine->mData->mCurrentStateModified = TRUE;
|
---|
252 | }
|
---|
253 |
|
---|
254 | if (this == m->pMachine->mData->mFirstSnapshot)
|
---|
255 | {
|
---|
256 | if (m->llChildren.size() == 1)
|
---|
257 | {
|
---|
258 | ComObjPtr<Snapshot> childSnapshot = m->llChildren.front();
|
---|
259 | m->pMachine->mData->mFirstSnapshot = childSnapshot;
|
---|
260 | }
|
---|
261 | else
|
---|
262 | m->pMachine->mData->mFirstSnapshot.setNull();
|
---|
263 | }
|
---|
264 |
|
---|
265 | // reparent our children
|
---|
266 | for (SnapshotsList::const_iterator it = m->llChildren.begin();
|
---|
267 | it != m->llChildren.end();
|
---|
268 | ++it)
|
---|
269 | {
|
---|
270 | ComObjPtr<Snapshot> child = *it;
|
---|
271 | // no need to lock, snapshots tree is protected by machine lock
|
---|
272 | child->m->pParent = m->pParent;
|
---|
273 | if (m->pParent)
|
---|
274 | m->pParent->m->llChildren.push_back(child);
|
---|
275 | }
|
---|
276 |
|
---|
277 | // clear our own children list (since we reparented the children)
|
---|
278 | m->llChildren.clear();
|
---|
279 | }
|
---|
280 |
|
---|
281 | /**
|
---|
282 | * Internal helper that removes "this" from the list of children of its
|
---|
283 | * parent. Used in uninit() and other places when reparenting is necessary.
|
---|
284 | *
|
---|
285 | * The caller must hold the machine lock in write mode (which protects the snapshots tree)!
|
---|
286 | */
|
---|
287 | void Snapshot::deparent()
|
---|
288 | {
|
---|
289 | Assert(m->pMachine->isWriteLockOnCurrentThread());
|
---|
290 |
|
---|
291 | SnapshotsList &llParent = m->pParent->m->llChildren;
|
---|
292 | for (SnapshotsList::iterator it = llParent.begin();
|
---|
293 | it != llParent.end();
|
---|
294 | ++it)
|
---|
295 | {
|
---|
296 | Snapshot *pParentsChild = *it;
|
---|
297 | if (this == pParentsChild)
|
---|
298 | {
|
---|
299 | llParent.erase(it);
|
---|
300 | break;
|
---|
301 | }
|
---|
302 | }
|
---|
303 |
|
---|
304 | m->pParent.setNull();
|
---|
305 | }
|
---|
306 |
|
---|
307 | ////////////////////////////////////////////////////////////////////////////////
|
---|
308 | //
|
---|
309 | // ISnapshot public methods
|
---|
310 | //
|
---|
311 | ////////////////////////////////////////////////////////////////////////////////
|
---|
312 |
|
---|
313 | STDMETHODIMP Snapshot::COMGETTER(Id)(BSTR *aId)
|
---|
314 | {
|
---|
315 | CheckComArgOutPointerValid(aId);
|
---|
316 |
|
---|
317 | AutoCaller autoCaller(this);
|
---|
318 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
319 |
|
---|
320 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
321 |
|
---|
322 | m->uuid.toUtf16().cloneTo(aId);
|
---|
323 | return S_OK;
|
---|
324 | }
|
---|
325 |
|
---|
326 | STDMETHODIMP Snapshot::COMGETTER(Name)(BSTR *aName)
|
---|
327 | {
|
---|
328 | CheckComArgOutPointerValid(aName);
|
---|
329 |
|
---|
330 | AutoCaller autoCaller(this);
|
---|
331 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
332 |
|
---|
333 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
334 |
|
---|
335 | m->strName.cloneTo(aName);
|
---|
336 | return S_OK;
|
---|
337 | }
|
---|
338 |
|
---|
339 | /**
|
---|
340 | * @note Locks this object for writing, then calls Machine::onSnapshotChange()
|
---|
341 | * (see its lock requirements).
|
---|
342 | */
|
---|
343 | STDMETHODIMP Snapshot::COMSETTER(Name)(IN_BSTR aName)
|
---|
344 | {
|
---|
345 | CheckComArgStrNotEmptyOrNull(aName);
|
---|
346 |
|
---|
347 | AutoCaller autoCaller(this);
|
---|
348 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
349 |
|
---|
350 | Utf8Str strName(aName);
|
---|
351 |
|
---|
352 | AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
353 |
|
---|
354 | if (m->strName != strName)
|
---|
355 | {
|
---|
356 | m->strName = strName;
|
---|
357 |
|
---|
358 | alock.leave(); /* Important! (child->parent locks are forbidden) */
|
---|
359 |
|
---|
360 | // flag the machine as dirty or change won't get saved
|
---|
361 | AutoWriteLock mlock(m->pMachine COMMA_LOCKVAL_SRC_POS);
|
---|
362 | m->pMachine->setModified(Machine::IsModified_Snapshots);
|
---|
363 | mlock.leave();
|
---|
364 |
|
---|
365 | return m->pMachine->onSnapshotChange(this);
|
---|
366 | }
|
---|
367 |
|
---|
368 | return S_OK;
|
---|
369 | }
|
---|
370 |
|
---|
371 | STDMETHODIMP Snapshot::COMGETTER(Description)(BSTR *aDescription)
|
---|
372 | {
|
---|
373 | CheckComArgOutPointerValid(aDescription);
|
---|
374 |
|
---|
375 | AutoCaller autoCaller(this);
|
---|
376 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
377 |
|
---|
378 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
379 |
|
---|
380 | m->strDescription.cloneTo(aDescription);
|
---|
381 | return S_OK;
|
---|
382 | }
|
---|
383 |
|
---|
384 | STDMETHODIMP Snapshot::COMSETTER(Description)(IN_BSTR aDescription)
|
---|
385 | {
|
---|
386 | AutoCaller autoCaller(this);
|
---|
387 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
388 |
|
---|
389 | Utf8Str strDescription(aDescription);
|
---|
390 |
|
---|
391 | AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
392 |
|
---|
393 | if (m->strDescription != strDescription)
|
---|
394 | {
|
---|
395 | m->strDescription = strDescription;
|
---|
396 |
|
---|
397 | alock.leave(); /* Important! (child->parent locks are forbidden) */
|
---|
398 |
|
---|
399 | // flag the machine as dirty or change won't get saved
|
---|
400 | AutoWriteLock mlock(m->pMachine COMMA_LOCKVAL_SRC_POS);
|
---|
401 | m->pMachine->setModified(Machine::IsModified_Snapshots);
|
---|
402 | mlock.leave();
|
---|
403 |
|
---|
404 | return m->pMachine->onSnapshotChange(this);
|
---|
405 | }
|
---|
406 |
|
---|
407 | return S_OK;
|
---|
408 | }
|
---|
409 |
|
---|
410 | STDMETHODIMP Snapshot::COMGETTER(TimeStamp)(LONG64 *aTimeStamp)
|
---|
411 | {
|
---|
412 | CheckComArgOutPointerValid(aTimeStamp);
|
---|
413 |
|
---|
414 | AutoCaller autoCaller(this);
|
---|
415 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
416 |
|
---|
417 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
418 |
|
---|
419 | *aTimeStamp = RTTimeSpecGetMilli(&m->timeStamp);
|
---|
420 | return S_OK;
|
---|
421 | }
|
---|
422 |
|
---|
423 | STDMETHODIMP Snapshot::COMGETTER(Online)(BOOL *aOnline)
|
---|
424 | {
|
---|
425 | CheckComArgOutPointerValid(aOnline);
|
---|
426 |
|
---|
427 | AutoCaller autoCaller(this);
|
---|
428 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
429 |
|
---|
430 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
431 |
|
---|
432 | *aOnline = !stateFilePath().isEmpty();
|
---|
433 | return S_OK;
|
---|
434 | }
|
---|
435 |
|
---|
436 | STDMETHODIMP Snapshot::COMGETTER(Machine)(IMachine **aMachine)
|
---|
437 | {
|
---|
438 | CheckComArgOutPointerValid(aMachine);
|
---|
439 |
|
---|
440 | AutoCaller autoCaller(this);
|
---|
441 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
442 |
|
---|
443 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
444 |
|
---|
445 | m->pMachine.queryInterfaceTo(aMachine);
|
---|
446 | return S_OK;
|
---|
447 | }
|
---|
448 |
|
---|
449 | STDMETHODIMP Snapshot::COMGETTER(Parent)(ISnapshot **aParent)
|
---|
450 | {
|
---|
451 | CheckComArgOutPointerValid(aParent);
|
---|
452 |
|
---|
453 | AutoCaller autoCaller(this);
|
---|
454 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
455 |
|
---|
456 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
457 |
|
---|
458 | m->pParent.queryInterfaceTo(aParent);
|
---|
459 | return S_OK;
|
---|
460 | }
|
---|
461 |
|
---|
462 | STDMETHODIMP Snapshot::COMGETTER(Children)(ComSafeArrayOut(ISnapshot *, aChildren))
|
---|
463 | {
|
---|
464 | CheckComArgOutSafeArrayPointerValid(aChildren);
|
---|
465 |
|
---|
466 | AutoCaller autoCaller(this);
|
---|
467 | if (FAILED(autoCaller.rc())) return autoCaller.rc();
|
---|
468 |
|
---|
469 | // snapshots tree is protected by machine lock
|
---|
470 | AutoReadLock alock(m->pMachine COMMA_LOCKVAL_SRC_POS);
|
---|
471 |
|
---|
472 | SafeIfaceArray<ISnapshot> collection(m->llChildren);
|
---|
473 | collection.detachTo(ComSafeArrayOutArg(aChildren));
|
---|
474 |
|
---|
475 | return S_OK;
|
---|
476 | }
|
---|
477 |
|
---|
478 | ////////////////////////////////////////////////////////////////////////////////
|
---|
479 | //
|
---|
480 | // Snapshot public internal methods
|
---|
481 | //
|
---|
482 | ////////////////////////////////////////////////////////////////////////////////
|
---|
483 |
|
---|
484 | /**
|
---|
485 | * Returns the parent snapshot or NULL if there's none. Must have caller + locking!
|
---|
486 | * @return
|
---|
487 | */
|
---|
488 | const ComObjPtr<Snapshot>& Snapshot::getParent() const
|
---|
489 | {
|
---|
490 | return m->pParent;
|
---|
491 | }
|
---|
492 |
|
---|
493 | /**
|
---|
494 | * Returns the first child snapshot or NULL if there's none. Must have caller + locking!
|
---|
495 | * @return
|
---|
496 | */
|
---|
497 | const ComObjPtr<Snapshot> Snapshot::getFirstChild() const
|
---|
498 | {
|
---|
499 | if (!m->llChildren.size())
|
---|
500 | return NULL;
|
---|
501 | return m->llChildren.front();
|
---|
502 | }
|
---|
503 |
|
---|
504 | /**
|
---|
505 | * @note
|
---|
506 | * Must be called from under the object's lock!
|
---|
507 | */
|
---|
508 | const Utf8Str& Snapshot::stateFilePath() const
|
---|
509 | {
|
---|
510 | return m->pMachine->mSSData->mStateFilePath;
|
---|
511 | }
|
---|
512 |
|
---|
513 | /**
|
---|
514 | * @note
|
---|
515 | * Must be called from under the object's write lock!
|
---|
516 | */
|
---|
517 | HRESULT Snapshot::deleteStateFile()
|
---|
518 | {
|
---|
519 | int vrc = RTFileDelete(m->pMachine->mSSData->mStateFilePath.raw());
|
---|
520 | if (RT_SUCCESS(vrc))
|
---|
521 | m->pMachine->mSSData->mStateFilePath.setNull();
|
---|
522 | return RT_SUCCESS(vrc) ? S_OK : E_FAIL;
|
---|
523 | }
|
---|
524 |
|
---|
525 | /**
|
---|
526 | * Returns the number of direct child snapshots, without grandchildren.
|
---|
527 | * Does not recurse.
|
---|
528 | * @return
|
---|
529 | */
|
---|
530 | ULONG Snapshot::getChildrenCount()
|
---|
531 | {
|
---|
532 | AutoCaller autoCaller(this);
|
---|
533 | AssertComRC(autoCaller.rc());
|
---|
534 |
|
---|
535 | // snapshots tree is protected by machine lock
|
---|
536 | AutoReadLock alock(m->pMachine COMMA_LOCKVAL_SRC_POS);
|
---|
537 |
|
---|
538 | return (ULONG)m->llChildren.size();
|
---|
539 | }
|
---|
540 |
|
---|
541 | /**
|
---|
542 | * Implementation method for getAllChildrenCount() so we request the
|
---|
543 | * tree lock only once before recursing. Don't call directly.
|
---|
544 | * @return
|
---|
545 | */
|
---|
546 | ULONG Snapshot::getAllChildrenCountImpl()
|
---|
547 | {
|
---|
548 | AutoCaller autoCaller(this);
|
---|
549 | AssertComRC(autoCaller.rc());
|
---|
550 |
|
---|
551 | ULONG count = (ULONG)m->llChildren.size();
|
---|
552 | for (SnapshotsList::const_iterator it = m->llChildren.begin();
|
---|
553 | it != m->llChildren.end();
|
---|
554 | ++it)
|
---|
555 | {
|
---|
556 | count += (*it)->getAllChildrenCountImpl();
|
---|
557 | }
|
---|
558 |
|
---|
559 | return count;
|
---|
560 | }
|
---|
561 |
|
---|
562 | /**
|
---|
563 | * Returns the number of child snapshots including all grandchildren.
|
---|
564 | * Recurses into the snapshots tree.
|
---|
565 | * @return
|
---|
566 | */
|
---|
567 | ULONG Snapshot::getAllChildrenCount()
|
---|
568 | {
|
---|
569 | AutoCaller autoCaller(this);
|
---|
570 | AssertComRC(autoCaller.rc());
|
---|
571 |
|
---|
572 | // snapshots tree is protected by machine lock
|
---|
573 | AutoReadLock alock(m->pMachine COMMA_LOCKVAL_SRC_POS);
|
---|
574 |
|
---|
575 | return getAllChildrenCountImpl();
|
---|
576 | }
|
---|
577 |
|
---|
578 | /**
|
---|
579 | * Returns the SnapshotMachine that this snapshot belongs to.
|
---|
580 | * Caller must hold the snapshot's object lock!
|
---|
581 | * @return
|
---|
582 | */
|
---|
583 | const ComObjPtr<SnapshotMachine>& Snapshot::getSnapshotMachine() const
|
---|
584 | {
|
---|
585 | return m->pMachine;
|
---|
586 | }
|
---|
587 |
|
---|
588 | /**
|
---|
589 | * Returns the UUID of this snapshot.
|
---|
590 | * Caller must hold the snapshot's object lock!
|
---|
591 | * @return
|
---|
592 | */
|
---|
593 | Guid Snapshot::getId() const
|
---|
594 | {
|
---|
595 | return m->uuid;
|
---|
596 | }
|
---|
597 |
|
---|
598 | /**
|
---|
599 | * Returns the name of this snapshot.
|
---|
600 | * Caller must hold the snapshot's object lock!
|
---|
601 | * @return
|
---|
602 | */
|
---|
603 | const Utf8Str& Snapshot::getName() const
|
---|
604 | {
|
---|
605 | return m->strName;
|
---|
606 | }
|
---|
607 |
|
---|
608 | /**
|
---|
609 | * Returns the time stamp of this snapshot.
|
---|
610 | * Caller must hold the snapshot's object lock!
|
---|
611 | * @return
|
---|
612 | */
|
---|
613 | RTTIMESPEC Snapshot::getTimeStamp() const
|
---|
614 | {
|
---|
615 | return m->timeStamp;
|
---|
616 | }
|
---|
617 |
|
---|
618 | /**
|
---|
619 | * Searches for a snapshot with the given ID among children, grand-children,
|
---|
620 | * etc. of this snapshot. This snapshot itself is also included in the search.
|
---|
621 | *
|
---|
622 | * Caller must hold the machine lock (which protects the snapshots tree!)
|
---|
623 | */
|
---|
624 | ComObjPtr<Snapshot> Snapshot::findChildOrSelf(IN_GUID aId)
|
---|
625 | {
|
---|
626 | ComObjPtr<Snapshot> child;
|
---|
627 |
|
---|
628 | AutoCaller autoCaller(this);
|
---|
629 | AssertComRC(autoCaller.rc());
|
---|
630 |
|
---|
631 | // no need to lock, uuid is const
|
---|
632 | if (m->uuid == aId)
|
---|
633 | child = this;
|
---|
634 | else
|
---|
635 | {
|
---|
636 | for (SnapshotsList::const_iterator it = m->llChildren.begin();
|
---|
637 | it != m->llChildren.end();
|
---|
638 | ++it)
|
---|
639 | {
|
---|
640 | if ((child = (*it)->findChildOrSelf(aId)))
|
---|
641 | break;
|
---|
642 | }
|
---|
643 | }
|
---|
644 |
|
---|
645 | return child;
|
---|
646 | }
|
---|
647 |
|
---|
648 | /**
|
---|
649 | * Searches for a first snapshot with the given name among children,
|
---|
650 | * grand-children, etc. of this snapshot. This snapshot itself is also included
|
---|
651 | * in the search.
|
---|
652 | *
|
---|
653 | * Caller must hold the machine lock (which protects the snapshots tree!)
|
---|
654 | */
|
---|
655 | ComObjPtr<Snapshot> Snapshot::findChildOrSelf(const Utf8Str &aName)
|
---|
656 | {
|
---|
657 | ComObjPtr<Snapshot> child;
|
---|
658 | AssertReturn(!aName.isEmpty(), child);
|
---|
659 |
|
---|
660 | AutoCaller autoCaller(this);
|
---|
661 | AssertComRC(autoCaller.rc());
|
---|
662 |
|
---|
663 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
664 |
|
---|
665 | if (m->strName == aName)
|
---|
666 | child = this;
|
---|
667 | else
|
---|
668 | {
|
---|
669 | alock.release();
|
---|
670 | for (SnapshotsList::const_iterator it = m->llChildren.begin();
|
---|
671 | it != m->llChildren.end();
|
---|
672 | ++it)
|
---|
673 | {
|
---|
674 | if ((child = (*it)->findChildOrSelf(aName)))
|
---|
675 | break;
|
---|
676 | }
|
---|
677 | }
|
---|
678 |
|
---|
679 | return child;
|
---|
680 | }
|
---|
681 |
|
---|
682 | /**
|
---|
683 | * Internal implementation for Snapshot::updateSavedStatePaths (below).
|
---|
684 | * @param aOldPath
|
---|
685 | * @param aNewPath
|
---|
686 | */
|
---|
687 | void Snapshot::updateSavedStatePathsImpl(const char *aOldPath, const char *aNewPath)
|
---|
688 | {
|
---|
689 | AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
690 |
|
---|
691 | const Utf8Str &path = m->pMachine->mSSData->mStateFilePath;
|
---|
692 | LogFlowThisFunc(("Snap[%s].statePath={%s}\n", m->strName.c_str(), path.c_str()));
|
---|
693 |
|
---|
694 | /* state file may be NULL (for offline snapshots) */
|
---|
695 | if ( path.length()
|
---|
696 | && RTPathStartsWith(path.c_str(), aOldPath)
|
---|
697 | )
|
---|
698 | {
|
---|
699 | m->pMachine->mSSData->mStateFilePath = Utf8StrFmt("%s%s", aNewPath, path.raw() + strlen(aOldPath));
|
---|
700 |
|
---|
701 | LogFlowThisFunc(("-> updated: {%s}\n", path.raw()));
|
---|
702 | }
|
---|
703 |
|
---|
704 | for (SnapshotsList::const_iterator it = m->llChildren.begin();
|
---|
705 | it != m->llChildren.end();
|
---|
706 | ++it)
|
---|
707 | {
|
---|
708 | Snapshot *pChild = *it;
|
---|
709 | pChild->updateSavedStatePathsImpl(aOldPath, aNewPath);
|
---|
710 | }
|
---|
711 | }
|
---|
712 |
|
---|
713 | /**
|
---|
714 | * Checks if the specified path change affects the saved state file path of
|
---|
715 | * this snapshot or any of its (grand-)children and updates it accordingly.
|
---|
716 | *
|
---|
717 | * Intended to be called by Machine::openConfigLoader() only.
|
---|
718 | *
|
---|
719 | * @param aOldPath old path (full)
|
---|
720 | * @param aNewPath new path (full)
|
---|
721 | *
|
---|
722 | * @note Locks the machine (for the snapshots tree) + this object + children for writing.
|
---|
723 | */
|
---|
724 | void Snapshot::updateSavedStatePaths(const char *aOldPath, const char *aNewPath)
|
---|
725 | {
|
---|
726 | LogFlowThisFunc(("aOldPath={%s} aNewPath={%s}\n", aOldPath, aNewPath));
|
---|
727 |
|
---|
728 | AssertReturnVoid(aOldPath);
|
---|
729 | AssertReturnVoid(aNewPath);
|
---|
730 |
|
---|
731 | AutoCaller autoCaller(this);
|
---|
732 | AssertComRC(autoCaller.rc());
|
---|
733 |
|
---|
734 | // snapshots tree is protected by machine lock
|
---|
735 | AutoWriteLock alock(m->pMachine COMMA_LOCKVAL_SRC_POS);
|
---|
736 |
|
---|
737 | // call the implementation under the tree lock
|
---|
738 | updateSavedStatePathsImpl(aOldPath, aNewPath);
|
---|
739 | }
|
---|
740 |
|
---|
741 | /**
|
---|
742 | * Internal implementation for Snapshot::saveSnapshot (below). Caller has
|
---|
743 | * requested the snapshots tree (machine) lock.
|
---|
744 | *
|
---|
745 | * @param aNode
|
---|
746 | * @param aAttrsOnly
|
---|
747 | * @return
|
---|
748 | */
|
---|
749 | HRESULT Snapshot::saveSnapshotImpl(settings::Snapshot &data, bool aAttrsOnly)
|
---|
750 | {
|
---|
751 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
752 |
|
---|
753 | data.uuid = m->uuid;
|
---|
754 | data.strName = m->strName;
|
---|
755 | data.timestamp = m->timeStamp;
|
---|
756 | data.strDescription = m->strDescription;
|
---|
757 |
|
---|
758 | if (aAttrsOnly)
|
---|
759 | return S_OK;
|
---|
760 |
|
---|
761 | /* stateFile (optional) */
|
---|
762 | if (!stateFilePath().isEmpty())
|
---|
763 | /* try to make the file name relative to the settings file dir */
|
---|
764 | m->pMachine->calculateRelativePath(stateFilePath(), data.strStateFile);
|
---|
765 | else
|
---|
766 | data.strStateFile.setNull();
|
---|
767 |
|
---|
768 | HRESULT rc = m->pMachine->saveHardware(data.hardware);
|
---|
769 | if (FAILED(rc)) return rc;
|
---|
770 |
|
---|
771 | rc = m->pMachine->saveStorageControllers(data.storage);
|
---|
772 | if (FAILED(rc)) return rc;
|
---|
773 |
|
---|
774 | alock.release();
|
---|
775 |
|
---|
776 | data.llChildSnapshots.clear();
|
---|
777 |
|
---|
778 | if (m->llChildren.size())
|
---|
779 | {
|
---|
780 | for (SnapshotsList::const_iterator it = m->llChildren.begin();
|
---|
781 | it != m->llChildren.end();
|
---|
782 | ++it)
|
---|
783 | {
|
---|
784 | settings::Snapshot snap;
|
---|
785 | rc = (*it)->saveSnapshotImpl(snap, aAttrsOnly);
|
---|
786 | if (FAILED(rc)) return rc;
|
---|
787 |
|
---|
788 | data.llChildSnapshots.push_back(snap);
|
---|
789 | }
|
---|
790 | }
|
---|
791 |
|
---|
792 | return S_OK;
|
---|
793 | }
|
---|
794 |
|
---|
795 | /**
|
---|
796 | * Saves the given snapshot and all its children (unless \a aAttrsOnly is true).
|
---|
797 | * It is assumed that the given node is empty (unless \a aAttrsOnly is true).
|
---|
798 | *
|
---|
799 | * @param aNode <Snapshot> node to save the snapshot to.
|
---|
800 | * @param aSnapshot Snapshot to save.
|
---|
801 | * @param aAttrsOnly If true, only updatge user-changeable attrs.
|
---|
802 | */
|
---|
803 | HRESULT Snapshot::saveSnapshot(settings::Snapshot &data, bool aAttrsOnly)
|
---|
804 | {
|
---|
805 | // snapshots tree is protected by machine lock
|
---|
806 | AutoReadLock alock(m->pMachine COMMA_LOCKVAL_SRC_POS);
|
---|
807 |
|
---|
808 | return saveSnapshotImpl(data, aAttrsOnly);
|
---|
809 | }
|
---|
810 |
|
---|
811 | ////////////////////////////////////////////////////////////////////////////////
|
---|
812 | //
|
---|
813 | // SnapshotMachine implementation
|
---|
814 | //
|
---|
815 | ////////////////////////////////////////////////////////////////////////////////
|
---|
816 |
|
---|
817 | DEFINE_EMPTY_CTOR_DTOR(SnapshotMachine)
|
---|
818 |
|
---|
819 | HRESULT SnapshotMachine::FinalConstruct()
|
---|
820 | {
|
---|
821 | LogFlowThisFunc(("\n"));
|
---|
822 |
|
---|
823 | return S_OK;
|
---|
824 | }
|
---|
825 |
|
---|
826 | void SnapshotMachine::FinalRelease()
|
---|
827 | {
|
---|
828 | LogFlowThisFunc(("\n"));
|
---|
829 |
|
---|
830 | uninit();
|
---|
831 | }
|
---|
832 |
|
---|
833 | /**
|
---|
834 | * Initializes the SnapshotMachine object when taking a snapshot.
|
---|
835 | *
|
---|
836 | * @param aSessionMachine machine to take a snapshot from
|
---|
837 | * @param aSnapshotId snapshot ID of this snapshot machine
|
---|
838 | * @param aStateFilePath file where the execution state will be later saved
|
---|
839 | * (or NULL for the offline snapshot)
|
---|
840 | *
|
---|
841 | * @note The aSessionMachine must be locked for writing.
|
---|
842 | */
|
---|
843 | HRESULT SnapshotMachine::init(SessionMachine *aSessionMachine,
|
---|
844 | IN_GUID aSnapshotId,
|
---|
845 | const Utf8Str &aStateFilePath)
|
---|
846 | {
|
---|
847 | LogFlowThisFuncEnter();
|
---|
848 | LogFlowThisFunc(("mName={%ls}\n", aSessionMachine->mUserData->mName.raw()));
|
---|
849 |
|
---|
850 | AssertReturn(aSessionMachine && !Guid(aSnapshotId).isEmpty(), E_INVALIDARG);
|
---|
851 |
|
---|
852 | /* Enclose the state transition NotReady->InInit->Ready */
|
---|
853 | AutoInitSpan autoInitSpan(this);
|
---|
854 | AssertReturn(autoInitSpan.isOk(), E_FAIL);
|
---|
855 |
|
---|
856 | AssertReturn(aSessionMachine->isWriteLockOnCurrentThread(), E_FAIL);
|
---|
857 |
|
---|
858 | mSnapshotId = aSnapshotId;
|
---|
859 |
|
---|
860 | /* memorize the primary Machine instance (i.e. not SessionMachine!) */
|
---|
861 | unconst(mPeer) = aSessionMachine->mPeer;
|
---|
862 | /* share the parent pointer */
|
---|
863 | unconst(mParent) = mPeer->mParent;
|
---|
864 |
|
---|
865 | /* take the pointer to Data to share */
|
---|
866 | mData.share(mPeer->mData);
|
---|
867 |
|
---|
868 | /* take the pointer to UserData to share (our UserData must always be the
|
---|
869 | * same as Machine's data) */
|
---|
870 | mUserData.share(mPeer->mUserData);
|
---|
871 | /* make a private copy of all other data (recent changes from SessionMachine) */
|
---|
872 | mHWData.attachCopy(aSessionMachine->mHWData);
|
---|
873 | mMediaData.attachCopy(aSessionMachine->mMediaData);
|
---|
874 |
|
---|
875 | /* SSData is always unique for SnapshotMachine */
|
---|
876 | mSSData.allocate();
|
---|
877 | mSSData->mStateFilePath = aStateFilePath;
|
---|
878 |
|
---|
879 | HRESULT rc = S_OK;
|
---|
880 |
|
---|
881 | /* create copies of all shared folders (mHWData after attiching a copy
|
---|
882 | * contains just references to original objects) */
|
---|
883 | for (HWData::SharedFolderList::iterator it = mHWData->mSharedFolders.begin();
|
---|
884 | it != mHWData->mSharedFolders.end();
|
---|
885 | ++it)
|
---|
886 | {
|
---|
887 | ComObjPtr<SharedFolder> folder;
|
---|
888 | folder.createObject();
|
---|
889 | rc = folder->initCopy(this, *it);
|
---|
890 | if (FAILED(rc)) return rc;
|
---|
891 | *it = folder;
|
---|
892 | }
|
---|
893 |
|
---|
894 | /* associate hard disks with the snapshot
|
---|
895 | * (Machine::uninitDataAndChildObjects() will deassociate at destruction) */
|
---|
896 | for (MediaData::AttachmentList::const_iterator it = mMediaData->mAttachments.begin();
|
---|
897 | it != mMediaData->mAttachments.end();
|
---|
898 | ++it)
|
---|
899 | {
|
---|
900 | MediumAttachment *pAtt = *it;
|
---|
901 | Medium *pMedium = pAtt->getMedium();
|
---|
902 | if (pMedium) // can be NULL for non-harddisk
|
---|
903 | {
|
---|
904 | rc = pMedium->attachTo(mData->mUuid, mSnapshotId);
|
---|
905 | AssertComRC(rc);
|
---|
906 | }
|
---|
907 | }
|
---|
908 |
|
---|
909 | /* create copies of all storage controllers (mStorageControllerData
|
---|
910 | * after attaching a copy contains just references to original objects) */
|
---|
911 | mStorageControllers.allocate();
|
---|
912 | for (StorageControllerList::const_iterator
|
---|
913 | it = aSessionMachine->mStorageControllers->begin();
|
---|
914 | it != aSessionMachine->mStorageControllers->end();
|
---|
915 | ++it)
|
---|
916 | {
|
---|
917 | ComObjPtr<StorageController> ctrl;
|
---|
918 | ctrl.createObject();
|
---|
919 | ctrl->initCopy(this, *it);
|
---|
920 | mStorageControllers->push_back(ctrl);
|
---|
921 | }
|
---|
922 |
|
---|
923 | /* create all other child objects that will be immutable private copies */
|
---|
924 |
|
---|
925 | unconst(mBIOSSettings).createObject();
|
---|
926 | mBIOSSettings->initCopy(this, mPeer->mBIOSSettings);
|
---|
927 |
|
---|
928 | #ifdef VBOX_WITH_VRDP
|
---|
929 | unconst(mVRDPServer).createObject();
|
---|
930 | mVRDPServer->initCopy(this, mPeer->mVRDPServer);
|
---|
931 | #endif
|
---|
932 |
|
---|
933 | unconst(mAudioAdapter).createObject();
|
---|
934 | mAudioAdapter->initCopy(this, mPeer->mAudioAdapter);
|
---|
935 |
|
---|
936 | unconst(mUSBController).createObject();
|
---|
937 | mUSBController->initCopy(this, mPeer->mUSBController);
|
---|
938 |
|
---|
939 | for (ULONG slot = 0; slot < RT_ELEMENTS(mNetworkAdapters); slot++)
|
---|
940 | {
|
---|
941 | unconst(mNetworkAdapters[slot]).createObject();
|
---|
942 | mNetworkAdapters[slot]->initCopy(this, mPeer->mNetworkAdapters[slot]);
|
---|
943 | }
|
---|
944 |
|
---|
945 | for (ULONG slot = 0; slot < RT_ELEMENTS(mSerialPorts); slot++)
|
---|
946 | {
|
---|
947 | unconst(mSerialPorts[slot]).createObject();
|
---|
948 | mSerialPorts[slot]->initCopy(this, mPeer->mSerialPorts[slot]);
|
---|
949 | }
|
---|
950 |
|
---|
951 | for (ULONG slot = 0; slot < RT_ELEMENTS(mParallelPorts); slot++)
|
---|
952 | {
|
---|
953 | unconst(mParallelPorts[slot]).createObject();
|
---|
954 | mParallelPorts[slot]->initCopy(this, mPeer->mParallelPorts[slot]);
|
---|
955 | }
|
---|
956 |
|
---|
957 | /* Confirm a successful initialization when it's the case */
|
---|
958 | autoInitSpan.setSucceeded();
|
---|
959 |
|
---|
960 | LogFlowThisFuncLeave();
|
---|
961 | return S_OK;
|
---|
962 | }
|
---|
963 |
|
---|
964 | /**
|
---|
965 | * Initializes the SnapshotMachine object when loading from the settings file.
|
---|
966 | *
|
---|
967 | * @param aMachine machine the snapshot belngs to
|
---|
968 | * @param aHWNode <Hardware> node
|
---|
969 | * @param aHDAsNode <HardDiskAttachments> node
|
---|
970 | * @param aSnapshotId snapshot ID of this snapshot machine
|
---|
971 | * @param aStateFilePath file where the execution state is saved
|
---|
972 | * (or NULL for the offline snapshot)
|
---|
973 | *
|
---|
974 | * @note Doesn't lock anything.
|
---|
975 | */
|
---|
976 | HRESULT SnapshotMachine::init(Machine *aMachine,
|
---|
977 | const settings::Hardware &hardware,
|
---|
978 | const settings::Storage &storage,
|
---|
979 | IN_GUID aSnapshotId,
|
---|
980 | const Utf8Str &aStateFilePath)
|
---|
981 | {
|
---|
982 | LogFlowThisFuncEnter();
|
---|
983 | LogFlowThisFunc(("mName={%ls}\n", aMachine->mUserData->mName.raw()));
|
---|
984 |
|
---|
985 | AssertReturn(aMachine && !Guid(aSnapshotId).isEmpty(), E_INVALIDARG);
|
---|
986 |
|
---|
987 | /* Enclose the state transition NotReady->InInit->Ready */
|
---|
988 | AutoInitSpan autoInitSpan(this);
|
---|
989 | AssertReturn(autoInitSpan.isOk(), E_FAIL);
|
---|
990 |
|
---|
991 | /* Don't need to lock aMachine when VirtualBox is starting up */
|
---|
992 |
|
---|
993 | mSnapshotId = aSnapshotId;
|
---|
994 |
|
---|
995 | /* memorize the primary Machine instance */
|
---|
996 | unconst(mPeer) = aMachine;
|
---|
997 | /* share the parent pointer */
|
---|
998 | unconst(mParent) = mPeer->mParent;
|
---|
999 |
|
---|
1000 | /* take the pointer to Data to share */
|
---|
1001 | mData.share(mPeer->mData);
|
---|
1002 | /*
|
---|
1003 | * take the pointer to UserData to share
|
---|
1004 | * (our UserData must always be the same as Machine's data)
|
---|
1005 | */
|
---|
1006 | mUserData.share(mPeer->mUserData);
|
---|
1007 | /* allocate private copies of all other data (will be loaded from settings) */
|
---|
1008 | mHWData.allocate();
|
---|
1009 | mMediaData.allocate();
|
---|
1010 | mStorageControllers.allocate();
|
---|
1011 |
|
---|
1012 | /* SSData is always unique for SnapshotMachine */
|
---|
1013 | mSSData.allocate();
|
---|
1014 | mSSData->mStateFilePath = aStateFilePath;
|
---|
1015 |
|
---|
1016 | /* create all other child objects that will be immutable private copies */
|
---|
1017 |
|
---|
1018 | unconst(mBIOSSettings).createObject();
|
---|
1019 | mBIOSSettings->init(this);
|
---|
1020 |
|
---|
1021 | #ifdef VBOX_WITH_VRDP
|
---|
1022 | unconst(mVRDPServer).createObject();
|
---|
1023 | mVRDPServer->init(this);
|
---|
1024 | #endif
|
---|
1025 |
|
---|
1026 | unconst(mAudioAdapter).createObject();
|
---|
1027 | mAudioAdapter->init(this);
|
---|
1028 |
|
---|
1029 | unconst(mUSBController).createObject();
|
---|
1030 | mUSBController->init(this);
|
---|
1031 |
|
---|
1032 | for (ULONG slot = 0; slot < RT_ELEMENTS(mNetworkAdapters); slot++)
|
---|
1033 | {
|
---|
1034 | unconst(mNetworkAdapters[slot]).createObject();
|
---|
1035 | mNetworkAdapters[slot]->init(this, slot);
|
---|
1036 | }
|
---|
1037 |
|
---|
1038 | for (ULONG slot = 0; slot < RT_ELEMENTS(mSerialPorts); slot++)
|
---|
1039 | {
|
---|
1040 | unconst(mSerialPorts[slot]).createObject();
|
---|
1041 | mSerialPorts[slot]->init(this, slot);
|
---|
1042 | }
|
---|
1043 |
|
---|
1044 | for (ULONG slot = 0; slot < RT_ELEMENTS(mParallelPorts); slot++)
|
---|
1045 | {
|
---|
1046 | unconst(mParallelPorts[slot]).createObject();
|
---|
1047 | mParallelPorts[slot]->init(this, slot);
|
---|
1048 | }
|
---|
1049 |
|
---|
1050 | /* load hardware and harddisk settings */
|
---|
1051 |
|
---|
1052 | HRESULT rc = loadHardware(hardware);
|
---|
1053 | if (SUCCEEDED(rc))
|
---|
1054 | rc = loadStorageControllers(storage, &mSnapshotId);
|
---|
1055 |
|
---|
1056 | if (SUCCEEDED(rc))
|
---|
1057 | /* commit all changes made during the initialization */
|
---|
1058 | commit(); // @todo r=dj why do we need a commit in init?!? this is very expensive
|
---|
1059 |
|
---|
1060 | /* Confirm a successful initialization when it's the case */
|
---|
1061 | if (SUCCEEDED(rc))
|
---|
1062 | autoInitSpan.setSucceeded();
|
---|
1063 |
|
---|
1064 | LogFlowThisFuncLeave();
|
---|
1065 | return rc;
|
---|
1066 | }
|
---|
1067 |
|
---|
1068 | /**
|
---|
1069 | * Uninitializes this SnapshotMachine object.
|
---|
1070 | */
|
---|
1071 | void SnapshotMachine::uninit()
|
---|
1072 | {
|
---|
1073 | LogFlowThisFuncEnter();
|
---|
1074 |
|
---|
1075 | /* Enclose the state transition Ready->InUninit->NotReady */
|
---|
1076 | AutoUninitSpan autoUninitSpan(this);
|
---|
1077 | if (autoUninitSpan.uninitDone())
|
---|
1078 | return;
|
---|
1079 |
|
---|
1080 | uninitDataAndChildObjects();
|
---|
1081 |
|
---|
1082 | /* free the essential data structure last */
|
---|
1083 | mData.free();
|
---|
1084 |
|
---|
1085 | unconst(mParent) = NULL;
|
---|
1086 | unconst(mPeer) = NULL;
|
---|
1087 |
|
---|
1088 | LogFlowThisFuncLeave();
|
---|
1089 | }
|
---|
1090 |
|
---|
1091 | /**
|
---|
1092 | * Overrides VirtualBoxBase::lockHandle() in order to share the lock handle
|
---|
1093 | * with the primary Machine instance (mPeer).
|
---|
1094 | */
|
---|
1095 | RWLockHandle *SnapshotMachine::lockHandle() const
|
---|
1096 | {
|
---|
1097 | AssertReturn(mPeer != NULL, NULL);
|
---|
1098 | return mPeer->lockHandle();
|
---|
1099 | }
|
---|
1100 |
|
---|
1101 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1102 | //
|
---|
1103 | // SnapshotMachine public internal methods
|
---|
1104 | //
|
---|
1105 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1106 |
|
---|
1107 | /**
|
---|
1108 | * Called by the snapshot object associated with this SnapshotMachine when
|
---|
1109 | * snapshot data such as name or description is changed.
|
---|
1110 | *
|
---|
1111 | * @note Locks this object for writing.
|
---|
1112 | */
|
---|
1113 | HRESULT SnapshotMachine::onSnapshotChange(Snapshot *aSnapshot)
|
---|
1114 | {
|
---|
1115 | AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
1116 |
|
---|
1117 | // mPeer->saveAllSnapshots(); @todo
|
---|
1118 |
|
---|
1119 | /* inform callbacks */
|
---|
1120 | mParent->onSnapshotChange(mData->mUuid, aSnapshot->getId());
|
---|
1121 |
|
---|
1122 | return S_OK;
|
---|
1123 | }
|
---|
1124 |
|
---|
1125 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1126 | //
|
---|
1127 | // SessionMachine task records
|
---|
1128 | //
|
---|
1129 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1130 |
|
---|
1131 | /**
|
---|
1132 | * Abstract base class for SessionMachine::RestoreSnapshotTask and
|
---|
1133 | * SessionMachine::DeleteSnapshotTask. This is necessary since
|
---|
1134 | * RTThreadCreate cannot call a method as its thread function, so
|
---|
1135 | * instead we have it call the static SessionMachine::taskHandler,
|
---|
1136 | * which can then call the handler() method in here (implemented
|
---|
1137 | * by the children).
|
---|
1138 | */
|
---|
1139 | struct SessionMachine::SnapshotTask
|
---|
1140 | {
|
---|
1141 | SnapshotTask(SessionMachine *m,
|
---|
1142 | Progress *p,
|
---|
1143 | Snapshot *s)
|
---|
1144 | : pMachine(m),
|
---|
1145 | pProgress(p),
|
---|
1146 | machineStateBackup(m->mData->mMachineState), // save the current machine state
|
---|
1147 | pSnapshot(s)
|
---|
1148 | {}
|
---|
1149 |
|
---|
1150 | void modifyBackedUpState(MachineState_T s)
|
---|
1151 | {
|
---|
1152 | *const_cast<MachineState_T*>(&machineStateBackup) = s;
|
---|
1153 | }
|
---|
1154 |
|
---|
1155 | virtual void handler() = 0;
|
---|
1156 |
|
---|
1157 | ComObjPtr<SessionMachine> pMachine;
|
---|
1158 | ComObjPtr<Progress> pProgress;
|
---|
1159 | const MachineState_T machineStateBackup;
|
---|
1160 | ComObjPtr<Snapshot> pSnapshot;
|
---|
1161 | };
|
---|
1162 |
|
---|
1163 | /** Restore snapshot state task */
|
---|
1164 | struct SessionMachine::RestoreSnapshotTask
|
---|
1165 | : public SessionMachine::SnapshotTask
|
---|
1166 | {
|
---|
1167 | RestoreSnapshotTask(SessionMachine *m,
|
---|
1168 | Progress *p,
|
---|
1169 | Snapshot *s,
|
---|
1170 | ULONG ulStateFileSizeMB)
|
---|
1171 | : SnapshotTask(m, p, s),
|
---|
1172 | m_ulStateFileSizeMB(ulStateFileSizeMB)
|
---|
1173 | {}
|
---|
1174 |
|
---|
1175 | void handler()
|
---|
1176 | {
|
---|
1177 | pMachine->restoreSnapshotHandler(*this);
|
---|
1178 | }
|
---|
1179 |
|
---|
1180 | ULONG m_ulStateFileSizeMB;
|
---|
1181 | };
|
---|
1182 |
|
---|
1183 | /** Delete snapshot task */
|
---|
1184 | struct SessionMachine::DeleteSnapshotTask
|
---|
1185 | : public SessionMachine::SnapshotTask
|
---|
1186 | {
|
---|
1187 | DeleteSnapshotTask(SessionMachine *m,
|
---|
1188 | Progress *p,
|
---|
1189 | bool fDeleteOnline,
|
---|
1190 | Snapshot *s)
|
---|
1191 | : SnapshotTask(m, p, s),
|
---|
1192 | m_fDeleteOnline(fDeleteOnline)
|
---|
1193 | {}
|
---|
1194 |
|
---|
1195 | void handler()
|
---|
1196 | {
|
---|
1197 | pMachine->deleteSnapshotHandler(*this);
|
---|
1198 | }
|
---|
1199 |
|
---|
1200 | bool m_fDeleteOnline;
|
---|
1201 | };
|
---|
1202 |
|
---|
1203 | /**
|
---|
1204 | * Static SessionMachine method that can get passed to RTThreadCreate to
|
---|
1205 | * have a thread started for a SnapshotTask. See SnapshotTask above.
|
---|
1206 | *
|
---|
1207 | * This calls either RestoreSnapshotTask::handler() or DeleteSnapshotTask::handler().
|
---|
1208 | */
|
---|
1209 |
|
---|
1210 | /* static */ DECLCALLBACK(int) SessionMachine::taskHandler(RTTHREAD /* thread */, void *pvUser)
|
---|
1211 | {
|
---|
1212 | AssertReturn(pvUser, VERR_INVALID_POINTER);
|
---|
1213 |
|
---|
1214 | SnapshotTask *task = static_cast<SnapshotTask*>(pvUser);
|
---|
1215 | task->handler();
|
---|
1216 |
|
---|
1217 | // it's our responsibility to delete the task
|
---|
1218 | delete task;
|
---|
1219 |
|
---|
1220 | return 0;
|
---|
1221 | }
|
---|
1222 |
|
---|
1223 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1224 | //
|
---|
1225 | // TakeSnapshot methods (SessionMachine and related tasks)
|
---|
1226 | //
|
---|
1227 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1228 |
|
---|
1229 | /**
|
---|
1230 | * Implementation for IInternalMachineControl::beginTakingSnapshot().
|
---|
1231 | *
|
---|
1232 | * Gets called indirectly from Console::TakeSnapshot, which creates a
|
---|
1233 | * progress object in the client and then starts a thread
|
---|
1234 | * (Console::fntTakeSnapshotWorker) which then calls this.
|
---|
1235 | *
|
---|
1236 | * In other words, the asynchronous work for taking snapshots takes place
|
---|
1237 | * on the _client_ (in the Console). This is different from restoring
|
---|
1238 | * or deleting snapshots, which start threads on the server.
|
---|
1239 | *
|
---|
1240 | * This does the server-side work of taking a snapshot: it creates diffencing
|
---|
1241 | * images for all hard disks attached to the machine and then creates a
|
---|
1242 | * Snapshot object with a corresponding SnapshotMachine to save the VM settings.
|
---|
1243 | *
|
---|
1244 | * The client's fntTakeSnapshotWorker() blocks while this takes place.
|
---|
1245 | * After this returns successfully, fntTakeSnapshotWorker() will begin
|
---|
1246 | * saving the machine state to the snapshot object and reconfigure the
|
---|
1247 | * hard disks.
|
---|
1248 | *
|
---|
1249 | * When the console is done, it calls SessionMachine::EndTakingSnapshot().
|
---|
1250 | *
|
---|
1251 | * @note Locks mParent + this object for writing.
|
---|
1252 | *
|
---|
1253 | * @param aInitiator in: The console on which Console::TakeSnapshot was called.
|
---|
1254 | * @param aName in: The name for the new snapshot.
|
---|
1255 | * @param aDescription in: A description for the new snapshot.
|
---|
1256 | * @param aConsoleProgress in: The console's (client's) progress object.
|
---|
1257 | * @param fTakingSnapshotOnline in: True if an online snapshot is being taken (i.e. machine is running).
|
---|
1258 | * @param aStateFilePath out: name of file in snapshots folder to which the console should write the VM state.
|
---|
1259 | * @return
|
---|
1260 | */
|
---|
1261 | STDMETHODIMP SessionMachine::BeginTakingSnapshot(IConsole *aInitiator,
|
---|
1262 | IN_BSTR aName,
|
---|
1263 | IN_BSTR aDescription,
|
---|
1264 | IProgress *aConsoleProgress,
|
---|
1265 | BOOL fTakingSnapshotOnline,
|
---|
1266 | BSTR *aStateFilePath)
|
---|
1267 | {
|
---|
1268 | LogFlowThisFuncEnter();
|
---|
1269 |
|
---|
1270 | AssertReturn(aInitiator && aName, E_INVALIDARG);
|
---|
1271 | AssertReturn(aStateFilePath, E_POINTER);
|
---|
1272 |
|
---|
1273 | LogFlowThisFunc(("aName='%ls' fTakingSnapshotOnline=%RTbool\n", aName, fTakingSnapshotOnline));
|
---|
1274 |
|
---|
1275 | AutoCaller autoCaller(this);
|
---|
1276 | AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
|
---|
1277 |
|
---|
1278 | // if this becomes true, we need to call VirtualBox::saveSettings() in the end
|
---|
1279 | bool fNeedsSaveSettings = false;
|
---|
1280 |
|
---|
1281 | AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
1282 |
|
---|
1283 | AssertReturn( !Global::IsOnlineOrTransient(mData->mMachineState)
|
---|
1284 | || mData->mMachineState == MachineState_Running
|
---|
1285 | || mData->mMachineState == MachineState_Paused, E_FAIL);
|
---|
1286 | AssertReturn(mSnapshotData.mLastState == MachineState_Null, E_FAIL);
|
---|
1287 | AssertReturn(mSnapshotData.mSnapshot.isNull(), E_FAIL);
|
---|
1288 |
|
---|
1289 | if ( !fTakingSnapshotOnline
|
---|
1290 | && mData->mMachineState != MachineState_Saved
|
---|
1291 | )
|
---|
1292 | {
|
---|
1293 | /* save all current settings to ensure current changes are committed and
|
---|
1294 | * hard disks are fixed up */
|
---|
1295 | HRESULT rc = saveSettings(NULL);
|
---|
1296 | // no need to check for whether VirtualBox.xml needs changing since
|
---|
1297 | // we can't have a machine XML rename pending at this point
|
---|
1298 | if (FAILED(rc)) return rc;
|
---|
1299 | }
|
---|
1300 |
|
---|
1301 | /* create an ID for the snapshot */
|
---|
1302 | Guid snapshotId;
|
---|
1303 | snapshotId.create();
|
---|
1304 |
|
---|
1305 | Utf8Str strStateFilePath;
|
---|
1306 | /* stateFilePath is null when the machine is not online nor saved */
|
---|
1307 | if ( fTakingSnapshotOnline
|
---|
1308 | || mData->mMachineState == MachineState_Saved)
|
---|
1309 | {
|
---|
1310 | strStateFilePath = Utf8StrFmt("%ls%c{%RTuuid}.sav",
|
---|
1311 | mUserData->mSnapshotFolderFull.raw(),
|
---|
1312 | RTPATH_DELIMITER,
|
---|
1313 | snapshotId.ptr());
|
---|
1314 | /* ensure the directory for the saved state file exists */
|
---|
1315 | HRESULT rc = VirtualBox::ensureFilePathExists(strStateFilePath);
|
---|
1316 | if (FAILED(rc)) return rc;
|
---|
1317 | }
|
---|
1318 |
|
---|
1319 | /* create a snapshot machine object */
|
---|
1320 | ComObjPtr<SnapshotMachine> snapshotMachine;
|
---|
1321 | snapshotMachine.createObject();
|
---|
1322 | HRESULT rc = snapshotMachine->init(this, snapshotId, strStateFilePath);
|
---|
1323 | AssertComRCReturn(rc, rc);
|
---|
1324 |
|
---|
1325 | /* create a snapshot object */
|
---|
1326 | RTTIMESPEC time;
|
---|
1327 | ComObjPtr<Snapshot> pSnapshot;
|
---|
1328 | pSnapshot.createObject();
|
---|
1329 | rc = pSnapshot->init(mParent,
|
---|
1330 | snapshotId,
|
---|
1331 | aName,
|
---|
1332 | aDescription,
|
---|
1333 | *RTTimeNow(&time),
|
---|
1334 | snapshotMachine,
|
---|
1335 | mData->mCurrentSnapshot);
|
---|
1336 | AssertComRCReturnRC(rc);
|
---|
1337 |
|
---|
1338 | /* fill in the snapshot data */
|
---|
1339 | mSnapshotData.mLastState = mData->mMachineState;
|
---|
1340 | mSnapshotData.mSnapshot = pSnapshot;
|
---|
1341 |
|
---|
1342 | try
|
---|
1343 | {
|
---|
1344 | LogFlowThisFunc(("Creating differencing hard disks (online=%d)...\n",
|
---|
1345 | fTakingSnapshotOnline));
|
---|
1346 |
|
---|
1347 | // backup the media data so we can recover if things goes wrong along the day;
|
---|
1348 | // the matching commit() is in fixupMedia() during endSnapshot()
|
---|
1349 | setModified(IsModified_Storage);
|
---|
1350 | mMediaData.backup();
|
---|
1351 |
|
---|
1352 | /* Console::fntTakeSnapshotWorker and friends expects this. */
|
---|
1353 | if (mSnapshotData.mLastState == MachineState_Running)
|
---|
1354 | setMachineState(MachineState_LiveSnapshotting);
|
---|
1355 | else
|
---|
1356 | setMachineState(MachineState_Saving); /** @todo Confusing! Saving is used for both online and offline snapshots. */
|
---|
1357 |
|
---|
1358 | /* create new differencing hard disks and attach them to this machine */
|
---|
1359 | rc = createImplicitDiffs(mUserData->mSnapshotFolderFull,
|
---|
1360 | aConsoleProgress,
|
---|
1361 | 1, // operation weight; must be the same as in Console::TakeSnapshot()
|
---|
1362 | !!fTakingSnapshotOnline,
|
---|
1363 | &fNeedsSaveSettings);
|
---|
1364 | if (FAILED(rc))
|
---|
1365 | throw rc;
|
---|
1366 |
|
---|
1367 | if (mSnapshotData.mLastState == MachineState_Saved)
|
---|
1368 | {
|
---|
1369 | Utf8Str stateFrom = mSSData->mStateFilePath;
|
---|
1370 | Utf8Str stateTo = mSnapshotData.mSnapshot->stateFilePath();
|
---|
1371 |
|
---|
1372 | LogFlowThisFunc(("Copying the execution state from '%s' to '%s'...\n",
|
---|
1373 | stateFrom.raw(), stateTo.raw()));
|
---|
1374 |
|
---|
1375 | aConsoleProgress->SetNextOperation(Bstr(tr("Copying the execution state")),
|
---|
1376 | 1); // weight
|
---|
1377 |
|
---|
1378 | /* Leave the lock before a lengthy operation (machine is protected
|
---|
1379 | * by "Saving" machine state now) */
|
---|
1380 | alock.release();
|
---|
1381 |
|
---|
1382 | /* copy the state file */
|
---|
1383 | int vrc = RTFileCopyEx(stateFrom.c_str(),
|
---|
1384 | stateTo.c_str(),
|
---|
1385 | 0,
|
---|
1386 | progressCallback,
|
---|
1387 | aConsoleProgress);
|
---|
1388 | alock.acquire();
|
---|
1389 |
|
---|
1390 | if (RT_FAILURE(vrc))
|
---|
1391 | /** @todo r=bird: Delete stateTo when appropriate. */
|
---|
1392 | throw setError(E_FAIL,
|
---|
1393 | tr("Could not copy the state file '%s' to '%s' (%Rrc)"),
|
---|
1394 | stateFrom.raw(),
|
---|
1395 | stateTo.raw(),
|
---|
1396 | vrc);
|
---|
1397 | }
|
---|
1398 | }
|
---|
1399 | catch (HRESULT hrc)
|
---|
1400 | {
|
---|
1401 | LogThisFunc(("Caught %Rhrc [%s]\n", hrc, Global::stringifyMachineState(mData->mMachineState) ));
|
---|
1402 | if ( mSnapshotData.mLastState != mData->mMachineState
|
---|
1403 | && ( mSnapshotData.mLastState == MachineState_Running
|
---|
1404 | ? mData->mMachineState == MachineState_LiveSnapshotting
|
---|
1405 | : mData->mMachineState == MachineState_Saving)
|
---|
1406 | )
|
---|
1407 | setMachineState(mSnapshotData.mLastState);
|
---|
1408 |
|
---|
1409 | pSnapshot->uninit();
|
---|
1410 | pSnapshot.setNull();
|
---|
1411 | mSnapshotData.mLastState = MachineState_Null;
|
---|
1412 | mSnapshotData.mSnapshot.setNull();
|
---|
1413 |
|
---|
1414 | rc = hrc;
|
---|
1415 |
|
---|
1416 | // @todo r=dj what with the implicit diff that we created above? this is never cleaned up
|
---|
1417 | }
|
---|
1418 |
|
---|
1419 | if (fTakingSnapshotOnline && SUCCEEDED(rc))
|
---|
1420 | strStateFilePath.cloneTo(aStateFilePath);
|
---|
1421 | else
|
---|
1422 | *aStateFilePath = NULL;
|
---|
1423 |
|
---|
1424 | // @todo r=dj normally we would need to save the settings if fNeedsSaveSettings was set to true,
|
---|
1425 | // but since we have no error handling that cleans up the diff image that might have gotten created,
|
---|
1426 | // there's no point in saving the disk registry at this point either... this needs fixing.
|
---|
1427 |
|
---|
1428 | LogFlowThisFunc(("LEAVE - %Rhrc [%s]\n", rc, Global::stringifyMachineState(mData->mMachineState) ));
|
---|
1429 | return rc;
|
---|
1430 | }
|
---|
1431 |
|
---|
1432 | /**
|
---|
1433 | * Implementation for IInternalMachineControl::endTakingSnapshot().
|
---|
1434 | *
|
---|
1435 | * Called by the Console when it's done saving the VM state into the snapshot
|
---|
1436 | * (if online) and reconfiguring the hard disks. See BeginTakingSnapshot() above.
|
---|
1437 | *
|
---|
1438 | * This also gets called if the console part of snapshotting failed after the
|
---|
1439 | * BeginTakingSnapshot() call, to clean up the server side.
|
---|
1440 | *
|
---|
1441 | * @note Locks VirtualBox and this object for writing.
|
---|
1442 | *
|
---|
1443 | * @param aSuccess Whether Console was successful with the client-side snapshot things.
|
---|
1444 | * @return
|
---|
1445 | */
|
---|
1446 | STDMETHODIMP SessionMachine::EndTakingSnapshot(BOOL aSuccess)
|
---|
1447 | {
|
---|
1448 | LogFlowThisFunc(("\n"));
|
---|
1449 |
|
---|
1450 | AutoCaller autoCaller(this);
|
---|
1451 | AssertComRCReturn (autoCaller.rc(), autoCaller.rc());
|
---|
1452 |
|
---|
1453 | AutoWriteLock machineLock(this COMMA_LOCKVAL_SRC_POS);
|
---|
1454 |
|
---|
1455 | AssertReturn( !aSuccess
|
---|
1456 | || ( ( mData->mMachineState == MachineState_Saving
|
---|
1457 | || mData->mMachineState == MachineState_LiveSnapshotting)
|
---|
1458 | && mSnapshotData.mLastState != MachineState_Null
|
---|
1459 | && !mSnapshotData.mSnapshot.isNull()
|
---|
1460 | )
|
---|
1461 | , E_FAIL);
|
---|
1462 |
|
---|
1463 | /*
|
---|
1464 | * Restore the state we had when BeginTakingSnapshot() was called,
|
---|
1465 | * Console::fntTakeSnapshotWorker restores its local copy when we return.
|
---|
1466 | * If the state was Running, then let Console::fntTakeSnapshotWorker do it
|
---|
1467 | * all to avoid races.
|
---|
1468 | */
|
---|
1469 | if ( mData->mMachineState != mSnapshotData.mLastState
|
---|
1470 | && mSnapshotData.mLastState != MachineState_Running
|
---|
1471 | )
|
---|
1472 | setMachineState(mSnapshotData.mLastState);
|
---|
1473 |
|
---|
1474 | ComObjPtr<Snapshot> pOldFirstSnap = mData->mFirstSnapshot;
|
---|
1475 | ComObjPtr<Snapshot> pOldCurrentSnap = mData->mCurrentSnapshot;
|
---|
1476 |
|
---|
1477 | bool fOnline = Global::IsOnline(mSnapshotData.mLastState);
|
---|
1478 |
|
---|
1479 | HRESULT rc = S_OK;
|
---|
1480 |
|
---|
1481 | if (aSuccess)
|
---|
1482 | {
|
---|
1483 | // new snapshot becomes the current one
|
---|
1484 | mData->mCurrentSnapshot = mSnapshotData.mSnapshot;
|
---|
1485 |
|
---|
1486 | /* memorize the first snapshot if necessary */
|
---|
1487 | if (!mData->mFirstSnapshot)
|
---|
1488 | mData->mFirstSnapshot = mData->mCurrentSnapshot;
|
---|
1489 |
|
---|
1490 | int flSaveSettings = SaveS_Force; // do not do a deep compare in machine settings,
|
---|
1491 | // snapshots change, so we know we need to save
|
---|
1492 | if (!fOnline)
|
---|
1493 | /* the machine was powered off or saved when taking a snapshot, so
|
---|
1494 | * reset the mCurrentStateModified flag */
|
---|
1495 | flSaveSettings |= SaveS_ResetCurStateModified;
|
---|
1496 |
|
---|
1497 | rc = saveSettings(NULL, flSaveSettings);
|
---|
1498 | // no need to change for whether VirtualBox.xml needs saving since
|
---|
1499 | // we'll save the global settings below anyway
|
---|
1500 | }
|
---|
1501 |
|
---|
1502 | if (aSuccess && SUCCEEDED(rc))
|
---|
1503 | {
|
---|
1504 | /* associate old hard disks with the snapshot and do locking/unlocking*/
|
---|
1505 | commitMedia(fOnline);
|
---|
1506 |
|
---|
1507 | /* inform callbacks */
|
---|
1508 | mParent->onSnapshotTaken(mData->mUuid,
|
---|
1509 | mSnapshotData.mSnapshot->getId());
|
---|
1510 | }
|
---|
1511 | else
|
---|
1512 | {
|
---|
1513 | /* delete all differencing hard disks created (this will also attach
|
---|
1514 | * their parents back by rolling back mMediaData) */
|
---|
1515 | rollbackMedia();
|
---|
1516 |
|
---|
1517 | mData->mFirstSnapshot = pOldFirstSnap; // might have been changed above
|
---|
1518 | mData->mCurrentSnapshot = pOldCurrentSnap; // might have been changed above
|
---|
1519 |
|
---|
1520 | /* delete the saved state file (it might have been already created) */
|
---|
1521 | if (mSnapshotData.mSnapshot->stateFilePath().length())
|
---|
1522 | RTFileDelete(mSnapshotData.mSnapshot->stateFilePath().c_str());
|
---|
1523 |
|
---|
1524 | mSnapshotData.mSnapshot->uninit();
|
---|
1525 | }
|
---|
1526 |
|
---|
1527 | /* clear out the snapshot data */
|
---|
1528 | mSnapshotData.mLastState = MachineState_Null;
|
---|
1529 | mSnapshotData.mSnapshot.setNull();
|
---|
1530 |
|
---|
1531 | // save VirtualBox.xml (media registry most probably changed with diff image)
|
---|
1532 | machineLock.release();
|
---|
1533 | AutoWriteLock vboxLock(mParent COMMA_LOCKVAL_SRC_POS);
|
---|
1534 | mParent->saveSettings();
|
---|
1535 |
|
---|
1536 | return rc;
|
---|
1537 | }
|
---|
1538 |
|
---|
1539 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1540 | //
|
---|
1541 | // RestoreSnapshot methods (SessionMachine and related tasks)
|
---|
1542 | //
|
---|
1543 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1544 |
|
---|
1545 | /**
|
---|
1546 | * Implementation for IInternalMachineControl::restoreSnapshot().
|
---|
1547 | *
|
---|
1548 | * Gets called from Console::RestoreSnapshot(), and that's basically the
|
---|
1549 | * only thing Console does. Restoring a snapshot happens entirely on the
|
---|
1550 | * server side since the machine cannot be running.
|
---|
1551 | *
|
---|
1552 | * This creates a new thread that does the work and returns a progress
|
---|
1553 | * object to the client which is then returned to the caller of
|
---|
1554 | * Console::RestoreSnapshot().
|
---|
1555 | *
|
---|
1556 | * Actual work then takes place in RestoreSnapshotTask::handler().
|
---|
1557 | *
|
---|
1558 | * @note Locks this + children objects for writing!
|
---|
1559 | *
|
---|
1560 | * @param aInitiator in: rhe console on which Console::RestoreSnapshot was called.
|
---|
1561 | * @param aSnapshot in: the snapshot to restore.
|
---|
1562 | * @param aMachineState in: client-side machine state.
|
---|
1563 | * @param aProgress out: progress object to monitor restore thread.
|
---|
1564 | * @return
|
---|
1565 | */
|
---|
1566 | STDMETHODIMP SessionMachine::RestoreSnapshot(IConsole *aInitiator,
|
---|
1567 | ISnapshot *aSnapshot,
|
---|
1568 | MachineState_T *aMachineState,
|
---|
1569 | IProgress **aProgress)
|
---|
1570 | {
|
---|
1571 | LogFlowThisFuncEnter();
|
---|
1572 |
|
---|
1573 | AssertReturn(aInitiator, E_INVALIDARG);
|
---|
1574 | AssertReturn(aSnapshot && aMachineState && aProgress, E_POINTER);
|
---|
1575 |
|
---|
1576 | AutoCaller autoCaller(this);
|
---|
1577 | AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
|
---|
1578 |
|
---|
1579 | AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
1580 |
|
---|
1581 | // machine must not be running
|
---|
1582 | ComAssertRet(!Global::IsOnlineOrTransient(mData->mMachineState),
|
---|
1583 | E_FAIL);
|
---|
1584 |
|
---|
1585 | ComObjPtr<Snapshot> pSnapshot(static_cast<Snapshot*>(aSnapshot));
|
---|
1586 | ComObjPtr<SnapshotMachine> pSnapMachine = pSnapshot->getSnapshotMachine();
|
---|
1587 |
|
---|
1588 | // create a progress object. The number of operations is:
|
---|
1589 | // 1 (preparing) + # of hard disks + 1 (if we need to copy the saved state file) */
|
---|
1590 | LogFlowThisFunc(("Going thru snapshot machine attachments to determine progress setup\n"));
|
---|
1591 |
|
---|
1592 | ULONG ulOpCount = 1; // one for preparations
|
---|
1593 | ULONG ulTotalWeight = 1; // one for preparations
|
---|
1594 | for (MediaData::AttachmentList::iterator it = pSnapMachine->mMediaData->mAttachments.begin();
|
---|
1595 | it != pSnapMachine->mMediaData->mAttachments.end();
|
---|
1596 | ++it)
|
---|
1597 | {
|
---|
1598 | ComObjPtr<MediumAttachment> &pAttach = *it;
|
---|
1599 | AutoReadLock attachLock(pAttach COMMA_LOCKVAL_SRC_POS);
|
---|
1600 | if (pAttach->getType() == DeviceType_HardDisk)
|
---|
1601 | {
|
---|
1602 | ++ulOpCount;
|
---|
1603 | ++ulTotalWeight; // assume one MB weight for each differencing hard disk to manage
|
---|
1604 | Assert(pAttach->getMedium());
|
---|
1605 | LogFlowThisFunc(("op %d: considering hard disk attachment %s\n", ulOpCount, pAttach->getMedium()->getName().c_str()));
|
---|
1606 | }
|
---|
1607 | }
|
---|
1608 |
|
---|
1609 | ULONG ulStateFileSizeMB = 0;
|
---|
1610 | if (pSnapshot->stateFilePath().length())
|
---|
1611 | {
|
---|
1612 | ++ulOpCount; // one for the saved state
|
---|
1613 |
|
---|
1614 | uint64_t ullSize;
|
---|
1615 | int irc = RTFileQuerySize(pSnapshot->stateFilePath().c_str(), &ullSize);
|
---|
1616 | if (!RT_SUCCESS(irc))
|
---|
1617 | // if we can't access the file here, then we'll be doomed later also, so fail right away
|
---|
1618 | setError(E_FAIL, tr("Cannot access state file '%s', runtime error, %Rra"), pSnapshot->stateFilePath().c_str(), irc);
|
---|
1619 | if (ullSize == 0) // avoid division by zero
|
---|
1620 | ullSize = _1M;
|
---|
1621 |
|
---|
1622 | ulStateFileSizeMB = (ULONG)(ullSize / _1M);
|
---|
1623 | LogFlowThisFunc(("op %d: saved state file '%s' has %RI64 bytes (%d MB)\n",
|
---|
1624 | ulOpCount, pSnapshot->stateFilePath().raw(), ullSize, ulStateFileSizeMB));
|
---|
1625 |
|
---|
1626 | ulTotalWeight += ulStateFileSizeMB;
|
---|
1627 | }
|
---|
1628 |
|
---|
1629 | ComObjPtr<Progress> pProgress;
|
---|
1630 | pProgress.createObject();
|
---|
1631 | pProgress->init(mParent, aInitiator,
|
---|
1632 | BstrFmt(tr("Restoring snapshot '%s'"), pSnapshot->getName().c_str()),
|
---|
1633 | FALSE /* aCancelable */,
|
---|
1634 | ulOpCount,
|
---|
1635 | ulTotalWeight,
|
---|
1636 | Bstr(tr("Restoring machine settings")),
|
---|
1637 | 1);
|
---|
1638 |
|
---|
1639 | /* create and start the task on a separate thread (note that it will not
|
---|
1640 | * start working until we release alock) */
|
---|
1641 | RestoreSnapshotTask *task = new RestoreSnapshotTask(this,
|
---|
1642 | pProgress,
|
---|
1643 | pSnapshot,
|
---|
1644 | ulStateFileSizeMB);
|
---|
1645 | int vrc = RTThreadCreate(NULL,
|
---|
1646 | taskHandler,
|
---|
1647 | (void*)task,
|
---|
1648 | 0,
|
---|
1649 | RTTHREADTYPE_MAIN_WORKER,
|
---|
1650 | 0,
|
---|
1651 | "RestoreSnap");
|
---|
1652 | if (RT_FAILURE(vrc))
|
---|
1653 | {
|
---|
1654 | delete task;
|
---|
1655 | ComAssertRCRet(vrc, E_FAIL);
|
---|
1656 | }
|
---|
1657 |
|
---|
1658 | /* set the proper machine state (note: after creating a Task instance) */
|
---|
1659 | setMachineState(MachineState_RestoringSnapshot);
|
---|
1660 |
|
---|
1661 | /* return the progress to the caller */
|
---|
1662 | pProgress.queryInterfaceTo(aProgress);
|
---|
1663 |
|
---|
1664 | /* return the new state to the caller */
|
---|
1665 | *aMachineState = mData->mMachineState;
|
---|
1666 |
|
---|
1667 | LogFlowThisFuncLeave();
|
---|
1668 |
|
---|
1669 | return S_OK;
|
---|
1670 | }
|
---|
1671 |
|
---|
1672 | /**
|
---|
1673 | * Worker method for the restore snapshot thread created by SessionMachine::RestoreSnapshot().
|
---|
1674 | * This method gets called indirectly through SessionMachine::taskHandler() which then
|
---|
1675 | * calls RestoreSnapshotTask::handler().
|
---|
1676 | *
|
---|
1677 | * The RestoreSnapshotTask contains the progress object returned to the console by
|
---|
1678 | * SessionMachine::RestoreSnapshot, through which progress and results are reported.
|
---|
1679 | *
|
---|
1680 | * @note Locks mParent + this object for writing.
|
---|
1681 | *
|
---|
1682 | * @param aTask Task data.
|
---|
1683 | */
|
---|
1684 | void SessionMachine::restoreSnapshotHandler(RestoreSnapshotTask &aTask)
|
---|
1685 | {
|
---|
1686 | LogFlowThisFuncEnter();
|
---|
1687 |
|
---|
1688 | AutoCaller autoCaller(this);
|
---|
1689 |
|
---|
1690 | LogFlowThisFunc(("state=%d\n", autoCaller.state()));
|
---|
1691 | if (!autoCaller.isOk())
|
---|
1692 | {
|
---|
1693 | /* we might have been uninitialized because the session was accidentally
|
---|
1694 | * closed by the client, so don't assert */
|
---|
1695 | aTask.pProgress->notifyComplete(E_FAIL,
|
---|
1696 | COM_IIDOF(IMachine),
|
---|
1697 | getComponentName(),
|
---|
1698 | tr("The session has been accidentally closed"));
|
---|
1699 |
|
---|
1700 | LogFlowThisFuncLeave();
|
---|
1701 | return;
|
---|
1702 | }
|
---|
1703 |
|
---|
1704 | AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
1705 |
|
---|
1706 | /* discard all current changes to mUserData (name, OSType etc.) (note that
|
---|
1707 | * the machine is powered off, so there is no need to inform the direct
|
---|
1708 | * session) */
|
---|
1709 | if (mData->flModifications)
|
---|
1710 | rollback(false /* aNotify */);
|
---|
1711 |
|
---|
1712 | HRESULT rc = S_OK;
|
---|
1713 |
|
---|
1714 | bool stateRestored = false;
|
---|
1715 | bool fNeedsSaveSettings = false;
|
---|
1716 |
|
---|
1717 | try
|
---|
1718 | {
|
---|
1719 | /* Delete the saved state file if the machine was Saved prior to this
|
---|
1720 | * operation */
|
---|
1721 | if (aTask.machineStateBackup == MachineState_Saved)
|
---|
1722 | {
|
---|
1723 | Assert(!mSSData->mStateFilePath.isEmpty());
|
---|
1724 | RTFileDelete(mSSData->mStateFilePath.c_str());
|
---|
1725 | mSSData->mStateFilePath.setNull();
|
---|
1726 | aTask.modifyBackedUpState(MachineState_PoweredOff);
|
---|
1727 | rc = saveStateSettings(SaveSTS_StateFilePath);
|
---|
1728 | if (FAILED(rc))
|
---|
1729 | throw rc;
|
---|
1730 | }
|
---|
1731 |
|
---|
1732 | RTTIMESPEC snapshotTimeStamp;
|
---|
1733 | RTTimeSpecSetMilli(&snapshotTimeStamp, 0);
|
---|
1734 |
|
---|
1735 | {
|
---|
1736 | AutoReadLock snapshotLock(aTask.pSnapshot COMMA_LOCKVAL_SRC_POS);
|
---|
1737 |
|
---|
1738 | /* remember the timestamp of the snapshot we're restoring from */
|
---|
1739 | snapshotTimeStamp = aTask.pSnapshot->getTimeStamp();
|
---|
1740 |
|
---|
1741 | ComPtr<SnapshotMachine> pSnapshotMachine(aTask.pSnapshot->getSnapshotMachine());
|
---|
1742 |
|
---|
1743 | /* copy all hardware data from the snapshot */
|
---|
1744 | copyFrom(pSnapshotMachine);
|
---|
1745 |
|
---|
1746 | LogFlowThisFunc(("Restoring hard disks from the snapshot...\n"));
|
---|
1747 |
|
---|
1748 | // restore the attachments from the snapshot
|
---|
1749 | setModified(IsModified_Storage);
|
---|
1750 | mMediaData.backup();
|
---|
1751 | mMediaData->mAttachments = pSnapshotMachine->mMediaData->mAttachments;
|
---|
1752 |
|
---|
1753 | /* leave the locks before the potentially lengthy operation */
|
---|
1754 | snapshotLock.release();
|
---|
1755 | alock.leave();
|
---|
1756 |
|
---|
1757 | rc = createImplicitDiffs(mUserData->mSnapshotFolderFull,
|
---|
1758 | aTask.pProgress,
|
---|
1759 | 1,
|
---|
1760 | false /* aOnline */,
|
---|
1761 | &fNeedsSaveSettings);
|
---|
1762 | if (FAILED(rc))
|
---|
1763 | throw rc;
|
---|
1764 |
|
---|
1765 | alock.enter();
|
---|
1766 | snapshotLock.acquire();
|
---|
1767 |
|
---|
1768 | /* Note: on success, current (old) hard disks will be
|
---|
1769 | * deassociated/deleted on #commit() called from #saveSettings() at
|
---|
1770 | * the end. On failure, newly created implicit diffs will be
|
---|
1771 | * deleted by #rollback() at the end. */
|
---|
1772 |
|
---|
1773 | /* should not have a saved state file associated at this point */
|
---|
1774 | Assert(mSSData->mStateFilePath.isEmpty());
|
---|
1775 |
|
---|
1776 | if (!aTask.pSnapshot->stateFilePath().isEmpty())
|
---|
1777 | {
|
---|
1778 | Utf8Str snapStateFilePath = aTask.pSnapshot->stateFilePath();
|
---|
1779 |
|
---|
1780 | Utf8Str stateFilePath = Utf8StrFmt("%ls%c{%RTuuid}.sav",
|
---|
1781 | mUserData->mSnapshotFolderFull.raw(),
|
---|
1782 | RTPATH_DELIMITER,
|
---|
1783 | mData->mUuid.raw());
|
---|
1784 |
|
---|
1785 | LogFlowThisFunc(("Copying saved state file from '%s' to '%s'...\n",
|
---|
1786 | snapStateFilePath.raw(), stateFilePath.raw()));
|
---|
1787 |
|
---|
1788 | aTask.pProgress->SetNextOperation(Bstr(tr("Restoring the execution state")),
|
---|
1789 | aTask.m_ulStateFileSizeMB); // weight
|
---|
1790 |
|
---|
1791 | /* leave the lock before the potentially lengthy operation */
|
---|
1792 | snapshotLock.release();
|
---|
1793 | alock.leave();
|
---|
1794 |
|
---|
1795 | /* copy the state file */
|
---|
1796 | int vrc = RTFileCopyEx(snapStateFilePath.c_str(),
|
---|
1797 | stateFilePath.c_str(),
|
---|
1798 | 0,
|
---|
1799 | progressCallback,
|
---|
1800 | static_cast<IProgress*>(aTask.pProgress));
|
---|
1801 |
|
---|
1802 | alock.enter();
|
---|
1803 | snapshotLock.acquire();
|
---|
1804 |
|
---|
1805 | if (RT_SUCCESS(vrc))
|
---|
1806 | mSSData->mStateFilePath = stateFilePath;
|
---|
1807 | else
|
---|
1808 | throw setError(E_FAIL,
|
---|
1809 | tr("Could not copy the state file '%s' to '%s' (%Rrc)"),
|
---|
1810 | snapStateFilePath.raw(),
|
---|
1811 | stateFilePath.raw(),
|
---|
1812 | vrc);
|
---|
1813 | }
|
---|
1814 |
|
---|
1815 | LogFlowThisFunc(("Setting new current snapshot {%RTuuid}\n", aTask.pSnapshot->getId().raw()));
|
---|
1816 | /* make the snapshot we restored from the current snapshot */
|
---|
1817 | mData->mCurrentSnapshot = aTask.pSnapshot;
|
---|
1818 | }
|
---|
1819 |
|
---|
1820 | /* grab differencing hard disks from the old attachments that will
|
---|
1821 | * become unused and need to be auto-deleted */
|
---|
1822 | std::list< ComObjPtr<MediumAttachment> > llDiffAttachmentsToDelete;
|
---|
1823 |
|
---|
1824 | for (MediaData::AttachmentList::const_iterator it = mMediaData.backedUpData()->mAttachments.begin();
|
---|
1825 | it != mMediaData.backedUpData()->mAttachments.end();
|
---|
1826 | ++it)
|
---|
1827 | {
|
---|
1828 | ComObjPtr<MediumAttachment> pAttach = *it;
|
---|
1829 | ComObjPtr<Medium> pMedium = pAttach->getMedium();
|
---|
1830 |
|
---|
1831 | /* while the hard disk is attached, the number of children or the
|
---|
1832 | * parent cannot change, so no lock */
|
---|
1833 | if ( !pMedium.isNull()
|
---|
1834 | && pAttach->getType() == DeviceType_HardDisk
|
---|
1835 | && !pMedium->getParent().isNull()
|
---|
1836 | && pMedium->getChildren().size() == 0
|
---|
1837 | )
|
---|
1838 | {
|
---|
1839 | LogFlowThisFunc(("Picked differencing image '%s' for deletion\n", pMedium->getName().raw()));
|
---|
1840 |
|
---|
1841 | llDiffAttachmentsToDelete.push_back(pAttach);
|
---|
1842 | }
|
---|
1843 | }
|
---|
1844 |
|
---|
1845 | int saveFlags = 0;
|
---|
1846 |
|
---|
1847 | /* we have already deleted the current state, so set the execution
|
---|
1848 | * state accordingly no matter of the delete snapshot result */
|
---|
1849 | if (!mSSData->mStateFilePath.isEmpty())
|
---|
1850 | setMachineState(MachineState_Saved);
|
---|
1851 | else
|
---|
1852 | setMachineState(MachineState_PoweredOff);
|
---|
1853 |
|
---|
1854 | updateMachineStateOnClient();
|
---|
1855 | stateRestored = true;
|
---|
1856 |
|
---|
1857 | /* assign the timestamp from the snapshot */
|
---|
1858 | Assert(RTTimeSpecGetMilli (&snapshotTimeStamp) != 0);
|
---|
1859 | mData->mLastStateChange = snapshotTimeStamp;
|
---|
1860 |
|
---|
1861 | // detach the current-state diffs that we detected above and build a list of
|
---|
1862 | // image files to delete _after_ saveSettings()
|
---|
1863 |
|
---|
1864 | MediaList llDiffsToDelete;
|
---|
1865 |
|
---|
1866 | for (std::list< ComObjPtr<MediumAttachment> >::iterator it = llDiffAttachmentsToDelete.begin();
|
---|
1867 | it != llDiffAttachmentsToDelete.end();
|
---|
1868 | ++it)
|
---|
1869 | {
|
---|
1870 | ComObjPtr<MediumAttachment> pAttach = *it; // guaranteed to have only attachments where medium != NULL
|
---|
1871 | ComObjPtr<Medium> pMedium = pAttach->getMedium();
|
---|
1872 |
|
---|
1873 | AutoWriteLock mlock(pMedium COMMA_LOCKVAL_SRC_POS);
|
---|
1874 |
|
---|
1875 | LogFlowThisFunc(("Detaching old current state in differencing image '%s'\n", pMedium->getName().raw()));
|
---|
1876 |
|
---|
1877 | // Normally we "detach" the medium by removing the attachment object
|
---|
1878 | // from the current machine data; saveSettings() below would then
|
---|
1879 | // compare the current machine data with the one in the backup
|
---|
1880 | // and actually call Medium::detachFrom(). But that works only half
|
---|
1881 | // the time in our case so instead we force a detachment here:
|
---|
1882 | // remove from machine data
|
---|
1883 | mMediaData->mAttachments.remove(pAttach);
|
---|
1884 | // remove it from the backup or else saveSettings will try to detach
|
---|
1885 | // it again and assert
|
---|
1886 | mMediaData.backedUpData()->mAttachments.remove(pAttach);
|
---|
1887 | // then clean up backrefs
|
---|
1888 | pMedium->detachFrom(mData->mUuid);
|
---|
1889 |
|
---|
1890 | llDiffsToDelete.push_back(pMedium);
|
---|
1891 | }
|
---|
1892 |
|
---|
1893 | // save machine settings, reset the modified flag and commit;
|
---|
1894 | rc = saveSettings(&fNeedsSaveSettings, SaveS_ResetCurStateModified | saveFlags);
|
---|
1895 | if (FAILED(rc))
|
---|
1896 | throw rc;
|
---|
1897 |
|
---|
1898 | // let go of the locks while we're deleting image files below
|
---|
1899 | alock.leave();
|
---|
1900 | // from here on we cannot roll back on failure any more
|
---|
1901 |
|
---|
1902 | for (MediaList::iterator it = llDiffsToDelete.begin();
|
---|
1903 | it != llDiffsToDelete.end();
|
---|
1904 | ++it)
|
---|
1905 | {
|
---|
1906 | ComObjPtr<Medium> &pMedium = *it;
|
---|
1907 | LogFlowThisFunc(("Deleting old current state in differencing image '%s'\n", pMedium->getName().raw()));
|
---|
1908 |
|
---|
1909 | HRESULT rc2 = pMedium->deleteStorage(NULL /* aProgress */,
|
---|
1910 | true /* aWait */,
|
---|
1911 | &fNeedsSaveSettings);
|
---|
1912 | // ignore errors here because we cannot roll back after saveSettings() above
|
---|
1913 | if (SUCCEEDED(rc2))
|
---|
1914 | pMedium->uninit();
|
---|
1915 | }
|
---|
1916 |
|
---|
1917 | if (fNeedsSaveSettings)
|
---|
1918 | {
|
---|
1919 | // finally, VirtualBox.xml needs saving too
|
---|
1920 | AutoWriteLock vboxLock(mParent COMMA_LOCKVAL_SRC_POS);
|
---|
1921 | mParent->saveSettings();
|
---|
1922 | }
|
---|
1923 | }
|
---|
1924 | catch (HRESULT aRC)
|
---|
1925 | {
|
---|
1926 | rc = aRC;
|
---|
1927 | }
|
---|
1928 |
|
---|
1929 | if (FAILED(rc))
|
---|
1930 | {
|
---|
1931 | /* preserve existing error info */
|
---|
1932 | ErrorInfoKeeper eik;
|
---|
1933 |
|
---|
1934 | /* undo all changes on failure */
|
---|
1935 | rollback(false /* aNotify */);
|
---|
1936 |
|
---|
1937 | if (!stateRestored)
|
---|
1938 | {
|
---|
1939 | /* restore the machine state */
|
---|
1940 | setMachineState(aTask.machineStateBackup);
|
---|
1941 | updateMachineStateOnClient();
|
---|
1942 | }
|
---|
1943 | }
|
---|
1944 |
|
---|
1945 | /* set the result (this will try to fetch current error info on failure) */
|
---|
1946 | aTask.pProgress->notifyComplete(rc);
|
---|
1947 |
|
---|
1948 | if (SUCCEEDED(rc))
|
---|
1949 | mParent->onSnapshotDeleted(mData->mUuid, Guid());
|
---|
1950 |
|
---|
1951 | LogFlowThisFunc(("Done restoring snapshot (rc=%08X)\n", rc));
|
---|
1952 |
|
---|
1953 | LogFlowThisFuncLeave();
|
---|
1954 | }
|
---|
1955 |
|
---|
1956 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1957 | //
|
---|
1958 | // DeleteSnapshot methods (SessionMachine and related tasks)
|
---|
1959 | //
|
---|
1960 | ////////////////////////////////////////////////////////////////////////////////
|
---|
1961 |
|
---|
1962 | /**
|
---|
1963 | * Implementation for IInternalMachineControl::deleteSnapshot().
|
---|
1964 | *
|
---|
1965 | * Gets called from Console::DeleteSnapshot(), and that's basically the
|
---|
1966 | * only thing Console does initially. Deleting a snapshot happens entirely on
|
---|
1967 | * the server side if the machine is not running, and if it is running then
|
---|
1968 | * the individual merges are done via internal session callbacks.
|
---|
1969 | *
|
---|
1970 | * This creates a new thread that does the work and returns a progress
|
---|
1971 | * object to the client which is then returned to the caller of
|
---|
1972 | * Console::DeleteSnapshot().
|
---|
1973 | *
|
---|
1974 | * Actual work then takes place in DeleteSnapshotTask::handler().
|
---|
1975 | *
|
---|
1976 | * @note Locks mParent + this + children objects for writing!
|
---|
1977 | */
|
---|
1978 | STDMETHODIMP SessionMachine::DeleteSnapshot(IConsole *aInitiator,
|
---|
1979 | IN_BSTR aId,
|
---|
1980 | MachineState_T *aMachineState,
|
---|
1981 | IProgress **aProgress)
|
---|
1982 | {
|
---|
1983 | LogFlowThisFuncEnter();
|
---|
1984 |
|
---|
1985 | Guid id(aId);
|
---|
1986 | AssertReturn(aInitiator && !id.isEmpty(), E_INVALIDARG);
|
---|
1987 | AssertReturn(aMachineState && aProgress, E_POINTER);
|
---|
1988 |
|
---|
1989 | AutoCaller autoCaller(this);
|
---|
1990 | AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
|
---|
1991 |
|
---|
1992 | AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
1993 |
|
---|
1994 | // be very picky about machine states
|
---|
1995 | if ( Global::IsOnlineOrTransient(mData->mMachineState)
|
---|
1996 | && mData->mMachineState != MachineState_PoweredOff
|
---|
1997 | && mData->mMachineState != MachineState_Saved
|
---|
1998 | && mData->mMachineState != MachineState_Teleported
|
---|
1999 | && mData->mMachineState != MachineState_Aborted
|
---|
2000 | && mData->mMachineState != MachineState_Running
|
---|
2001 | && mData->mMachineState != MachineState_Paused)
|
---|
2002 | return setError(VBOX_E_INVALID_VM_STATE,
|
---|
2003 | tr("Invalid machine state: %s"),
|
---|
2004 | Global::stringifyMachineState(mData->mMachineState));
|
---|
2005 |
|
---|
2006 | ComObjPtr<Snapshot> pSnapshot;
|
---|
2007 | HRESULT rc = findSnapshot(id, pSnapshot, true /* aSetError */);
|
---|
2008 | if (FAILED(rc)) return rc;
|
---|
2009 |
|
---|
2010 | AutoWriteLock snapshotLock(pSnapshot COMMA_LOCKVAL_SRC_POS);
|
---|
2011 |
|
---|
2012 | size_t childrenCount = pSnapshot->getChildrenCount();
|
---|
2013 | if (childrenCount > 1)
|
---|
2014 | return setError(VBOX_E_INVALID_OBJECT_STATE,
|
---|
2015 | tr("Snapshot '%s' of the machine '%ls' cannot be deleted. because it has %d child snapshots, which is more than the one snapshot allowed for deletion"),
|
---|
2016 | pSnapshot->getName().c_str(),
|
---|
2017 | mUserData->mName.raw(),
|
---|
2018 | childrenCount);
|
---|
2019 |
|
---|
2020 | /* If the snapshot being deleted is the current one, ensure current
|
---|
2021 | * settings are committed and saved.
|
---|
2022 | */
|
---|
2023 | if (pSnapshot == mData->mCurrentSnapshot)
|
---|
2024 | {
|
---|
2025 | if (mData->flModifications)
|
---|
2026 | {
|
---|
2027 | rc = saveSettings(NULL);
|
---|
2028 | // no need to change for whether VirtualBox.xml needs saving since
|
---|
2029 | // we can't have a machine XML rename pending at this point
|
---|
2030 | if (FAILED(rc)) return rc;
|
---|
2031 | }
|
---|
2032 | }
|
---|
2033 |
|
---|
2034 | ComObjPtr<SnapshotMachine> pSnapMachine = pSnapshot->getSnapshotMachine();
|
---|
2035 |
|
---|
2036 | /* create a progress object. The number of operations is:
|
---|
2037 | * 1 (preparing) + 1 if the snapshot is online + # of normal hard disks
|
---|
2038 | */
|
---|
2039 | LogFlowThisFunc(("Going thru snapshot machine attachments to determine progress setup\n"));
|
---|
2040 |
|
---|
2041 | ULONG ulOpCount = 1; // one for preparations
|
---|
2042 | ULONG ulTotalWeight = 1; // one for preparations
|
---|
2043 |
|
---|
2044 | if (pSnapshot->stateFilePath().length())
|
---|
2045 | {
|
---|
2046 | ++ulOpCount;
|
---|
2047 | ++ulTotalWeight; // assume 1 MB for deleting the state file
|
---|
2048 | }
|
---|
2049 |
|
---|
2050 | // count normal hard disks and add their sizes to the weight
|
---|
2051 | for (MediaData::AttachmentList::iterator it = pSnapMachine->mMediaData->mAttachments.begin();
|
---|
2052 | it != pSnapMachine->mMediaData->mAttachments.end();
|
---|
2053 | ++it)
|
---|
2054 | {
|
---|
2055 | ComObjPtr<MediumAttachment> &pAttach = *it;
|
---|
2056 | AutoReadLock attachLock(pAttach COMMA_LOCKVAL_SRC_POS);
|
---|
2057 | if (pAttach->getType() == DeviceType_HardDisk)
|
---|
2058 | {
|
---|
2059 | ComObjPtr<Medium> pHD = pAttach->getMedium();
|
---|
2060 | Assert(pHD);
|
---|
2061 | AutoReadLock mlock(pHD COMMA_LOCKVAL_SRC_POS);
|
---|
2062 |
|
---|
2063 | MediumType_T type = pHD->getType();
|
---|
2064 | if (type != MediumType_Writethrough) // writethrough images are unaffected by snapshots, so do nothing for them
|
---|
2065 | {
|
---|
2066 | // normal or immutable media need attention
|
---|
2067 | ++ulOpCount;
|
---|
2068 | ulTotalWeight += (ULONG)(pHD->getSize() / _1M);
|
---|
2069 | }
|
---|
2070 | LogFlowThisFunc(("op %d: considering hard disk attachment %s\n", ulOpCount, pHD->getName().c_str()));
|
---|
2071 | }
|
---|
2072 | }
|
---|
2073 |
|
---|
2074 | ComObjPtr<Progress> pProgress;
|
---|
2075 | pProgress.createObject();
|
---|
2076 | pProgress->init(mParent, aInitiator,
|
---|
2077 | BstrFmt(tr("Deleting snapshot '%s'"), pSnapshot->getName().c_str()),
|
---|
2078 | FALSE /* aCancelable */,
|
---|
2079 | ulOpCount,
|
---|
2080 | ulTotalWeight,
|
---|
2081 | Bstr(tr("Setting up")),
|
---|
2082 | 1);
|
---|
2083 |
|
---|
2084 | bool fDeleteOnline = ( (mData->mMachineState == MachineState_Running)
|
---|
2085 | || (mData->mMachineState == MachineState_Paused));
|
---|
2086 |
|
---|
2087 | /* create and start the task on a separate thread */
|
---|
2088 | DeleteSnapshotTask *task = new DeleteSnapshotTask(this, pProgress,
|
---|
2089 | fDeleteOnline, pSnapshot);
|
---|
2090 | int vrc = RTThreadCreate(NULL,
|
---|
2091 | taskHandler,
|
---|
2092 | (void*)task,
|
---|
2093 | 0,
|
---|
2094 | RTTHREADTYPE_MAIN_WORKER,
|
---|
2095 | 0,
|
---|
2096 | "DeleteSnapshot");
|
---|
2097 | if (RT_FAILURE(vrc))
|
---|
2098 | {
|
---|
2099 | delete task;
|
---|
2100 | return E_FAIL;
|
---|
2101 | }
|
---|
2102 |
|
---|
2103 | // the task might start running but will block on acquiring the machine's write lock
|
---|
2104 | // which we acquired above; once this function leaves, the task will be unblocked;
|
---|
2105 | // set the proper machine state here now (note: after creating a Task instance)
|
---|
2106 | if (mData->mMachineState == MachineState_Running)
|
---|
2107 | setMachineState(MachineState_DeletingSnapshotOnline);
|
---|
2108 | else if (mData->mMachineState == MachineState_Paused)
|
---|
2109 | setMachineState(MachineState_DeletingSnapshotPaused);
|
---|
2110 | else
|
---|
2111 | setMachineState(MachineState_DeletingSnapshot);
|
---|
2112 |
|
---|
2113 | /* return the progress to the caller */
|
---|
2114 | pProgress.queryInterfaceTo(aProgress);
|
---|
2115 |
|
---|
2116 | /* return the new state to the caller */
|
---|
2117 | *aMachineState = mData->mMachineState;
|
---|
2118 |
|
---|
2119 | LogFlowThisFuncLeave();
|
---|
2120 |
|
---|
2121 | return S_OK;
|
---|
2122 | }
|
---|
2123 |
|
---|
2124 | /**
|
---|
2125 | * Helper struct for SessionMachine::deleteSnapshotHandler().
|
---|
2126 | */
|
---|
2127 | struct MediumDeleteRec
|
---|
2128 | {
|
---|
2129 | MediumDeleteRec()
|
---|
2130 | : mfNeedsOnlineMerge(false),
|
---|
2131 | mpMediumLockList(NULL)
|
---|
2132 | {}
|
---|
2133 |
|
---|
2134 | MediumDeleteRec(const ComObjPtr<Medium> &aHd,
|
---|
2135 | const ComObjPtr<Medium> &aSource,
|
---|
2136 | const ComObjPtr<Medium> &aTarget,
|
---|
2137 | const ComObjPtr<MediumAttachment> &aOnlineMediumAttachment,
|
---|
2138 | bool fMergeForward,
|
---|
2139 | const ComObjPtr<Medium> &aParentForTarget,
|
---|
2140 | const MediaList &aChildrenToReparent,
|
---|
2141 | bool fNeedsOnlineMerge,
|
---|
2142 | MediumLockList *aMediumLockList)
|
---|
2143 | : mpHD(aHd),
|
---|
2144 | mpSource(aSource),
|
---|
2145 | mpTarget(aTarget),
|
---|
2146 | mpOnlineMediumAttachment(aOnlineMediumAttachment),
|
---|
2147 | mfMergeForward(fMergeForward),
|
---|
2148 | mpParentForTarget(aParentForTarget),
|
---|
2149 | mChildrenToReparent(aChildrenToReparent),
|
---|
2150 | mfNeedsOnlineMerge(fNeedsOnlineMerge),
|
---|
2151 | mpMediumLockList(aMediumLockList)
|
---|
2152 | {}
|
---|
2153 |
|
---|
2154 | MediumDeleteRec(const ComObjPtr<Medium> &aHd,
|
---|
2155 | const ComObjPtr<Medium> &aSource,
|
---|
2156 | const ComObjPtr<Medium> &aTarget,
|
---|
2157 | const ComObjPtr<MediumAttachment> &aOnlineMediumAttachment,
|
---|
2158 | bool fMergeForward,
|
---|
2159 | const ComObjPtr<Medium> &aParentForTarget,
|
---|
2160 | const MediaList &aChildrenToReparent,
|
---|
2161 | bool fNeedsOnlineMerge,
|
---|
2162 | MediumLockList *aMediumLockList,
|
---|
2163 | const Guid &aMachineId,
|
---|
2164 | const Guid &aSnapshotId)
|
---|
2165 | : mpHD(aHd),
|
---|
2166 | mpSource(aSource),
|
---|
2167 | mpTarget(aTarget),
|
---|
2168 | mpOnlineMediumAttachment(aOnlineMediumAttachment),
|
---|
2169 | mfMergeForward(fMergeForward),
|
---|
2170 | mpParentForTarget(aParentForTarget),
|
---|
2171 | mChildrenToReparent(aChildrenToReparent),
|
---|
2172 | mfNeedsOnlineMerge(fNeedsOnlineMerge),
|
---|
2173 | mpMediumLockList(aMediumLockList),
|
---|
2174 | mMachineId(aMachineId),
|
---|
2175 | mSnapshotId(aSnapshotId)
|
---|
2176 | {}
|
---|
2177 |
|
---|
2178 | ComObjPtr<Medium> mpHD;
|
---|
2179 | ComObjPtr<Medium> mpSource;
|
---|
2180 | ComObjPtr<Medium> mpTarget;
|
---|
2181 | ComObjPtr<MediumAttachment> mpOnlineMediumAttachment;
|
---|
2182 | bool mfMergeForward;
|
---|
2183 | ComObjPtr<Medium> mpParentForTarget;
|
---|
2184 | MediaList mChildrenToReparent;
|
---|
2185 | bool mfNeedsOnlineMerge;
|
---|
2186 | MediumLockList *mpMediumLockList;
|
---|
2187 | /* these are for reattaching the hard disk in case of a failure: */
|
---|
2188 | Guid mMachineId;
|
---|
2189 | Guid mSnapshotId;
|
---|
2190 | };
|
---|
2191 |
|
---|
2192 | typedef std::list<MediumDeleteRec> MediumDeleteRecList;
|
---|
2193 |
|
---|
2194 | /**
|
---|
2195 | * Worker method for the delete snapshot thread created by
|
---|
2196 | * SessionMachine::DeleteSnapshot(). This method gets called indirectly
|
---|
2197 | * through SessionMachine::taskHandler() which then calls
|
---|
2198 | * DeleteSnapshotTask::handler().
|
---|
2199 | *
|
---|
2200 | * The DeleteSnapshotTask contains the progress object returned to the console
|
---|
2201 | * by SessionMachine::DeleteSnapshot, through which progress and results are
|
---|
2202 | * reported.
|
---|
2203 | *
|
---|
2204 | * SessionMachine::DeleteSnapshot() has set the machne state to
|
---|
2205 | * MachineState_DeletingSnapshot right after creating this task. Since we block
|
---|
2206 | * on the machine write lock at the beginning, once that has been acquired, we
|
---|
2207 | * can assume that the machine state is indeed that.
|
---|
2208 | *
|
---|
2209 | * @note Locks the machine + the snapshot + the media tree for writing!
|
---|
2210 | *
|
---|
2211 | * @param aTask Task data.
|
---|
2212 | */
|
---|
2213 |
|
---|
2214 | void SessionMachine::deleteSnapshotHandler(DeleteSnapshotTask &aTask)
|
---|
2215 | {
|
---|
2216 | LogFlowThisFuncEnter();
|
---|
2217 |
|
---|
2218 | AutoCaller autoCaller(this);
|
---|
2219 |
|
---|
2220 | LogFlowThisFunc(("state=%d\n", autoCaller.state()));
|
---|
2221 | if (!autoCaller.isOk())
|
---|
2222 | {
|
---|
2223 | /* we might have been uninitialized because the session was accidentally
|
---|
2224 | * closed by the client, so don't assert */
|
---|
2225 | aTask.pProgress->notifyComplete(E_FAIL,
|
---|
2226 | COM_IIDOF(IMachine),
|
---|
2227 | getComponentName(),
|
---|
2228 | tr("The session has been accidentally closed"));
|
---|
2229 | LogFlowThisFuncLeave();
|
---|
2230 | return;
|
---|
2231 | }
|
---|
2232 |
|
---|
2233 | MediumDeleteRecList toDelete;
|
---|
2234 |
|
---|
2235 | HRESULT rc = S_OK;
|
---|
2236 |
|
---|
2237 | bool fMachineSettingsChanged = false; // Machine
|
---|
2238 | bool fNeedsSaveSettings = false; // VirtualBox.xml
|
---|
2239 |
|
---|
2240 | Guid snapshotId;
|
---|
2241 |
|
---|
2242 | try
|
---|
2243 | {
|
---|
2244 | /* Locking order: */
|
---|
2245 | AutoMultiWriteLock3 multiLock(this->lockHandle(), // machine
|
---|
2246 | aTask.pSnapshot->lockHandle(), // snapshot
|
---|
2247 | &mParent->getMediaTreeLockHandle() // media tree
|
---|
2248 | COMMA_LOCKVAL_SRC_POS);
|
---|
2249 | // once we have this lock, we know that SessionMachine::DeleteSnapshot()
|
---|
2250 | // has exited after setting the machine state to MachineState_DeletingSnapshot
|
---|
2251 |
|
---|
2252 | ComObjPtr<SnapshotMachine> pSnapMachine = aTask.pSnapshot->getSnapshotMachine();
|
---|
2253 | // no need to lock the snapshot machine since it is const by definiton
|
---|
2254 | Guid machineId = pSnapMachine->getId();
|
---|
2255 |
|
---|
2256 | // save the snapshot ID (for callbacks)
|
---|
2257 | snapshotId = aTask.pSnapshot->getId();
|
---|
2258 |
|
---|
2259 | // first pass:
|
---|
2260 | LogFlowThisFunc(("1: Checking hard disk merge prerequisites...\n"));
|
---|
2261 |
|
---|
2262 | // Go thru the attachments of the snapshot machine (the media in here
|
---|
2263 | // point to the disk states _before_ the snapshot was taken, i.e. the
|
---|
2264 | // state we're restoring to; for each such medium, we will need to
|
---|
2265 | // merge it with its one and only child (the diff image holding the
|
---|
2266 | // changes written after the snapshot was taken).
|
---|
2267 | for (MediaData::AttachmentList::iterator it = pSnapMachine->mMediaData->mAttachments.begin();
|
---|
2268 | it != pSnapMachine->mMediaData->mAttachments.end();
|
---|
2269 | ++it)
|
---|
2270 | {
|
---|
2271 | ComObjPtr<MediumAttachment> &pAttach = *it;
|
---|
2272 | AutoReadLock attachLock(pAttach COMMA_LOCKVAL_SRC_POS);
|
---|
2273 | if (pAttach->getType() != DeviceType_HardDisk)
|
---|
2274 | continue;
|
---|
2275 |
|
---|
2276 | ComObjPtr<Medium> pHD = pAttach->getMedium();
|
---|
2277 | Assert(!pHD.isNull());
|
---|
2278 |
|
---|
2279 | {
|
---|
2280 | // writethrough images are unaffected by snapshots, skip them
|
---|
2281 | AutoReadLock medlock(pHD COMMA_LOCKVAL_SRC_POS);
|
---|
2282 | MediumType_T type = pHD->getType();
|
---|
2283 | if (type == MediumType_Writethrough)
|
---|
2284 | continue;
|
---|
2285 | }
|
---|
2286 |
|
---|
2287 | #ifdef DEBUG
|
---|
2288 | pHD->dumpBackRefs();
|
---|
2289 | #endif
|
---|
2290 |
|
---|
2291 | // needs to be merged with child or deleted, check prerequisites
|
---|
2292 | ComObjPtr<Medium> pTarget;
|
---|
2293 | ComObjPtr<Medium> pSource;
|
---|
2294 | bool fMergeForward = false;
|
---|
2295 | ComObjPtr<Medium> pParentForTarget;
|
---|
2296 | MediaList childrenToReparent;
|
---|
2297 | bool fNeedsOnlineMerge = false;
|
---|
2298 | bool fOnlineMergePossible = aTask.m_fDeleteOnline;
|
---|
2299 | MediumLockList *pMediumLockList = NULL;
|
---|
2300 | MediumLockList *pVMMALockList = NULL;
|
---|
2301 | ComObjPtr<MediumAttachment> pOnlineMediumAttachment;
|
---|
2302 | if (fOnlineMergePossible)
|
---|
2303 | {
|
---|
2304 | // Look up the corresponding medium attachment in the currently
|
---|
2305 | // running VM. Any failure prevents a live merge. Could be made
|
---|
2306 | // a tad smarter by trying a few candidates, so that e.g. disks
|
---|
2307 | // which are simply moved to a different controller slot do not
|
---|
2308 | // prevent online merging in general.
|
---|
2309 | pOnlineMediumAttachment =
|
---|
2310 | findAttachment(mMediaData->mAttachments,
|
---|
2311 | pAttach->getControllerName(),
|
---|
2312 | pAttach->getPort(),
|
---|
2313 | pAttach->getDevice());
|
---|
2314 | if (pOnlineMediumAttachment)
|
---|
2315 | {
|
---|
2316 | rc = mData->mSession.mLockedMedia.Get(pOnlineMediumAttachment,
|
---|
2317 | pVMMALockList);
|
---|
2318 | if (FAILED(rc))
|
---|
2319 | fOnlineMergePossible = false;
|
---|
2320 | }
|
---|
2321 | else
|
---|
2322 | fOnlineMergePossible = false;
|
---|
2323 | }
|
---|
2324 | rc = prepareDeleteSnapshotMedium(pHD, machineId, snapshotId,
|
---|
2325 | fOnlineMergePossible,
|
---|
2326 | pVMMALockList, pSource, pTarget,
|
---|
2327 | fMergeForward, pParentForTarget,
|
---|
2328 | childrenToReparent,
|
---|
2329 | fNeedsOnlineMerge,
|
---|
2330 | pMediumLockList);
|
---|
2331 | if (FAILED(rc))
|
---|
2332 | throw rc;
|
---|
2333 |
|
---|
2334 | // no need to hold the lock any longer
|
---|
2335 | attachLock.release();
|
---|
2336 |
|
---|
2337 | // For simplicity, prepareDeleteSnapshotMedium selects the merge
|
---|
2338 | // direction in the following way: we merge pHD onto its child
|
---|
2339 | // (forward merge), not the other way round, because that saves us
|
---|
2340 | // from unnecessarily shuffling around the attachments for the
|
---|
2341 | // machine that follows the snapshot (next snapshot or current
|
---|
2342 | // state), unless it's a base image. Backwards merges of the first
|
---|
2343 | // snapshot into the base image is essential, as it ensures that
|
---|
2344 | // when all snapshots are deleted the only remaining image is a
|
---|
2345 | // base image. Important e.g. for medium formats which do not have
|
---|
2346 | // a file representation such as iSCSI.
|
---|
2347 |
|
---|
2348 | // a couple paranoia checks for backward merges
|
---|
2349 | if (pMediumLockList != NULL && !fMergeForward)
|
---|
2350 | {
|
---|
2351 | // parent is null -> this disk is a base hard disk: we will
|
---|
2352 | // then do a backward merge, i.e. merge its only child onto the
|
---|
2353 | // base disk. Here we need then to update the attachment that
|
---|
2354 | // refers to the child and have it point to the parent instead
|
---|
2355 | Assert(pHD->getParent().isNull());
|
---|
2356 | Assert(pHD->getChildren().size() == 1);
|
---|
2357 |
|
---|
2358 | ComObjPtr<Medium> pReplaceHD = pHD->getChildren().front();
|
---|
2359 |
|
---|
2360 | ComAssertThrow(pReplaceHD == pSource, E_FAIL);
|
---|
2361 | }
|
---|
2362 |
|
---|
2363 | Guid replaceMachineId;
|
---|
2364 | Guid replaceSnapshotId;
|
---|
2365 |
|
---|
2366 | const Guid *pReplaceMachineId = pSource->getFirstMachineBackrefId();
|
---|
2367 | // minimal sanity checking
|
---|
2368 | Assert(!pReplaceMachineId || *pReplaceMachineId == mData->mUuid);
|
---|
2369 | if (pReplaceMachineId)
|
---|
2370 | replaceMachineId = *pReplaceMachineId;
|
---|
2371 |
|
---|
2372 | const Guid *pSnapshotId = pSource->getFirstMachineBackrefSnapshotId();
|
---|
2373 | if (pSnapshotId)
|
---|
2374 | replaceSnapshotId = *pSnapshotId;
|
---|
2375 |
|
---|
2376 | if (!replaceMachineId.isEmpty())
|
---|
2377 | {
|
---|
2378 | // Adjust the backreferences, otherwise merging will assert.
|
---|
2379 | // Note that the medium attachment object stays associated
|
---|
2380 | // with the snapshot until the merge was successful.
|
---|
2381 | HRESULT rc2 = S_OK;
|
---|
2382 | rc2 = pSource->detachFrom(replaceMachineId, replaceSnapshotId);
|
---|
2383 | AssertComRC(rc2);
|
---|
2384 |
|
---|
2385 | toDelete.push_back(MediumDeleteRec(pHD, pSource, pTarget,
|
---|
2386 | pOnlineMediumAttachment,
|
---|
2387 | fMergeForward,
|
---|
2388 | pParentForTarget,
|
---|
2389 | childrenToReparent,
|
---|
2390 | fNeedsOnlineMerge,
|
---|
2391 | pMediumLockList,
|
---|
2392 | replaceMachineId,
|
---|
2393 | replaceSnapshotId));
|
---|
2394 | }
|
---|
2395 | else
|
---|
2396 | toDelete.push_back(MediumDeleteRec(pHD, pSource, pTarget,
|
---|
2397 | pOnlineMediumAttachment,
|
---|
2398 | fMergeForward,
|
---|
2399 | pParentForTarget,
|
---|
2400 | childrenToReparent,
|
---|
2401 | fNeedsOnlineMerge,
|
---|
2402 | pMediumLockList));
|
---|
2403 | }
|
---|
2404 |
|
---|
2405 | // we can release the lock now since the machine state is MachineState_DeletingSnapshot
|
---|
2406 | multiLock.release();
|
---|
2407 |
|
---|
2408 | /* Now we checked that we can successfully merge all normal hard disks
|
---|
2409 | * (unless a runtime error like end-of-disc happens). Now get rid of
|
---|
2410 | * the saved state (if present), as that will free some disk space.
|
---|
2411 | * The snapshot itself will be deleted as late as possible, so that
|
---|
2412 | * the user can repeat the delete operation if he runs out of disk
|
---|
2413 | * space or cancels the delete operation. */
|
---|
2414 |
|
---|
2415 | /* second pass: */
|
---|
2416 | LogFlowThisFunc(("2: Deleting saved state...\n"));
|
---|
2417 |
|
---|
2418 | {
|
---|
2419 | // saveAllSnapshots() needs a machine lock, and the snapshots
|
---|
2420 | // tree is protected by the machine lock as well
|
---|
2421 | AutoWriteLock machineLock(this COMMA_LOCKVAL_SRC_POS);
|
---|
2422 |
|
---|
2423 | Utf8Str stateFilePath = aTask.pSnapshot->stateFilePath();
|
---|
2424 | if (!stateFilePath.isEmpty())
|
---|
2425 | {
|
---|
2426 | aTask.pProgress->SetNextOperation(Bstr(tr("Deleting the execution state")),
|
---|
2427 | 1); // weight
|
---|
2428 |
|
---|
2429 | aTask.pSnapshot->deleteStateFile();
|
---|
2430 | fMachineSettingsChanged = true;
|
---|
2431 | }
|
---|
2432 | }
|
---|
2433 |
|
---|
2434 | /* third pass: */
|
---|
2435 | LogFlowThisFunc(("3: Performing actual hard disk merging...\n"));
|
---|
2436 |
|
---|
2437 | /// @todo NEWMEDIA turn the following errors into warnings because the
|
---|
2438 | /// snapshot itself has been already deleted (and interpret these
|
---|
2439 | /// warnings properly on the GUI side)
|
---|
2440 | for (MediumDeleteRecList::iterator it = toDelete.begin();
|
---|
2441 | it != toDelete.end();)
|
---|
2442 | {
|
---|
2443 | const ComObjPtr<Medium> &pMedium(it->mpHD);
|
---|
2444 | ULONG ulWeight;
|
---|
2445 |
|
---|
2446 | {
|
---|
2447 | AutoReadLock alock(pMedium COMMA_LOCKVAL_SRC_POS);
|
---|
2448 | ulWeight = (ULONG)(pMedium->getSize() / _1M);
|
---|
2449 | }
|
---|
2450 |
|
---|
2451 | aTask.pProgress->SetNextOperation(BstrFmt(tr("Merging differencing image '%s'"),
|
---|
2452 | pMedium->getName().raw()),
|
---|
2453 | ulWeight);
|
---|
2454 |
|
---|
2455 | bool fNeedSourceUninit = false;
|
---|
2456 | bool fReparentTarget = false;
|
---|
2457 | if (it->mpMediumLockList == NULL)
|
---|
2458 | {
|
---|
2459 | /* no real merge needed, just updating state and delete
|
---|
2460 | * diff files if necessary */
|
---|
2461 | AutoMultiWriteLock2 mLock(&mParent->getMediaTreeLockHandle(), pMedium->lockHandle() COMMA_LOCKVAL_SRC_POS);
|
---|
2462 |
|
---|
2463 | Assert( !it->mfMergeForward
|
---|
2464 | || pMedium->getChildren().size() == 0);
|
---|
2465 |
|
---|
2466 | /* Delete the differencing hard disk (has no children). Two
|
---|
2467 | * exceptions: if it's the last medium in the chain or if it's
|
---|
2468 | * a backward merge we don't want to handle due to complextity.
|
---|
2469 | * In both cases leave the image in place. If it's the first
|
---|
2470 | * exception the user can delete it later if he wants. */
|
---|
2471 | if (!pMedium->getParent().isNull())
|
---|
2472 | {
|
---|
2473 | Assert(pMedium->getState() == MediumState_Deleting);
|
---|
2474 | /* No need to hold the lock any longer. */
|
---|
2475 | mLock.release();
|
---|
2476 | rc = pMedium->deleteStorage(&aTask.pProgress,
|
---|
2477 | true /* aWait */,
|
---|
2478 | &fNeedsSaveSettings);
|
---|
2479 | if (FAILED(rc))
|
---|
2480 | throw rc;
|
---|
2481 |
|
---|
2482 | // need to uninit the deleted medium
|
---|
2483 | fNeedSourceUninit = true;
|
---|
2484 | }
|
---|
2485 | }
|
---|
2486 | else
|
---|
2487 | {
|
---|
2488 | if (it->mfNeedsOnlineMerge)
|
---|
2489 | {
|
---|
2490 | /// @todo VBoxHDD cannot handle backward merges where source==active disk yet
|
---|
2491 | // and as Console::onlineMergeMedium blocks all othert backward merges since
|
---|
2492 | // SessionMachine::FinishOnlineMergeMedium can't handle reparenting yet, block
|
---|
2493 | // here. Can be removed step by step.
|
---|
2494 | if (!it->mfMergeForward)
|
---|
2495 | throw setError(E_NOTIMPL,
|
---|
2496 | tr("Snapshot '%s' of the machine '%ls' cannot be deleted while a VM is running, as this case is not implemented yet. You can delete the snapshot when the VM is powered off"),
|
---|
2497 | aTask.pSnapshot->getName().c_str(),
|
---|
2498 | mUserData->mName.raw());
|
---|
2499 |
|
---|
2500 | // online medium merge, in the direction decided earlier
|
---|
2501 | rc = onlineMergeMedium(it->mpOnlineMediumAttachment,
|
---|
2502 | it->mpSource,
|
---|
2503 | it->mpTarget,
|
---|
2504 | it->mfMergeForward,
|
---|
2505 | it->mpParentForTarget,
|
---|
2506 | it->mChildrenToReparent,
|
---|
2507 | it->mpMediumLockList,
|
---|
2508 | aTask.pProgress,
|
---|
2509 | &fNeedsSaveSettings);
|
---|
2510 | }
|
---|
2511 | else
|
---|
2512 | {
|
---|
2513 | // normal medium merge, in the direction decided earlier
|
---|
2514 | rc = it->mpSource->mergeTo(it->mpTarget,
|
---|
2515 | it->mfMergeForward,
|
---|
2516 | it->mpParentForTarget,
|
---|
2517 | it->mChildrenToReparent,
|
---|
2518 | it->mpMediumLockList,
|
---|
2519 | &aTask.pProgress,
|
---|
2520 | true /* aWait */,
|
---|
2521 | &fNeedsSaveSettings);
|
---|
2522 | }
|
---|
2523 |
|
---|
2524 | if (FAILED(rc))
|
---|
2525 | throw rc;
|
---|
2526 |
|
---|
2527 | // need to change the medium attachment for backward merges
|
---|
2528 | fReparentTarget = !it->mfMergeForward;
|
---|
2529 |
|
---|
2530 | if (!it->mfNeedsOnlineMerge)
|
---|
2531 | {
|
---|
2532 | // need to uninit the medium deleted by the merge
|
---|
2533 | fNeedSourceUninit = true;
|
---|
2534 |
|
---|
2535 | // delete the no longer needed medium lock list, which
|
---|
2536 | // implicitly handled the unlocking
|
---|
2537 | delete it->mpMediumLockList;
|
---|
2538 | it->mpMediumLockList = NULL;
|
---|
2539 | }
|
---|
2540 | }
|
---|
2541 |
|
---|
2542 | // Now that the medium is successfully merged/deleted/whatever,
|
---|
2543 | // remove the medium attachment from the snapshot. For a backwards
|
---|
2544 | // merge the target attachment needs to be removed from the
|
---|
2545 | // snapshot, as the VM will take it over. For forward merges the
|
---|
2546 | // source medium attachment needs to be removed.
|
---|
2547 | ComObjPtr<MediumAttachment> pAtt;
|
---|
2548 | if (fReparentTarget)
|
---|
2549 | {
|
---|
2550 | pAtt = findAttachment(pSnapMachine->mMediaData->mAttachments,
|
---|
2551 | it->mpTarget);
|
---|
2552 | it->mpTarget->detachFrom(machineId, snapshotId);
|
---|
2553 | }
|
---|
2554 | else
|
---|
2555 | pAtt = findAttachment(pSnapMachine->mMediaData->mAttachments,
|
---|
2556 | it->mpSource);
|
---|
2557 | pSnapMachine->mMediaData->mAttachments.remove(pAtt);
|
---|
2558 |
|
---|
2559 | if (fReparentTarget)
|
---|
2560 | {
|
---|
2561 | // Search for old source attachment and replace with target.
|
---|
2562 | // There can be only one child snapshot in this case.
|
---|
2563 | ComObjPtr<Machine> pMachine = this;
|
---|
2564 | Guid childSnapshotId;
|
---|
2565 | ComObjPtr<Snapshot> pChildSnapshot = aTask.pSnapshot->getFirstChild();
|
---|
2566 | if (pChildSnapshot)
|
---|
2567 | {
|
---|
2568 | pMachine = pChildSnapshot->getSnapshotMachine();
|
---|
2569 | childSnapshotId = pChildSnapshot->getId();
|
---|
2570 | }
|
---|
2571 | pAtt = findAttachment(pMachine->mMediaData->mAttachments, it->mpSource);
|
---|
2572 | // If no attachment is found do not change anything. The source
|
---|
2573 | // medium might not have been attached to the snapshot.
|
---|
2574 | if (pAtt)
|
---|
2575 | {
|
---|
2576 | AutoWriteLock attLock(pAtt COMMA_LOCKVAL_SRC_POS);
|
---|
2577 | pAtt->updateMedium(it->mpTarget, false /* aImplicit */);
|
---|
2578 | it->mpTarget->attachTo(pMachine->mData->mUuid, childSnapshotId);
|
---|
2579 | }
|
---|
2580 | }
|
---|
2581 |
|
---|
2582 | if (fNeedSourceUninit)
|
---|
2583 | it->mpSource->uninit();
|
---|
2584 |
|
---|
2585 | // One attachment is merged, must save the settings
|
---|
2586 | fMachineSettingsChanged = true;
|
---|
2587 |
|
---|
2588 | /* prevent from calling cancelDeleteSnapshotMedium() */
|
---|
2589 | it = toDelete.erase(it);
|
---|
2590 | }
|
---|
2591 |
|
---|
2592 | {
|
---|
2593 | // beginSnapshotDelete() needs the machine lock, and the snapshots
|
---|
2594 | // tree is protected by the machine lock as well
|
---|
2595 | AutoWriteLock machineLock(this COMMA_LOCKVAL_SRC_POS);
|
---|
2596 |
|
---|
2597 | aTask.pSnapshot->beginSnapshotDelete();
|
---|
2598 | aTask.pSnapshot->uninit();
|
---|
2599 |
|
---|
2600 | fMachineSettingsChanged = true;
|
---|
2601 | }
|
---|
2602 | }
|
---|
2603 | catch (HRESULT aRC) { rc = aRC; }
|
---|
2604 |
|
---|
2605 | if (FAILED(rc))
|
---|
2606 | {
|
---|
2607 | // preserve existing error info so that the result can
|
---|
2608 | // be properly reported to the progress object below
|
---|
2609 | ErrorInfoKeeper eik;
|
---|
2610 |
|
---|
2611 | AutoMultiWriteLock2 multiLock(this->lockHandle(), // machine
|
---|
2612 | &mParent->getMediaTreeLockHandle() // media tree
|
---|
2613 | COMMA_LOCKVAL_SRC_POS);
|
---|
2614 |
|
---|
2615 | // un-prepare the remaining hard disks
|
---|
2616 | for (MediumDeleteRecList::const_iterator it = toDelete.begin();
|
---|
2617 | it != toDelete.end();
|
---|
2618 | ++it)
|
---|
2619 | {
|
---|
2620 | cancelDeleteSnapshotMedium(it->mpHD, it->mpSource,
|
---|
2621 | it->mChildrenToReparent,
|
---|
2622 | it->mfNeedsOnlineMerge,
|
---|
2623 | it->mpMediumLockList, it->mMachineId,
|
---|
2624 | it->mSnapshotId);
|
---|
2625 | }
|
---|
2626 | }
|
---|
2627 |
|
---|
2628 | // whether we were successful or not, we need to set the machine
|
---|
2629 | // state and save the machine settings;
|
---|
2630 | {
|
---|
2631 | // preserve existing error info so that the result can
|
---|
2632 | // be properly reported to the progress object below
|
---|
2633 | ErrorInfoKeeper eik;
|
---|
2634 |
|
---|
2635 | // restore the machine state that was saved when the
|
---|
2636 | // task was started
|
---|
2637 | setMachineState(aTask.machineStateBackup);
|
---|
2638 | updateMachineStateOnClient();
|
---|
2639 |
|
---|
2640 | if (fMachineSettingsChanged || fNeedsSaveSettings)
|
---|
2641 | {
|
---|
2642 | if (fMachineSettingsChanged)
|
---|
2643 | {
|
---|
2644 | AutoWriteLock machineLock(this COMMA_LOCKVAL_SRC_POS);
|
---|
2645 | saveSettings(&fNeedsSaveSettings, SaveS_InformCallbacksAnyway);
|
---|
2646 | }
|
---|
2647 |
|
---|
2648 | if (fNeedsSaveSettings)
|
---|
2649 | {
|
---|
2650 | AutoWriteLock vboxLock(mParent COMMA_LOCKVAL_SRC_POS);
|
---|
2651 | mParent->saveSettings();
|
---|
2652 | }
|
---|
2653 | }
|
---|
2654 | }
|
---|
2655 |
|
---|
2656 | // report the result (this will try to fetch current error info on failure)
|
---|
2657 | aTask.pProgress->notifyComplete(rc);
|
---|
2658 |
|
---|
2659 | if (SUCCEEDED(rc))
|
---|
2660 | mParent->onSnapshotDeleted(mData->mUuid, snapshotId);
|
---|
2661 |
|
---|
2662 | LogFlowThisFunc(("Done deleting snapshot (rc=%08X)\n", rc));
|
---|
2663 | LogFlowThisFuncLeave();
|
---|
2664 | }
|
---|
2665 |
|
---|
2666 | /**
|
---|
2667 | * Checks that this hard disk (part of a snapshot) may be deleted/merged and
|
---|
2668 | * performs necessary state changes. Must not be called for writethrough disks
|
---|
2669 | * because there is nothing to delete/merge then.
|
---|
2670 | *
|
---|
2671 | * This method is to be called prior to calling #deleteSnapshotMedium().
|
---|
2672 | * If #deleteSnapshotMedium() is not called or fails, the state modifications
|
---|
2673 | * performed by this method must be undone by #cancelDeleteSnapshotMedium().
|
---|
2674 | *
|
---|
2675 | * @return COM status code
|
---|
2676 | * @param aHD Hard disk which is connected to the snapshot.
|
---|
2677 | * @param aMachineId UUID of machine this hard disk is attached to.
|
---|
2678 | * @param aSnapshotId UUID of snapshot this hard disk is attached to. May
|
---|
2679 | * be a zero UUID if no snapshot is applicable.
|
---|
2680 | * @param fOnlineMergePossible Flag whether an online merge is possible.
|
---|
2681 | * @param aVMMALockList Medium lock list for the medium attachment of this VM.
|
---|
2682 | * Only used if @a fOnlineMergePossible is @c true, and
|
---|
2683 | * must be non-NULL in this case.
|
---|
2684 | * @param aSource Source hard disk for merge (out).
|
---|
2685 | * @param aTarget Target hard disk for merge (out).
|
---|
2686 | * @param aMergeForward Merge direction decision (out).
|
---|
2687 | * @param aParentForTarget New parent if target needs to be reparented (out).
|
---|
2688 | * @param aChildrenToReparent Children which have to be reparented to the
|
---|
2689 | * target (out).
|
---|
2690 | * @param fNeedsOnlineMerge Whether this merge needs to be done online (out).
|
---|
2691 | * If this is set to @a true then the @a aVMMALockList
|
---|
2692 | * parameter has been modified and is returned as
|
---|
2693 | * @a aMediumLockList.
|
---|
2694 | * @param aMediumLockList Where to store the created medium lock list (may
|
---|
2695 | * return NULL if no real merge is necessary).
|
---|
2696 | *
|
---|
2697 | * @note Caller must hold media tree lock for writing. This locks this object
|
---|
2698 | * and every medium object on the merge chain for writing.
|
---|
2699 | */
|
---|
2700 | HRESULT SessionMachine::prepareDeleteSnapshotMedium(const ComObjPtr<Medium> &aHD,
|
---|
2701 | const Guid &aMachineId,
|
---|
2702 | const Guid &aSnapshotId,
|
---|
2703 | bool fOnlineMergePossible,
|
---|
2704 | MediumLockList *aVMMALockList,
|
---|
2705 | ComObjPtr<Medium> &aSource,
|
---|
2706 | ComObjPtr<Medium> &aTarget,
|
---|
2707 | bool &aMergeForward,
|
---|
2708 | ComObjPtr<Medium> &aParentForTarget,
|
---|
2709 | MediaList &aChildrenToReparent,
|
---|
2710 | bool &fNeedsOnlineMerge,
|
---|
2711 | MediumLockList * &aMediumLockList)
|
---|
2712 | {
|
---|
2713 | Assert(mParent->getMediaTreeLockHandle().isWriteLockOnCurrentThread());
|
---|
2714 | Assert(!fOnlineMergePossible || VALID_PTR(aVMMALockList));
|
---|
2715 |
|
---|
2716 | AutoWriteLock alock(aHD COMMA_LOCKVAL_SRC_POS);
|
---|
2717 |
|
---|
2718 | // Medium must not be writethrough at this point
|
---|
2719 | AssertReturn(aHD->getType() != MediumType_Writethrough, E_FAIL);
|
---|
2720 |
|
---|
2721 | aMediumLockList = NULL;
|
---|
2722 | fNeedsOnlineMerge = false;
|
---|
2723 |
|
---|
2724 | if (aHD->getChildren().size() == 0)
|
---|
2725 | {
|
---|
2726 | /* This technically is no merge, set those values nevertheless.
|
---|
2727 | * Helps with updating the medium attachments. */
|
---|
2728 | aSource = aHD;
|
---|
2729 | aTarget = aHD;
|
---|
2730 |
|
---|
2731 | /* special treatment of the last hard disk in the chain: */
|
---|
2732 | if (aHD->getParent().isNull())
|
---|
2733 | {
|
---|
2734 | /* lock only, to prevent any usage until the snapshot deletion
|
---|
2735 | * is completed */
|
---|
2736 | return aHD->LockWrite(NULL);
|
---|
2737 | }
|
---|
2738 |
|
---|
2739 | /* the differencing hard disk w/o children will be deleted, protect it
|
---|
2740 | * from attaching to other VMs (this is why Deleting) */
|
---|
2741 | return aHD->markForDeletion();
|
---|
2742 | }
|
---|
2743 |
|
---|
2744 | /* not going multi-merge as it's too expensive */
|
---|
2745 | if (aHD->getChildren().size() > 1)
|
---|
2746 | return setError(E_FAIL,
|
---|
2747 | tr("Hard disk '%s' has more than one child hard disk (%d)"),
|
---|
2748 | aHD->getLocationFull().raw(),
|
---|
2749 | aHD->getChildren().size());
|
---|
2750 |
|
---|
2751 | ComObjPtr<Medium> pChild = aHD->getChildren().front();
|
---|
2752 |
|
---|
2753 | /* we keep this locked, so lock the affected child to make sure the lock
|
---|
2754 | * order is correct when calling prepareMergeTo() */
|
---|
2755 | AutoWriteLock childLock(pChild COMMA_LOCKVAL_SRC_POS);
|
---|
2756 |
|
---|
2757 | /* the rest is a normal merge setup */
|
---|
2758 | if (aHD->getParent().isNull())
|
---|
2759 | {
|
---|
2760 | /* base hard disk, backward merge */
|
---|
2761 | const Guid *pMachineId1 = pChild->getFirstMachineBackrefId();
|
---|
2762 | const Guid *pMachineId2 = aHD->getFirstMachineBackrefId();
|
---|
2763 | if (pMachineId1 && pMachineId2 && *pMachineId1 != *pMachineId2)
|
---|
2764 | {
|
---|
2765 | /* backward merge is too tricky, we'll just detach on snapshot
|
---|
2766 | * deletion, so lock only, to prevent any usage */
|
---|
2767 | return aHD->LockWrite(NULL);
|
---|
2768 | }
|
---|
2769 |
|
---|
2770 | aSource = pChild;
|
---|
2771 | aTarget = aHD;
|
---|
2772 | }
|
---|
2773 | else
|
---|
2774 | {
|
---|
2775 | /* forward merge */
|
---|
2776 | aSource = aHD;
|
---|
2777 | aTarget = pChild;
|
---|
2778 | }
|
---|
2779 |
|
---|
2780 | HRESULT rc;
|
---|
2781 | rc = aSource->prepareMergeTo(aTarget, &aMachineId, &aSnapshotId,
|
---|
2782 | !fOnlineMergePossible /* fLockMedia */,
|
---|
2783 | aMergeForward, aParentForTarget,
|
---|
2784 | aChildrenToReparent, aMediumLockList);
|
---|
2785 | if (SUCCEEDED(rc) && fOnlineMergePossible)
|
---|
2786 | {
|
---|
2787 | /* Try to lock the newly constructed medium lock list. If it succeeds
|
---|
2788 | * this can be handled as an offline merge, i.e. without the need of
|
---|
2789 | * asking the VM to do the merging. Only continue with the online
|
---|
2790 | * merging preparation if applicable. */
|
---|
2791 | rc = aMediumLockList->Lock();
|
---|
2792 | if (FAILED(rc) && fOnlineMergePossible)
|
---|
2793 | {
|
---|
2794 | /* Locking failed, this cannot be done as an offline merge. Try to
|
---|
2795 | * combine the locking information into the lock list of the medium
|
---|
2796 | * attachment in the running VM. If that fails or locking the
|
---|
2797 | * resulting lock list fails then the merge cannot be done online.
|
---|
2798 | * It can be repeated by the user when the VM is shut down. */
|
---|
2799 | MediumLockList::Base::iterator lockListVMMABegin =
|
---|
2800 | aVMMALockList->GetBegin();
|
---|
2801 | MediumLockList::Base::iterator lockListVMMAEnd =
|
---|
2802 | aVMMALockList->GetEnd();
|
---|
2803 | MediumLockList::Base::iterator lockListBegin =
|
---|
2804 | aMediumLockList->GetBegin();
|
---|
2805 | MediumLockList::Base::iterator lockListEnd =
|
---|
2806 | aMediumLockList->GetEnd();
|
---|
2807 | for (MediumLockList::Base::iterator it = lockListVMMABegin,
|
---|
2808 | it2 = lockListBegin;
|
---|
2809 | it2 != lockListEnd;
|
---|
2810 | ++it, ++it2)
|
---|
2811 | {
|
---|
2812 | if ( it == lockListVMMAEnd
|
---|
2813 | || it->GetMedium() != it2->GetMedium())
|
---|
2814 | {
|
---|
2815 | fOnlineMergePossible = false;
|
---|
2816 | break;
|
---|
2817 | }
|
---|
2818 | bool fLockReq = (it2->GetLockRequest() || it->GetLockRequest());
|
---|
2819 | rc = it->UpdateLock(fLockReq);
|
---|
2820 | if (FAILED(rc))
|
---|
2821 | {
|
---|
2822 | // could not update the lock, trigger cleanup below
|
---|
2823 | fOnlineMergePossible = false;
|
---|
2824 | break;
|
---|
2825 | }
|
---|
2826 | }
|
---|
2827 |
|
---|
2828 | if (fOnlineMergePossible)
|
---|
2829 | {
|
---|
2830 | /* we will lock the children of the source for reparenting */
|
---|
2831 | for (MediaList::const_iterator it = aChildrenToReparent.begin();
|
---|
2832 | it != aChildrenToReparent.end();
|
---|
2833 | ++it)
|
---|
2834 | {
|
---|
2835 | ComObjPtr<Medium> pMedium = *it;
|
---|
2836 | if (pMedium->getState() == MediumState_Created)
|
---|
2837 | {
|
---|
2838 | rc = pMedium->LockWrite(NULL);
|
---|
2839 | if (FAILED(rc))
|
---|
2840 | throw rc;
|
---|
2841 | }
|
---|
2842 | else
|
---|
2843 | {
|
---|
2844 | rc = aVMMALockList->Update(pMedium, true);
|
---|
2845 | if (FAILED(rc))
|
---|
2846 | {
|
---|
2847 | rc = pMedium->LockWrite(NULL);
|
---|
2848 | if (FAILED(rc))
|
---|
2849 | throw rc;
|
---|
2850 | }
|
---|
2851 | }
|
---|
2852 | }
|
---|
2853 | }
|
---|
2854 |
|
---|
2855 | if (fOnlineMergePossible)
|
---|
2856 | {
|
---|
2857 | rc = aVMMALockList->Lock();
|
---|
2858 | if (FAILED(rc))
|
---|
2859 | {
|
---|
2860 | aSource->cancelMergeTo(aChildrenToReparent, aMediumLockList);
|
---|
2861 | rc = setError(rc,
|
---|
2862 | tr("Cannot lock hard disk '%s' for a live merge"),
|
---|
2863 | aHD->getLocationFull().raw());
|
---|
2864 | }
|
---|
2865 | else
|
---|
2866 | {
|
---|
2867 | delete aMediumLockList;
|
---|
2868 | aMediumLockList = aVMMALockList;
|
---|
2869 | fNeedsOnlineMerge = true;
|
---|
2870 | }
|
---|
2871 | }
|
---|
2872 | else
|
---|
2873 | {
|
---|
2874 | aSource->cancelMergeTo(aChildrenToReparent, aMediumLockList);
|
---|
2875 | rc = setError(rc,
|
---|
2876 | tr("Failed to construct lock list for a live merge of hard disk '%s'"),
|
---|
2877 | aHD->getLocationFull().raw());
|
---|
2878 | }
|
---|
2879 |
|
---|
2880 | // fix the VM's lock list if anything failed
|
---|
2881 | if (FAILED(rc))
|
---|
2882 | {
|
---|
2883 | lockListVMMABegin = aVMMALockList->GetBegin();
|
---|
2884 | lockListVMMAEnd = aVMMALockList->GetEnd();
|
---|
2885 | MediumLockList::Base::iterator lockListLast = lockListVMMAEnd;
|
---|
2886 | lockListLast--;
|
---|
2887 | for (MediumLockList::Base::iterator it = lockListVMMABegin;
|
---|
2888 | it != lockListVMMAEnd;
|
---|
2889 | ++it)
|
---|
2890 | {
|
---|
2891 | it->UpdateLock(it == lockListLast);
|
---|
2892 | ComObjPtr<Medium> pMedium = it->GetMedium();
|
---|
2893 | AutoWriteLock mediumLock(pMedium COMMA_LOCKVAL_SRC_POS);
|
---|
2894 | // blindly apply this, only needed for medium objects which
|
---|
2895 | // would be deleted as part of the merge
|
---|
2896 | pMedium->unmarkLockedForDeletion();
|
---|
2897 | }
|
---|
2898 | }
|
---|
2899 |
|
---|
2900 | }
|
---|
2901 | else
|
---|
2902 | {
|
---|
2903 | aSource->cancelMergeTo(aChildrenToReparent, aMediumLockList);
|
---|
2904 | rc = setError(rc,
|
---|
2905 | tr("Cannot lock hard disk '%s' for an offline merge"),
|
---|
2906 | aHD->getLocationFull().raw());
|
---|
2907 | }
|
---|
2908 | }
|
---|
2909 |
|
---|
2910 | return rc;
|
---|
2911 | }
|
---|
2912 |
|
---|
2913 | /**
|
---|
2914 | * Cancels the deletion/merging of this hard disk (part of a snapshot). Undoes
|
---|
2915 | * what #prepareDeleteSnapshotMedium() did. Must be called if
|
---|
2916 | * #deleteSnapshotMedium() is not called or fails.
|
---|
2917 | *
|
---|
2918 | * @param aHD Hard disk which is connected to the snapshot.
|
---|
2919 | * @param aSource Source hard disk for merge.
|
---|
2920 | * @param aChildrenToReparent Children to unlock.
|
---|
2921 | * @param fNeedsOnlineMerge Whether this merge needs to be done online.
|
---|
2922 | * @param aMediumLockList Medium locks to cancel.
|
---|
2923 | * @param aMachineId Machine id to attach the medium to.
|
---|
2924 | * @param aSnapshotId Snapshot id to attach the medium to.
|
---|
2925 | *
|
---|
2926 | * @note Locks the medium tree and the hard disks in the chain for writing.
|
---|
2927 | */
|
---|
2928 | void SessionMachine::cancelDeleteSnapshotMedium(const ComObjPtr<Medium> &aHD,
|
---|
2929 | const ComObjPtr<Medium> &aSource,
|
---|
2930 | const MediaList &aChildrenToReparent,
|
---|
2931 | bool fNeedsOnlineMerge,
|
---|
2932 | MediumLockList *aMediumLockList,
|
---|
2933 | const Guid &aMachineId,
|
---|
2934 | const Guid &aSnapshotId)
|
---|
2935 | {
|
---|
2936 | if (aMediumLockList == NULL)
|
---|
2937 | {
|
---|
2938 | AutoMultiWriteLock2 mLock(&mParent->getMediaTreeLockHandle(), aHD->lockHandle() COMMA_LOCKVAL_SRC_POS);
|
---|
2939 |
|
---|
2940 | Assert(aHD->getChildren().size() == 0);
|
---|
2941 |
|
---|
2942 | if (aHD->getParent().isNull())
|
---|
2943 | {
|
---|
2944 | HRESULT rc = aHD->UnlockWrite(NULL);;
|
---|
2945 | AssertComRC(rc);
|
---|
2946 | }
|
---|
2947 | else
|
---|
2948 | {
|
---|
2949 | HRESULT rc = aHD->unmarkForDeletion();
|
---|
2950 | AssertComRC(rc);
|
---|
2951 | }
|
---|
2952 | }
|
---|
2953 | else
|
---|
2954 | {
|
---|
2955 | if (fNeedsOnlineMerge)
|
---|
2956 | {
|
---|
2957 | // Online merge uses the medium lock list of the VM, so give
|
---|
2958 | // an empty list to cancelMergeTo so that it works as designed.
|
---|
2959 | aSource->cancelMergeTo(aChildrenToReparent, new MediumLockList());
|
---|
2960 |
|
---|
2961 | // clean up the VM medium lock list ourselves
|
---|
2962 | MediumLockList::Base::iterator lockListBegin =
|
---|
2963 | aMediumLockList->GetBegin();
|
---|
2964 | MediumLockList::Base::iterator lockListEnd =
|
---|
2965 | aMediumLockList->GetEnd();
|
---|
2966 | MediumLockList::Base::iterator lockListLast = lockListEnd;
|
---|
2967 | lockListLast--;
|
---|
2968 | for (MediumLockList::Base::iterator it = lockListBegin;
|
---|
2969 | it != lockListEnd;
|
---|
2970 | ++it)
|
---|
2971 | {
|
---|
2972 | ComObjPtr<Medium> pMedium = it->GetMedium();
|
---|
2973 | AutoWriteLock mediumLock(pMedium COMMA_LOCKVAL_SRC_POS);
|
---|
2974 | if (pMedium->getState() == MediumState_Deleting)
|
---|
2975 | pMedium->unmarkForDeletion();
|
---|
2976 | else
|
---|
2977 | {
|
---|
2978 | // blindly apply this, only needed for medium objects which
|
---|
2979 | // would be deleted as part of the merge
|
---|
2980 | pMedium->unmarkLockedForDeletion();
|
---|
2981 | }
|
---|
2982 | it->UpdateLock(it == lockListLast);
|
---|
2983 | }
|
---|
2984 | }
|
---|
2985 | else
|
---|
2986 | {
|
---|
2987 | aSource->cancelMergeTo(aChildrenToReparent, aMediumLockList);
|
---|
2988 | }
|
---|
2989 | }
|
---|
2990 |
|
---|
2991 | if (!aMachineId.isEmpty())
|
---|
2992 | {
|
---|
2993 | // reattach the source media to the snapshot
|
---|
2994 | HRESULT rc = aSource->attachTo(aMachineId, aSnapshotId);
|
---|
2995 | AssertComRC(rc);
|
---|
2996 | }
|
---|
2997 | }
|
---|
2998 |
|
---|
2999 | /**
|
---|
3000 | * Perform an online merge of a hard disk, i.e. the equivalent of
|
---|
3001 | * Medium::mergeTo(), just for running VMs. If this fails you need to call
|
---|
3002 | * #cancelDeleteSnapshotMedium().
|
---|
3003 | *
|
---|
3004 | * @return COM status code
|
---|
3005 | * @param aMediumAttachment Identify where the disk is attached in the VM.
|
---|
3006 | * @param aSource Source hard disk for merge.
|
---|
3007 | * @param aTarget Target hard disk for merge.
|
---|
3008 | * @param aMergeForward Merge direction.
|
---|
3009 | * @param aParentForTarget New parent if target needs to be reparented.
|
---|
3010 | * @param aChildrenToReparent Children which have to be reparented to the
|
---|
3011 | * target.
|
---|
3012 | * @param aMediumLockList Where to store the created medium lock list (may
|
---|
3013 | * return NULL if no real merge is necessary).
|
---|
3014 | * @param aProgress Progress indicator.
|
---|
3015 | * @param pfNeedsSaveSettings Whether the VM settings need to be saved (out).
|
---|
3016 | */
|
---|
3017 | HRESULT SessionMachine::onlineMergeMedium(const ComObjPtr<MediumAttachment> &aMediumAttachment,
|
---|
3018 | const ComObjPtr<Medium> &aSource,
|
---|
3019 | const ComObjPtr<Medium> &aTarget,
|
---|
3020 | bool fMergeForward,
|
---|
3021 | const ComObjPtr<Medium> &aParentForTarget,
|
---|
3022 | const MediaList &aChildrenToReparent,
|
---|
3023 | MediumLockList *aMediumLockList,
|
---|
3024 | ComObjPtr<Progress> &aProgress,
|
---|
3025 | bool *pfNeedsSaveSettings)
|
---|
3026 | {
|
---|
3027 | AssertReturn(aSource != NULL, E_FAIL);
|
---|
3028 | AssertReturn(aTarget != NULL, E_FAIL);
|
---|
3029 | AssertReturn(aSource != aTarget, E_FAIL);
|
---|
3030 | AssertReturn(aMediumLockList != NULL, E_FAIL);
|
---|
3031 |
|
---|
3032 | HRESULT rc = S_OK;
|
---|
3033 |
|
---|
3034 | try
|
---|
3035 | {
|
---|
3036 | // Similar code appears in Medium::taskMergeHandle, so
|
---|
3037 | // if you make any changes below check whether they are applicable
|
---|
3038 | // in that context as well.
|
---|
3039 |
|
---|
3040 | unsigned uTargetIdx = (unsigned)-1;
|
---|
3041 | unsigned uSourceIdx = (unsigned)-1;
|
---|
3042 | /* Sanity check all hard disks in the chain. */
|
---|
3043 | MediumLockList::Base::iterator lockListBegin =
|
---|
3044 | aMediumLockList->GetBegin();
|
---|
3045 | MediumLockList::Base::iterator lockListEnd =
|
---|
3046 | aMediumLockList->GetEnd();
|
---|
3047 | unsigned i = 0;
|
---|
3048 | for (MediumLockList::Base::iterator it = lockListBegin;
|
---|
3049 | it != lockListEnd;
|
---|
3050 | ++it)
|
---|
3051 | {
|
---|
3052 | MediumLock &mediumLock = *it;
|
---|
3053 | const ComObjPtr<Medium> &pMedium = mediumLock.GetMedium();
|
---|
3054 |
|
---|
3055 | if (pMedium == aSource)
|
---|
3056 | uSourceIdx = i;
|
---|
3057 | else if (pMedium == aTarget)
|
---|
3058 | uTargetIdx = i;
|
---|
3059 |
|
---|
3060 | // In Medium::taskMergeHandler there is lots of consistency
|
---|
3061 | // checking which we cannot do here, as the state details are
|
---|
3062 | // impossible to get outside the Medium class. The locking should
|
---|
3063 | // have done the checks already.
|
---|
3064 |
|
---|
3065 | i++;
|
---|
3066 | }
|
---|
3067 |
|
---|
3068 | ComAssertThrow( uSourceIdx != (unsigned)-1
|
---|
3069 | && uTargetIdx != (unsigned)-1, E_FAIL);
|
---|
3070 |
|
---|
3071 | // For forward merges, tell the VM what images need to have their
|
---|
3072 | // parent UUID updated. This cannot be done in VBoxSVC, as opening
|
---|
3073 | // the required parent images is not safe while the VM is running.
|
---|
3074 | // For backward merges this will be simply an array of size 0.
|
---|
3075 | com::SafeIfaceArray<IMedium> childrenToReparent(aChildrenToReparent);
|
---|
3076 |
|
---|
3077 | ComPtr<IInternalSessionControl> directControl;
|
---|
3078 | {
|
---|
3079 | AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
|
---|
3080 |
|
---|
3081 | if (mData->mSession.mState != SessionState_Open)
|
---|
3082 | throw setError(VBOX_E_INVALID_VM_STATE,
|
---|
3083 | tr("Machine session is not open (session state: %s)"),
|
---|
3084 | Global::stringifySessionState(mData->mSession.mState));
|
---|
3085 | directControl = mData->mSession.mDirectControl;
|
---|
3086 | }
|
---|
3087 |
|
---|
3088 | // Must not hold any locks here, as this will call back to finish
|
---|
3089 | // updating the medium attachment, chain linking and state.
|
---|
3090 | rc = directControl->OnlineMergeMedium(aMediumAttachment,
|
---|
3091 | uSourceIdx, uTargetIdx,
|
---|
3092 | aSource, aTarget,
|
---|
3093 | fMergeForward, aParentForTarget,
|
---|
3094 | ComSafeArrayAsInParam(childrenToReparent),
|
---|
3095 | aProgress);
|
---|
3096 | if (FAILED(rc))
|
---|
3097 | throw rc;
|
---|
3098 | }
|
---|
3099 | catch (HRESULT aRC) { rc = aRC; }
|
---|
3100 |
|
---|
3101 | // The callback mentioned above takes care of update the medium state
|
---|
3102 |
|
---|
3103 | if (pfNeedsSaveSettings)
|
---|
3104 | *pfNeedsSaveSettings = true;
|
---|
3105 |
|
---|
3106 | return rc;
|
---|
3107 | }
|
---|
3108 |
|
---|
3109 | /**
|
---|
3110 | * Implementation for IInternalMachineControl::finishOnlineMergeMedium().
|
---|
3111 | *
|
---|
3112 | * Gets called after the successful completion of an online merge from
|
---|
3113 | * Console::onlineMergeMedium(), which gets invoked indirectly above in
|
---|
3114 | * the call to IInternalSessionControl::onlineMergeMedium.
|
---|
3115 | *
|
---|
3116 | * This updates the medium information and medium state so that the VM
|
---|
3117 | * can continue with the updated state of the medium chain.
|
---|
3118 | */
|
---|
3119 | STDMETHODIMP SessionMachine::FinishOnlineMergeMedium(IMediumAttachment *aMediumAttachment,
|
---|
3120 | IMedium *aSource,
|
---|
3121 | IMedium *aTarget,
|
---|
3122 | BOOL aMergeForward,
|
---|
3123 | IMedium *aParentForTarget,
|
---|
3124 | ComSafeArrayIn(IMedium *, aChildrenToReparent))
|
---|
3125 | {
|
---|
3126 | HRESULT rc = S_OK;
|
---|
3127 | ComObjPtr<Medium> pSource(static_cast<Medium *>(aSource));
|
---|
3128 | ComObjPtr<Medium> pTarget(static_cast<Medium *>(aTarget));
|
---|
3129 | ComObjPtr<Medium> pParentForTarget(static_cast<Medium *>(aParentForTarget));
|
---|
3130 |
|
---|
3131 | // all hard disks but the target were successfully deleted by
|
---|
3132 | // the merge; reparent target if necessary and uninitialize media
|
---|
3133 |
|
---|
3134 | AutoWriteLock treeLock(mParent->getMediaTreeLockHandle() COMMA_LOCKVAL_SRC_POS);
|
---|
3135 |
|
---|
3136 | if (aMergeForward)
|
---|
3137 | {
|
---|
3138 | // first, unregister the target since it may become a base
|
---|
3139 | // hard disk which needs re-registration
|
---|
3140 | rc = mParent->unregisterHardDisk(pTarget, NULL /*&fNeedsSaveSettings*/);
|
---|
3141 | AssertComRC(rc);
|
---|
3142 |
|
---|
3143 | // then, reparent it and disconnect the deleted branch at
|
---|
3144 | // both ends (chain->parent() is source's parent)
|
---|
3145 | pTarget->deparent();
|
---|
3146 | pTarget->setParent(pParentForTarget);
|
---|
3147 | if (aParentForTarget)
|
---|
3148 | pSource->deparent();
|
---|
3149 |
|
---|
3150 | // then, register again
|
---|
3151 | rc = mParent->registerHardDisk(pTarget, NULL /*&fNeedsSaveSettings*/);
|
---|
3152 | AssertComRC(rc);
|
---|
3153 | }
|
---|
3154 | else
|
---|
3155 | {
|
---|
3156 | Assert(pTarget->getChildren().size() == 1);
|
---|
3157 | Medium *targetChild = pTarget->getChildren().front();
|
---|
3158 |
|
---|
3159 | // disconnect the deleted branch at the elder end
|
---|
3160 | targetChild->deparent();
|
---|
3161 |
|
---|
3162 | // reparent source's children and disconnect the deleted
|
---|
3163 | // branch at the younger end
|
---|
3164 | com::SafeIfaceArray<IMedium> childrenToReparent(ComSafeArrayInArg(aChildrenToReparent));
|
---|
3165 | if (childrenToReparent.size() > 0)
|
---|
3166 | {
|
---|
3167 | /// @todo this is NOT fully working, the image open/parent change is missing.
|
---|
3168 | // See Medium::taskMergeHandler. Should be safe to add, as the VM is paused
|
---|
3169 | // right now. Should not get here, check in Console::onlineMergeMedium.
|
---|
3170 | AssertFailedReturn(E_FAIL);
|
---|
3171 | // obey {parent,child} lock order
|
---|
3172 | AutoWriteLock sourceLock(pSource COMMA_LOCKVAL_SRC_POS);
|
---|
3173 |
|
---|
3174 | for (size_t i = 0; i < childrenToReparent.size(); i++)
|
---|
3175 | {
|
---|
3176 | Medium *pMedium = static_cast<Medium *>(childrenToReparent[i]);
|
---|
3177 | AutoWriteLock childLock(pMedium COMMA_LOCKVAL_SRC_POS);
|
---|
3178 |
|
---|
3179 | pMedium->deparent(); // removes pMedium from source
|
---|
3180 | pMedium->setParent(pTarget);
|
---|
3181 | }
|
---|
3182 | }
|
---|
3183 | }
|
---|
3184 |
|
---|
3185 | /* unregister and uninitialize all hard disks removed by the merge */
|
---|
3186 | MediumLockList *pMediumLockList = NULL;
|
---|
3187 | rc = mData->mSession.mLockedMedia.Get(static_cast<MediumAttachment *>(aMediumAttachment),
|
---|
3188 | pMediumLockList);
|
---|
3189 | AssertReturn(SUCCEEDED(rc) && pMediumLockList, E_FAIL);
|
---|
3190 | MediumLockList::Base::iterator lockListBegin =
|
---|
3191 | pMediumLockList->GetBegin();
|
---|
3192 | MediumLockList::Base::iterator lockListEnd =
|
---|
3193 | pMediumLockList->GetEnd();
|
---|
3194 | for (MediumLockList::Base::iterator it = lockListBegin;
|
---|
3195 | it != lockListEnd;
|
---|
3196 | )
|
---|
3197 | {
|
---|
3198 | MediumLock &mediumLock = *it;
|
---|
3199 | /* Create a real copy of the medium pointer, as the medium
|
---|
3200 | * lock deletion below would invalidate the referenced object. */
|
---|
3201 | const ComObjPtr<Medium> pMedium = mediumLock.GetMedium();
|
---|
3202 |
|
---|
3203 | /* The target and all images not merged (readonly) are skipped */
|
---|
3204 | if ( pMedium == pTarget
|
---|
3205 | || pMedium->getState() == MediumState_LockedRead)
|
---|
3206 | {
|
---|
3207 | ++it;
|
---|
3208 | continue;
|
---|
3209 | }
|
---|
3210 |
|
---|
3211 | rc = mParent->unregisterHardDisk(pMedium,
|
---|
3212 | NULL /*pfNeedsSaveSettings*/);
|
---|
3213 | AssertComRC(rc);
|
---|
3214 |
|
---|
3215 | /* now, uninitialize the deleted hard disk (note that
|
---|
3216 | * due to the Deleting state, uninit() will not touch
|
---|
3217 | * the parent-child relationship so we need to
|
---|
3218 | * uninitialize each disk individually) */
|
---|
3219 |
|
---|
3220 | /* note that the operation initiator hard disk (which is
|
---|
3221 | * normally also the source hard disk) is a special case
|
---|
3222 | * -- there is one more caller added by Task to it which
|
---|
3223 | * we must release. Also, if we are in sync mode, the
|
---|
3224 | * caller may still hold an AutoCaller instance for it
|
---|
3225 | * and therefore we cannot uninit() it (it's therefore
|
---|
3226 | * the caller's responsibility) */
|
---|
3227 | if (pMedium == aSource)
|
---|
3228 | {
|
---|
3229 | Assert(pSource->getChildren().size() == 0);
|
---|
3230 | Assert(pSource->getFirstMachineBackrefId() == NULL);
|
---|
3231 | }
|
---|
3232 |
|
---|
3233 | /* Delete the medium lock list entry, which also releases the
|
---|
3234 | * caller added by MergeChain before uninit() and updates the
|
---|
3235 | * iterator to point to the right place. */
|
---|
3236 | rc = pMediumLockList->RemoveByIterator(it);
|
---|
3237 | AssertComRC(rc);
|
---|
3238 |
|
---|
3239 | pMedium->uninit();
|
---|
3240 | }
|
---|
3241 |
|
---|
3242 | return S_OK;
|
---|
3243 | }
|
---|