VirtualBox

source: vbox/trunk/doc/VBox-CodingGuidelines.cpp@ 62515

Last change on this file since 62515 was 57833, checked in by vboxsync, 9 years ago

VBox-CodingGuidelines.cpp: A couple doxygen hints, warning about UTF-8 string sources, officially forbid single and double underscores in symbols (thought everyone knew that).

  • Property svn:eol-style set to native
  • Property svn:keywords set to Author Date Id Revision
File size: 27.5 KB
Line 
1/* $Id: VBox-CodingGuidelines.cpp 57833 2015-09-18 20:08:10Z vboxsync $ */
2/** @file
3 * VBox - Coding Guidelines.
4 */
5
6/*
7 * Copyright (C) 2006-2012 Oracle Corporation
8 *
9 * This file is part of VirtualBox Open Source Edition (OSE), as
10 * available from http://www.virtualbox.org. This file is free software;
11 * you can redistribute it and/or modify it under the terms of the GNU
12 * General Public License (GPL) as published by the Free Software
13 * Foundation, in version 2 as it comes in the "COPYING" file of the
14 * VirtualBox OSE distribution. VirtualBox OSE is distributed in the
15 * hope that it will be useful, but WITHOUT ANY WARRANTY of any kind.
16 */
17
18/** @page pg_vbox_guideline VBox Coding Guidelines
19 *
20 * The VBox Coding guidelines are followed by all of VBox with the exception of
21 * qemu. Qemu is using whatever the frenchman does.
22 *
23 * There are a few compulsory rules and a bunch of optional ones. The following
24 * sections will describe these in details. In addition there is a section of
25 * Subversion 'rules'.
26 *
27 *
28 *
29 * @section sec_vbox_guideline_compulsory Compulsory
30 *
31 *
32 * - The indentation size is 4 chars.
33 *
34 * - Tabs are only ever used in makefiles.
35 *
36 * - Use RT and VBOX types.
37 *
38 * - Use Runtime functions.
39 *
40 * - Use the standard bool, uintptr_t, intptr_t and [u]int[1-9+]_t types.
41 *
42 * - Avoid using plain unsigned and int.
43 *
44 * - Use static wherever possible. This makes the namespace less polluted
45 * and avoids nasty name clash problems which can occur, especially on
46 * Unix-like systems. (1)
47 *
48 * - Public names are of the form Domain[Subdomain[]]Method, using mixed
49 * casing to mark the words. The main domain is all uppercase.
50 * (Think like java, mapping domain and subdomain to packages/classes.)
51 *
52 * - Public names are always declared using the appropriate DECL macro. (2)
53 *
54 * - Internal names starts with a lowercased main domain.
55 *
56 * - Defines are all uppercase and separate words with underscore.
57 * This applies to enum values too.
58 *
59 * - Typedefs are all uppercase and contain no underscores to distinguish
60 * them from defines.
61 *
62 * - Pointer typedefs start with 'P'. If pointer to const then 'PC'.
63 *
64 * - Function typedefs start with 'FN'. If pointer to FN then 'PFN'.
65 *
66 * - All files are case sensitive.
67 *
68 * - Slashes are unix slashes ('/') runtime converts when necessary.
69 *
70 * - char strings are UTF-8.
71 *
72 * - Strings from any external source must be treated with utmost care as
73 * they do not have to be valid UTF-8. Only trust internal strings.
74 *
75 * - All functions return VBox status codes. There are three general
76 * exceptions from this:
77 * -# Predicate functions. These are function which are boolean in
78 * nature and usage. They return bool. The function name will
79 * include 'Has', 'Is' or similar.
80 * -# Functions which by nature cannot possibly fail.
81 * These return void.
82 * -# "Get"-functions which return what they ask for.
83 * A get function becomes a "Query" function if there is any
84 * doubt about getting what is ask for.
85 *
86 * - VBox status codes have three subdivisions:
87 * -# Errors, which are VERR_ prefixed and negative.
88 * -# Warnings, which are VWRN_ prefixed and positive.
89 * -# Informational, which are VINF_ prefixed and positive.
90 *
91 * - Platform/OS operation are generalized and put in the IPRT.
92 *
93 * - Other useful constructs are also put in the IPRT.
94 *
95 * - The code shall not cause compiler warnings. Check this on ALL
96 * the platforms.
97 *
98 * - The use of symbols leading with single or double underscores is
99 * forbidden as that intrudes on reserved compiler/system namespace. (3)
100 *
101 * - All files have file headers with $Id and a file tag which describes
102 * the file in a sentence or two.
103 * Note: Use the svn-ps.cmd/svn-ps.sh utility with the -a option to add
104 * new sources with keyword expansion and exporting correctly
105 * configured.
106 *
107 * - All public functions are fully documented in Doxygen style using the
108 * javadoc dialect (using the 'at' instead of the 'slash' as
109 * commandprefix.)
110 *
111 * - All structures in header files are described, including all their
112 * members. (Doxygen style, of course.)
113 *
114 * - All modules have a documentation '\@page' in the main source file
115 * which describes the intent and actual implementation.
116 *
117 * - Code which is doing things that are not immediately comprehensible
118 * shall include explanatory comments.
119 *
120 * - Documentation and comments are kept up to date.
121 *
122 * - Headers in /include/VBox shall not contain any slash-slash C++
123 * comments, only ANSI C comments!
124 *
125 * - Comments on \#else indicates what begins while the comment on a
126 * \#endif indicates what ended. Only add these when there are more than
127 * a few lines (6-10) of \#ifdef'ed code, otherwise they're just clutter.
128 *
129 *
130 * (1) It is common practice on Unix to have a single symbol namespace for an
131 * entire process. If one is careless symbols might be resolved in a
132 * different way that one expects, leading to weird problems.
133 *
134 * (2) This is common practice among most projects dealing with modules in
135 * shared libraries. The Windows / PE __declspect(import) and
136 * __declspect(export) constructs are the main reason for this.
137 * OTOH, we do perhaps have a bit too detailed graining of this in VMM...
138 *
139 * (3) There are guys out there grepping public sources for symbols leading with
140 * single and double underscores as well as gotos and other things
141 * considered bad practice. They'll post statistics on how bad our sources
142 * are on some mailing list, forum or similar.
143 *
144 *
145 * @subsection sec_vbox_guideline_compulsory_sub64 64-bit and 32-bit
146 *
147 * Here are some amendments which address 64-bit vs. 32-bit portability issues.
148 *
149 * Some facts first:
150 *
151 * - On 64-bit Windows the type long remains 32-bit. On nearly all other
152 * 64-bit platforms long is 64-bit.
153 *
154 * - On all 64-bit platforms we care about, int is 32-bit, short is 16 bit
155 * and char is 8-bit.
156 * (I don't know about any platforms yet where this isn't true.)
157 *
158 * - size_t, ssize_t, uintptr_t, ptrdiff_t and similar are all 64-bit on
159 * 64-bit platforms. (These are 32-bit on 32-bit platforms.)
160 *
161 * - There is no inline assembly support in the 64-bit Microsoft compilers.
162 *
163 *
164 * Now for the guidelines:
165 *
166 * - Never, ever, use int, long, ULONG, LONG, DWORD or similar to cast a
167 * pointer to integer. Use uintptr_t or intptr_t. If you have to use
168 * NT/Windows types, there is the choice of ULONG_PTR and DWORD_PTR.
169 *
170 * - RT_OS_WINDOWS is defined to indicate Windows. Do not use __WIN32__,
171 * __WIN64__ and __WIN__ because they are all deprecated and scheduled
172 * for removal (if not removed already). Do not use the compiler
173 * defined _WIN32, _WIN64, or similar either. The bitness can be
174 * determined by testing ARCH_BITS.
175 * Example:
176 * @code
177 * #ifdef RT_OS_WINDOWS
178 * // call win32/64 api.
179 * #endif
180 * #ifdef RT_OS_WINDOWS
181 * # if ARCH_BITS == 64
182 * // call win64 api.
183 * # else // ARCH_BITS == 32
184 * // call win32 api.
185 * # endif // ARCH_BITS == 32
186 * #else // !RT_OS_WINDOWS
187 * // call posix api
188 * #endif // !RT_OS_WINDOWS
189 * @endcode
190 *
191 * - There are RT_OS_xxx defines for each OS, just like RT_OS_WINDOWS
192 * mentioned above. Use these defines instead of any predefined
193 * compiler stuff or defines from system headers.
194 *
195 * - RT_ARCH_X86 is defined when compiling for the x86 the architecture.
196 * Do not use __x86__, __X86__, __[Ii]386__, __[Ii]586__, or similar
197 * for this purpose.
198 *
199 * - RT_ARCH_AMD64 is defined when compiling for the AMD64 architecture.
200 * Do not use __AMD64__, __amd64__ or __x64_86__.
201 *
202 * - Take care and use size_t when you have to, esp. when passing a pointer
203 * to a size_t as a parameter.
204 *
205 * - Be wary of type promotion to (signed) integer. For example the
206 * following will cause u8 to be promoted to int in the shift, and then
207 * sign extended in the assignment 64-bit:
208 * @code
209 * uint8_t u8 = 0xfe;
210 * uint64_t u64 = u8 << 24;
211 * // u64 == 0xfffffffffe000000
212 * @endcode
213 *
214 *
215 * @subsection sec_vbox_guideline_compulsory_cppmain C++ guidelines for Main
216 *
217 * Main is currently (2009) full of hard-to-maintain code that uses complicated
218 * templates. The new mid-term goal for Main is to have less custom templates
219 * instead of more for the following reasons:
220 *
221 * - Template code is harder to read and understand. Custom templates create
222 * territories which only the code writer understands.
223 *
224 * - Errors in using templates create terrible C++ compiler messages.
225 *
226 * - Template code is really hard to look at in a debugger.
227 *
228 * - Templates slow down the compiler a lot.
229 *
230 * In particular, the following bits should be considered deprecated and should
231 * NOT be used in new code:
232 *
233 * - everything in include/iprt/cpputils.h (auto_ref_ptr, exception_trap_base,
234 * char_auto_ptr and friends)
235 *
236 * Generally, in many cases, a simple class with a proper destructor can achieve
237 * the same effect as a 1,000-line template include file, and the code is
238 * much more accessible that way.
239 *
240 * Using standard STL templates like std::list, std::vector and std::map is OK.
241 * Exceptions are:
242 *
243 * - Guest Additions because we don't want to link against libstdc++ there.
244 *
245 * - std::string should not be used because we have iprt::MiniString and
246 * com::Utf8Str which can convert efficiently with COM's UTF-16 strings.
247 *
248 * - std::auto_ptr<> in general; that part of the C++ standard is just broken.
249 * Write a destructor that calls delete.
250 *
251 *
252 * @subsection sec_vbox_guideline_compulsory_cppqtgui C++ guidelines for the Qt GUI
253 *
254 * The Qt GUI is currently (2010) on its way to become more compatible to the
255 * rest of VirtualBox coding style wise. From now on, all the coding style
256 * rules described in this file are also mandatory for the Qt GUI. Additionally
257 * the following rules should be respected:
258 *
259 * - GUI classes which correspond to GUI tasks should be prefixed by UI (no VBox anymore)
260 *
261 * - Classes which extents some of the Qt classes should be prefix by QI
262 *
263 * - General task classes should be prefixed by C
264 *
265 * - Slots are prefixed by slt -> sltName
266 *
267 * - Signals are prefixed by sig -> sigName
268 *
269 * - Use Qt classes for lists, strings and so on, the use of STL classes should
270 * be avoided
271 *
272 * - All files like .cpp, .h, .ui, which belong together are located in the
273 * same directory and named the same
274 *
275 *
276 * @subsection sec_vbox_guideline_compulsory_xslt XSLT
277 *
278 * XSLT (eXtensible Stylesheet Language Transformations) is used quite a bit in
279 * the Main API area of VirtualBox to generate sources and bindings to that API.
280 * There are a couple of common pitfalls worth mentioning:
281 *
282 * - Never do repeated //interface[@name=...] and //enum[@name=...] lookups
283 * because they are expensive. Instead delcare xsl:key elements for these
284 * searches and do the lookup using the key() function. xsltproc uses
285 * (per current document) hash tables for each xsl:key, i.e. very fast.
286 *
287 * - When output type is 'text' make sure to call xsltprocNewlineOutputHack
288 * from typemap-shared.inc.xsl every few KB of output, or xsltproc will
289 * end up wasting all the time reallocating the output buffer.
290 *
291 *
292 * @subsection sec_vbox_guideline_compulsory_doxygen Doxygen Comments
293 *
294 * As mentioned above, we shall use doxygen/javadoc style commenting of public
295 * functions, typedefs, classes and such. It is preferred to use this style in
296 * as many places as possible.
297 *
298 * A couple of hints on how to best write doxygen comments:
299 *
300 * - A good class, method, function, structure or enum doxygen comment
301 * starts with a one line sentence giving a brief description of the
302 * item. Details comes in a new paragraph (after blank line).
303 *
304 * - Except for list generators like \@todo, \@cfgm, \@gcfgm and others,
305 * all doxygen comments are related to things in the code. So, for
306 * instance you DO NOT add a doxygen \@note comment in the middle of a
307 * because you've got something important to note, you add a normal
308 * comment like 'Note! blah, very importan blah!'
309 *
310 * - We do NOT use TODO/XXX/BUGBUG or similar markers in the code to flag
311 * things needing fixing later, we always use \@todo doxygen comments.
312 *
313 * - There is no colon after the \@todo. And it is ALWAYS in a doxygen
314 * comment.
315 *
316 * - The \@retval tag is used to explain status codes a method/function may
317 * returns. It is not used to describe output parameters, that is done
318 * using the \@param or \@param[out] tag.
319 *
320 * See https://www.stack.nl/~dimitri/doxygen/manual/index.html for the official
321 * doxygen documention.
322 *
323 *
324 * @section sec_vbox_guideline_optional Optional
325 *
326 * First part is the actual coding style and all the prefixes. The second part
327 * is a bunch of good advice.
328 *
329 *
330 * @subsection sec_vbox_guideline_optional_layout The code layout
331 *
332 * - Max line length is 130 chars. Exceptions are table-like
333 * code/initializers and Log*() statements (don't waste unnecessary
334 * vertical space on debug logging).
335 *
336 * - Comments should try stay within the usual 80 columns as these are
337 * denser and too long lines may be harder to read.
338 *
339 * - Curly brackets are not indented. Example:
340 * @code
341 * if (true)
342 * {
343 * Something1();
344 * Something2();
345 * }
346 * else
347 * {
348 * SomethingElse1().
349 * SomethingElse2().
350 * }
351 * @endcode
352 *
353 * - Space before the parentheses when it comes after a C keyword.
354 *
355 * - No space between argument and parentheses. Exception for complex
356 * expression. Example:
357 * @code
358 * if (PATMR3IsPatchGCAddr(pVM, GCPtr))
359 * @endcode
360 *
361 * - The else of an if is always the first statement on a line. (No curly
362 * stuff before it!)
363 *
364 * - else and if go on the same line if no { compound statement }
365 * follows the if. Example:
366 * @code
367 * if (fFlags & MYFLAGS_1)
368 * fFlags &= ~MYFLAGS_10;
369 * else if (fFlags & MYFLAGS_2)
370 * {
371 * fFlags &= ~MYFLAGS_MASK;
372 * fFlags |= MYFLAGS_5;
373 * }
374 * else if (fFlags & MYFLAGS_3)
375 * @endcode
376 *
377 *
378 * - Slightly complex boolean expressions are split into multiple lines,
379 * putting the operators first on the line and indenting it all according
380 * to the nesting of the expression. The purpose is to make it as easy as
381 * possible to read. Example:
382 * @code
383 * if ( RT_SUCCESS(rc)
384 * || (fFlags & SOME_FLAG))
385 * @endcode
386 *
387 * - When 'if' or 'while' statements gets long, the closing parentheses
388 * goes right below the opening parentheses. This may be applied to
389 * sub-expression. Example:
390 * @code
391 * if ( RT_SUCCESS(rc)
392 * || ( fSomeStuff
393 * && fSomeOtherStuff
394 * && fEvenMoreStuff
395 * )
396 * || SomePredicateFunction()
397 * )
398 * {
399 * ...
400 * }
401 * @endcode
402 *
403 * - The case is indented from the switch (to avoid having the braces for
404 * the 'case' at the same level as the 'switch' statement).
405 *
406 * - If a case needs curly brackets they contain the entire case, are not
407 * indented from the case, and the break or return is placed inside them.
408 * Example:
409 * @code
410 * switch (pCur->eType)
411 * {
412 * case PGMMAPPINGTYPE_PAGETABLES:
413 * {
414 * unsigned iPDE = pCur->GCPtr >> PGDIR_SHIFT;
415 * unsigned iPT = (pCur->GCPtrEnd - pCur->GCPtr) >> PGDIR_SHIFT;
416 * while (iPT-- > 0)
417 * if (pPD->a[iPDE + iPT].n.u1Present)
418 * return VERR_HYPERVISOR_CONFLICT;
419 * break;
420 * }
421 * }
422 * @endcode
423 *
424 * - In a do while construction, the while is on the same line as the
425 * closing "}" if any are used.
426 * Example:
427 * @code
428 * do
429 * {
430 * stuff;
431 * i--;
432 * } while (i > 0);
433 * @endcode
434 *
435 * - Comments are in C style. C++ style comments are used for temporary
436 * disabling a few lines of code.
437 *
438 * - No unnecessary parentheses in expressions (just don't over do this
439 * so that gcc / msc starts bitching). Find a correct C/C++ operator
440 * precedence table if needed.
441 *
442 * - 'for (;;)' is preferred over 'while (true)' and 'while (1)'.
443 *
444 * - Parameters are indented to the start parentheses when breaking up
445 * function calls, declarations or prototypes. (This is in line with
446 * how 'if', 'for' and 'while' statements are done as well.) Example:
447 * @code
448 * RTPROCESS hProcess;
449 * int rc = RTProcCreateEx(papszArgs[0],
450 * papszArgs,
451 * RTENV_DEFAULT,
452 * fFlags,
453 * NULL, // phStdIn
454 * NULL, // phStdOut
455 * NULL, // phStdErr
456 * NULL, // pszAsUser
457 * NULL, // pszPassword
458 * &hProcess);
459 * @endcode
460 *
461 * - That Dijkstra is dead is no excuse for using gotos.
462 *
463 *
464 *
465 * @subsection sec_vbox_guideline_optional_prefix Variable / Member Prefixes
466 *
467 * Prefixes are meant to provide extra context clues to a variable/member, we
468 * therefore avoid using prefixes that just indicating the type if a better
469 * choice is available.
470 *
471 *
472 * The prefixes:
473 *
474 * - The 'g_' (or 'g') prefix means a global variable, either on file or module level.
475 *
476 * - The 's_' (or 's') prefix means a static variable inside a function or class.
477 *
478 * - The 'm_' (or 'm') prefix means a class data member.
479 *
480 * In new code in Main, use "m_" (and common sense). As an exception,
481 * in Main, if a class encapsulates its member variables in an anonymous
482 * structure which is declared in the class, but defined only in the
483 * implementation (like this: 'class X { struct Data; Data *m; }'), then
484 * the pointer to that struct is called 'm' itself and its members then
485 * need no prefix, because the members are accessed with 'm->member'
486 * already which is clear enough.
487 *
488 * - The 'a_' prefix means a parameter (argument) variable. This is
489 * sometimes written 'a' in parts of the source code that does not use
490 * the array prefix.
491 *
492 * - The 'p' prefix means pointer. For instance 'pVM' is pointer to VM.
493 *
494 * - The 'r' prefix means that something is passed by reference.
495 *
496 * - The 'k' prefix means that something is a constant. For instance
497 * 'enum { kStuff };'. This is usually not used in combination with
498 * 'p', 'r' or any such thing, it's main main use is to make enums
499 * easily identifiable.
500 *
501 * - The 'a' prefix means array. For instance 'aPages' could be read as
502 * array of pages.
503 *
504 * - The 'c' prefix means count. For instance 'cbBlock' could be read,
505 * count of bytes in block.
506 *
507 * - The 'cx' prefix means width (count of 'x' units).
508 *
509 * - The 'cy' prefix means height (count of 'y' units).
510 *
511 * - The 'x', 'y' and 'z' prefix refers to the x-, y- , and z-axis
512 * respectively.
513 *
514 * - The 'off' prefix means offset.
515 *
516 * - The 'i' or 'idx' prefixes usually means index. Although the 'i' one
517 * can sometimes just mean signed integer.
518 *
519 * - The 'i[1-9]+' prefix means a fixed bit size variable. Frequently
520 * used with the int[1-9]+_t types where the width is really important.
521 * In most cases 'i' is more appropriate. [type]
522 *
523 * - The 'e' (or 'enm') prefix means enum.
524 *
525 * - The 'u' prefix usually means unsigned integer. Exceptions follows.
526 *
527 * - The 'u[1-9]+' prefix means a fixed bit size variable. Frequently
528 * used with the uint[1-9]+_t types and with bitfields where the width is
529 * really important. In most cases 'u' or 'b' (byte) would be more
530 * appropriate. [type]
531 *
532 * - The 'b' prefix means byte or bytes. [type]
533 *
534 * - The 'f' prefix means flags. Flags are unsigned integers of some kind
535 * or booleans.
536 *
537 * - TODO: need prefix for real float. [type]
538 *
539 * - The 'rd' prefix means real double and is used for 'double' variables.
540 * [type]
541 *
542 * - The 'lrd' prefix means long real double and is used for 'long double'
543 * variables. [type]
544 *
545 * - The 'ch' prefix means a char, the (signed) char type. [type]
546 *
547 * - The 'wc' prefix means a wide/windows char, the RTUTF16 type. [type]
548 *
549 * - The 'uc' prefix means a Unicode Code point, the RTUNICP type. [type]
550 *
551 * - The 'uch' prefix means unsigned char. It's rarely used. [type]
552 *
553 * - The 'sz' prefix means zero terminated character string (array of
554 * chars). (UTF-8)
555 *
556 * - The 'wsz' prefix means zero terminated wide/windows character string
557 * (array of RTUTF16).
558 *
559 * - The 'usz' prefix means zero terminated Unicode string (array of
560 * RTUNICP).
561 *
562 * - The 'str' prefix means C++ string; either a std::string or, in Main,
563 * a Utf8Str or, in Qt, a QString. When used with 'p', 'r', 'a' or 'c'
564 * the first letter should be capitalized.
565 *
566 * - The 'bstr' prefix, in Main, means a UTF-16 Bstr. When used with 'p',
567 * 'r', 'a' or 'c' the first letter should be capitalized.
568 *
569 * - The 'pfn' prefix means pointer to function. Common usage is 'pfnCallback'
570 * and such like.
571 *
572 * - The 'psz' prefix is a combination of 'p' and 'sz' and thus means
573 * pointer to a zero terminated character string. (UTF-8)
574 *
575 * - The 'pcsz' prefix is used to indicate constant string pointers in
576 * parts of the code. Most code uses 'psz' for const and non-const
577 * string pointers.
578 *
579 * - The 'l' prefix means (signed) long. We try avoid using this,
580 * expecially with the 'LONG' types in Main as these are not 'long' on
581 * 64-bit non-Windows platforms and can cause confusion. Alternatives:
582 * 'i' or 'i32'. [type]
583 *
584 * - The 'ul' prefix means unsigned long. We try avoid using this,
585 * expecially with the 'ULONG' types in Main as these are not 'unsigned
586 * long' on 64-bit non-Windows platforms and can cause confusion.
587 * Alternatives: 'u' or 'u32'. [type]
588 *
589 *
590 * @subsection sec_vbox_guideline_optional_misc Misc / Advice / Stuff
591 *
592 * - When writing code think as the reader.
593 *
594 * - When writing code think as the compiler. (2)
595 *
596 * - When reading code think as if it's full of bugs - find them and fix them.
597 *
598 * - Pointer within range tests like:
599 * @code
600 * if ((uintptr_t)pv >= (uintptr_t)pvBase && (uintptr_t)pv < (uintptr_t)pvBase + cbRange)
601 * @endcode
602 * Can also be written as (assuming cbRange unsigned):
603 * @code
604 * if ((uintptr_t)pv - (uintptr_t)pvBase < cbRange)
605 * @endcode
606 * Which is shorter and potentially faster. (1)
607 *
608 * - Avoid unnecessary casting. All pointers automatically cast down to
609 * void *, at least for non class instance pointers.
610 *
611 * - It's very very bad practise to write a function larger than a
612 * screen full (1024x768) without any comprehensibility and explaining
613 * comments.
614 *
615 * - More to come....
616 *
617 *
618 * (1) Important, be very careful with the casting. In particular, note that
619 * a compiler might treat pointers as signed (IIRC).
620 *
621 * (2) "A really advanced hacker comes to understand the true inner workings of
622 * the machine - he sees through the language he's working in and glimpses
623 * the secret functioning of the binary code - becomes a Ba'al Shem of
624 * sorts." (Neal Stephenson "Snow Crash")
625 *
626 *
627 *
628 * @section sec_vbox_guideline_warnings Compiler Warnings
629 *
630 * The code should when possible compile on all platforms and compilers without any
631 * warnings. That's a nice idea, however, if it means making the code harder to read,
632 * less portable, unreliable or similar, the warning should not be fixed.
633 *
634 * Some of the warnings can seem kind of innocent at first glance. So, let's take the
635 * most common ones and explain them.
636 *
637 *
638 * @subsection sec_vbox_guideline_warnings_signed_unsigned_compare Signed / Unsigned Compare
639 *
640 * GCC says: "warning: comparison between signed and unsigned integer expressions"
641 * MSC says: "warning C4018: '<|<=|==|>=|>' : signed/unsigned mismatch"
642 *
643 * The following example will not output what you expect:
644@code
645#include <stdio.h>
646int main()
647{
648 signed long a = -1;
649 unsigned long b = 2294967295;
650 if (a < b)
651 printf("%ld < %lu: true\n", a, b);
652 else
653 printf("%ld < %lu: false\n", a, b);
654 return 0;
655}
656@endcode
657 * If I understood it correctly, the compiler will convert a to an
658 * unsigned long before doing the compare.
659 *
660 *
661 *
662 * @section sec_vbox_guideline_svn Subversion Commit Rules
663 *
664 *
665 * Before checking in:
666 *
667 * - Check Tinderbox and make sure the tree is green across all platforms. If it's
668 * red on a platform, don't check in. If you want, warn in the \#vbox channel and
669 * help make the responsible person fix it.
670 * NEVER CHECK IN TO A BROKEN BUILD.
671 *
672 * - When checking in keep in mind that a commit is atomic and that the Tinderbox and
673 * developers are constantly checking out the tree. Therefore do not split up the
674 * commit unless it's into 100% independent parts. If you need to split it up in order
675 * to have sensible commit comments, make the sub-commits as rapid as possible.
676 *
677 * - If you make a user visible change, such as fixing a reported bug,
678 * make sure you add an entry to doc/manual/user_ChangeLogImpl.xml.
679 *
680 * - If you are adding files make sure set the right attributes.
681 * svn-ps.sh/cmd was created for this purpose, please make use of it.
682 *
683 *
684 * After checking in:
685 *
686 * - After checking-in, you watch Tinderbox until your check-ins clear. You do not
687 * go home. You do not sleep. You do not log out or experiment with drugs. You do
688 * not become unavailable. If you break the tree, add a comment saying that you're
689 * fixing it. If you can't fix it and need help, ask in the \#innotek channel or back
690 * out the change.
691 *
692 * (Inspired by mozilla tree rules.)
693 */
694
Note: See TracBrowser for help on using the repository browser.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette